Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp295656rwd; Wed, 31 May 2023 23:44:37 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ41801zCvyg4zA0S//ufLhW49Ik/yv/SZMQLPOj9rinJaS4bsjNOKI7d79f/6Y6XRHMN4z2 X-Received: by 2002:a17:902:ea0e:b0:1b0:577c:2c5 with SMTP id s14-20020a170902ea0e00b001b0577c02c5mr6967889plg.30.1685601877114; Wed, 31 May 2023 23:44:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1685601877; cv=none; d=google.com; s=arc-20160816; b=xkEDOvQJtPaj4PYxkK3knBdeO0Dg3/pmyuw9BOvkIKApKm/skkY0adr1ZdkaVmYte8 XtB84X2pOrKHbwk4AB2Un1C70dfeATkdwBUIKnWOM0iYsDAOIDUM3HH/JftPY8ApMBDJ 0BrFY7J+exKZhTDiKlXzUkYRFh2Tp4on24f9Lu9hGkhVRuZUHWWp2Pew3MjPgzGyOyh6 E0PzQ7Ysj+cwfPcovi88qth8455nBOgwx/Vsi6dBNSGrX/j4Bzrb3xm4eoN0m2em4Uqs RzviJdgfB5BQvmJXuVY+rLXDmK1FG2I6QJNq72TaR53hmC0SCi8zIysFmam3ZSLoqgOu kBIQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=Ea1SMT7qEBRnMh48E2jTQG0Ln9vnQgtpWvl/lexFfV0=; b=bY2MQp/YW9sfmGLPRHpmgVZ/KLD926ZwOdhHJxfczgwfkZPwujxZwuceaRz2fl2Cza JGMn+B37TBj5z4fO78xZ16ecYHM/Ee976uq77nlNwORpibD+b2gE0M14rDaPT0rir/81 dpAVU6bkbQMZFnc8eK4736WLWtixWgmZda33qxC9GFqq1DOY/SxsxsilzVH+55Lw1zeT ykVSa6/CRL57Gfg7xuU7DznM9PL829zG1xu/ZLDxrxJaCweMPZ3pym0RaBW1YByHh542 dSJlnC3GDgjwP1Y3Z6m5aDEAGo6IuGQ2xHPdn+M8i/TbO9s+y1zrvSOSwyBO6UaEy+b2 YSNA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="cjZryNE/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id ik8-20020a170902ab0800b001ac84f87b0fsi2250888plb.339.2023.05.31.23.44.22; Wed, 31 May 2023 23:44:37 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="cjZryNE/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231341AbjFAG1m (ORCPT + 99 others); Thu, 1 Jun 2023 02:27:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46138 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231803AbjFAG1Z (ORCPT ); Thu, 1 Jun 2023 02:27:25 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5E3F3E2 for ; Wed, 31 May 2023 23:27:24 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id DABD964177 for ; Thu, 1 Jun 2023 06:27:23 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C7413C433D2; Thu, 1 Jun 2023 06:27:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1685600843; bh=B01TcQGDboiLGShWWyZcY4lDUPQ6pacYmh5T9cOJ9nU=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=cjZryNE/di2tcvyRk9knd6WUruHc2ePrJSF1kBDCpcRDVz/CuWqIsYMMkNDqr7nc8 xDKJRbF9uyIIowvfGZDFmwcfFPOCB86GgJj9UpPTGFoSRCiwnECUFAzCsHj3lxSWL2 moEHOMBYVGEAxJaP3yueWHGQtRV5tXmKeWpaPvGSy+wky7b93d9tKUH+XD46yemn7j pyQhxwOtBe5bIahgmBUueFgYPivEtvFNmsbWAb01ULEZ42hybf+6QElbiJC8AsnPi6 t6gIgn5IeKNp12ZLCHJEthAU8vf4KSrmuLxYvFJMRuUdWt/W/iNCLrDY6jfH441WO0 GJ5dD9YXslO+g== Date: Wed, 31 May 2023 23:27:21 -0700 From: Jakub Kicinski To: Jiasheng Jiang Cc: davem@davemloft.net, edumazet@google.com, pabeni@redhat.com, davthompson@nvidia.com, asmaa@nvidia.com, mkl@pengutronix.de, limings@nvidia.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mlxbf_gige: Add missing check for platform_get_irq Message-ID: <20230531232721.4ee4a46f@kernel.org> In-Reply-To: <20230601061908.1076-1-jiasheng@iscas.ac.cn> References: <20230601061908.1076-1-jiasheng@iscas.ac.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 1 Jun 2023 14:19:08 +0800 Jiasheng Jiang wrote: > Add the check for the return value of the platform_get_irq and > return error if it fails. > > Fixes: f92e1869d74e ("Add Mellanox BlueField Gigabit Ethernet driver") > Signed-off-by: Jiasheng Jiang BTW I looked thru my sent messages and I complained to you about not CCing people at least twice before. Please start paying attention or we'll stop paying attention to your patches.