Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <4dfd0f47-e1f7-1e9f-65e0-ee4881495be3@redhat.com>
Date:   Thu, 1 Jun 2023 09:52:01 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.10.0
To:     Lorenzo Stoakes <lstoakes@gmail.com>
Cc:     linux-kernel@vger.kernel.org, linux-mm@kvack.org,
        linux-kselftest@vger.kernel.org,
        Andrew Morton <akpm@linux-foundation.org>,
        Shuah Khan <shuah@kernel.org>, Jens Axboe <axboe@kernel.dk>,
        Peter Xu <peterx@redhat.com>, Jason Gunthorpe <jgg@nvidia.com>,
        John Hubbard <jhubbard@nvidia.com>, Jan Kara <jack@suse.cz>
References: <20230519102723.185721-1-david@redhat.com>
 <20230519102723.185721-2-david@redhat.com>
 <e49b5642-014b-4a95-9ba8-738bfd02b2ea@lucifer.local>
Content-Language: en-US
From:   David Hildenbrand <david@redhat.com>
Organization: Red Hat
Subject: Re: [PATCH v1 1/3] selftests/mm: factor out detection of hugetlb page
 sizes into vm_util
In-Reply-To: <e49b5642-014b-4a95-9ba8-738bfd02b2ea@lucifer.local>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 28.05.23 16:49, Lorenzo Stoakes wrote:
> On Fri, May 19, 2023 at 12:27:21PM +0200, David Hildenbrand wrote:
>> Let's factor detection out into vm_util, to be reused by a new test.
>>
> 
> Bit of a nit as it's hardly vitally important, but perhaps worth mentioning
> that you also refactor the function to accept any array (this is a
> requirement rather than simply refactoring a thing but still :)

Well, the function used to, and still does accept an array. It's just a 
more human-friendly way of expressing that.

If I have to resend the whole patchset, I can add a note "While at it, 
make the function accept an array instead of a raw pointer.".

[...]

> 
> Looks good to me,
> 
> Reviewed-by: Lorenzo Stoakes <lstoakes@gmail.com>
> 

Thanks!

-- 
Thanks,

David / dhildenb