Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230522112058.2965866-1-talumbau@google.com> <20230522112058.2965866-2-talumbau@google.com>
In-Reply-To: <20230522112058.2965866-2-talumbau@google.com>
From:   Yuanchu Xie <yuanchu@google.com>
Date:   Thu, 1 Jun 2023 16:01:51 +0800
Message-ID: <CAJj2-QG0cobX72VCOnbyZcb9FREvfj87Dr=6WR0dSHD0u03gDQ@mail.gmail.com>
Subject: Re: [PATCH mm-unstable 2/4] mm: multi-gen LRU: cleanup lru_gen_soft_reclaim()
To:     "T.J. Alumbaugh" <talumbau@google.com>
Cc:     Andrew Morton <akpm@linux-foundation.org>,
        Yu Zhao <yuzhao@google.com>, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org, linux-mm@google.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Reviewed-by: Yuanchu Xie <yuanchu@google.com>

On Mon, May 22, 2023 at 7:21=E2=80=AFPM T.J. Alumbaugh <talumbau@google.com=
> wrote:
>
> lru_gen_soft_reclaim() gets the lruvec from the memcg and node ID to keep=
 a
> cleaner interface on the caller side.
>
> Signed-off-by: T.J. Alumbaugh <talumbau@google.com>
> ---
>  include/linux/mmzone.h | 4 ++--
>  mm/memcontrol.c        | 2 +-
>  mm/vmscan.c            | 4 +++-
>  3 files changed, 6 insertions(+), 4 deletions(-)
>
> diff --git a/include/linux/mmzone.h b/include/linux/mmzone.h
> index 3a68326c9989..5a7ada0413da 100644
> --- a/include/linux/mmzone.h
> +++ b/include/linux/mmzone.h
> @@ -534,7 +534,7 @@ void lru_gen_exit_memcg(struct mem_cgroup *memcg);
>  void lru_gen_online_memcg(struct mem_cgroup *memcg);
>  void lru_gen_offline_memcg(struct mem_cgroup *memcg);
>  void lru_gen_release_memcg(struct mem_cgroup *memcg);
> -void lru_gen_soft_reclaim(struct lruvec *lruvec);
> +void lru_gen_soft_reclaim(struct mem_cgroup *memcg, int nid);
>
>  #else /* !CONFIG_MEMCG */
>
> @@ -585,7 +585,7 @@ static inline void lru_gen_release_memcg(struct mem_c=
group *memcg)
>  {
>  }
>
> -static inline void lru_gen_soft_reclaim(struct lruvec *lruvec)
> +static inline void lru_gen_soft_reclaim(struct mem_cgroup *memcg, int ni=
d)
>  {
>  }
>
> diff --git a/mm/memcontrol.c b/mm/memcontrol.c
> index d31fb1e2cb33..738ba18f3a0c 100644
> --- a/mm/memcontrol.c
> +++ b/mm/memcontrol.c
> @@ -485,7 +485,7 @@ static void mem_cgroup_update_tree(struct mem_cgroup =
*memcg, int nid)
>
>         if (lru_gen_enabled()) {
>                 if (soft_limit_excess(memcg))
> -                       lru_gen_soft_reclaim(&memcg->nodeinfo[nid]->lruve=
c);
> +                       lru_gen_soft_reclaim(memcg, nid);
>                 return;
>         }
>
> diff --git a/mm/vmscan.c b/mm/vmscan.c
> index cf18873a36b9..e088db138f5f 100644
> --- a/mm/vmscan.c
> +++ b/mm/vmscan.c
> @@ -4846,8 +4846,10 @@ void lru_gen_release_memcg(struct mem_cgroup *memc=
g)
>         }
>  }
>
> -void lru_gen_soft_reclaim(struct lruvec *lruvec)
> +void lru_gen_soft_reclaim(struct mem_cgroup *memcg, int nid)
>  {
> +       struct lruvec *lruvec =3D get_lruvec(memcg, nid);
> +
>         /* see the comment on MEMCG_NR_GENS */
>         if (lru_gen_memcg_seg(lruvec) !=3D MEMCG_LRU_HEAD)
>                 lru_gen_rotate_memcg(lruvec, MEMCG_LRU_HEAD);
> --
> 2.40.1.698.g37aff9b760-goog
>