Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230522112058.2965866-1-talumbau@google.com>
In-Reply-To: <20230522112058.2965866-1-talumbau@google.com>
From:   Yuanchu Xie <yuanchu@google.com>
Date:   Thu, 1 Jun 2023 16:01:16 +0800
Message-ID: <CAJj2-QGuYP68ZVfb1PAHmCnS8H+Bzkvpz3c7G9An4=FL-=JApg@mail.gmail.com>
Subject: Re: [PATCH mm-unstable 1/4] mm: multi-gen LRU: use macro for bitmap
To:     "T.J. Alumbaugh" <talumbau@google.com>
Cc:     Andrew Morton <akpm@linux-foundation.org>,
        Yu Zhao <yuzhao@google.com>, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org, linux-mm@google.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Reviewed-by: Yuanchu Xie <yuanchu@google.com>

On Mon, May 22, 2023 at 7:21=E2=80=AFPM T.J. Alumbaugh <talumbau@google.com=
> wrote:
>
> Use DECLARE_BITMAP macro when possible.
>
> Signed-off-by: T.J. Alumbaugh <talumbau@google.com>
> ---
>  mm/vmscan.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/vmscan.c b/mm/vmscan.c
> index 4637f6462e9c..cf18873a36b9 100644
> --- a/mm/vmscan.c
> +++ b/mm/vmscan.c
> @@ -4144,7 +4144,7 @@ static void walk_pmd_range(pud_t *pud, unsigned lon=
g start, unsigned long end,
>         unsigned long next;
>         unsigned long addr;
>         struct vm_area_struct *vma;
> -       unsigned long bitmap[BITS_TO_LONGS(MIN_LRU_BATCH)];
> +       DECLARE_BITMAP(bitmap, MIN_LRU_BATCH);
>         unsigned long first =3D -1;
>         struct lru_gen_mm_walk *walk =3D args->private;
>
> --
> 2.40.1.698.g37aff9b760-goog
>