Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <a849499f-ac42-aafd-f848-3166a8f26328@amd.com>
Date:   Thu, 1 Jun 2023 09:24:10 +0100
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.11.0
Subject: Re: [PATCH net v2] net/sched: flower: fix possible OOB write in
 fl_set_geneve_opt()
To:     Hangyu Hua <hbh25y@gmail.com>, jhs@mojatatu.com,
        xiyou.wangcong@gmail.com, jiri@resnulli.us, davem@davemloft.net,
        edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
        simon.horman@corigine.com
Cc:     netdev@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20230531102805.27090-1-hbh25y@gmail.com>
Content-Language: en-US
From:   Pieter Jansen van Vuuren <pieter.jansen-van-vuuren@amd.com>
In-Reply-To: <20230531102805.27090-1-hbh25y@gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MjFJM2xmYWpOK0pDb0RhSVR2MFBXY0ZDelc5ZEgreC9xb3gzNHU0THQvT1Nw?=
 =?utf-8?B?ZU5ZWEFOemwvSEE2OFdhNXgzSXUrVGNCenlocDd0Rmdtc1VsUmFIUlhERkN4?=
 =?utf-8?B?Tnl4aENOZnAxZHNSTHRkSnY0ZUNYQ09nSUJBM2NRamZ4QXhZWnlndUZ2N0xl?=
 =?utf-8?B?cW5vbzNvcXhqazRrQkUzRGthZkVaVXdMeDBrN3BGeVVXQUdxd2xpWnZWb2g1?=
 =?utf-8?B?aVIwdmNJbzlKeUxYQVh1akcrVVpHQkx4NXI0b0RoL0NTdGJRY3BsNUhjVVBw?=
 =?utf-8?B?bkJCalFlWDZrSDNkeVF1WG1qYVQ1MVBsTWthQ1RQZVFwWWJGWnBQbGlIUzNJ?=
 =?utf-8?B?WTdlbnVDS3VtWXpVL0FXME9WektXcnpmY200WkhuNlZwY2lJbHhLKyt2UDJK?=
 =?utf-8?B?WmgySkNKbE95Qk9KU3QrU2VSTDA2WmRwam1YSHdQY1VCbGlEc1daNVRkODNj?=
 =?utf-8?B?YXR5bWJZQkVabGRXRCsrZ3U1K2dmbmF6NDVrMEYySEgyQ2I1dkVLbGlFN080?=
 =?utf-8?B?eFNiWE9BdW8zaTRvcmY2NzQ0SnhSWmxxeENOSXlNY0E0Yk1XNldzbTVEV0Jh?=
 =?utf-8?B?M3drZ3ZTUGdzT0txYXY5MWR5QlVVQTNyYllTQnRyZDA4Q2FhcWVaZjhHbllX?=
 =?utf-8?B?RHBMNzc4dElla0paTVd1dkJLTHFESnVSQ00wSlVwNmNlM0Iyb1ZRaXhpc0Qw?=
 =?utf-8?B?RndCN1kvZ3NkMFNDd1MydHAzMlVLYzhjVi9DakVEQVBnWllLMUZVVnVtT3A0?=
 =?utf-8?B?VHo2SDk0dTMzTEFmOVV1R0l2WDhjaXJrbjNjU2RKTzR3OTROL2lPK2NWLzBl?=
 =?utf-8?B?QmI1TFhNYUJHNWorSE9hNFJYTWpUeDBVT1JzR0pHczRvbk02S0dGMjltcWNt?=
 =?utf-8?B?Y2F6TDAwL2RoNjZKMFhiSzY0YzUrb2Vlb1VodzNGazRLZFVjZlhubmM0aTBZ?=
 =?utf-8?B?Vm9tajMvUWFpdzZYUjRMREVveVlUd2F0dUNUSXQ1SkxzUDlPK2hBNk42Rkdu?=
 =?utf-8?B?SXQ3ZjRQRXRSRTlSaTVGZ3BjQkVmUGU1R0NHa0pqSDNoSjFMMnAvRVZnbDlz?=
 =?utf-8?B?ZmQ4TUdhTlI3anhScEl0OUJRSWUxMjRYNkJHenVxWEtoUThEa29VdVNyaWZ0?=
 =?utf-8?B?VzZxUjM1TlgwZWgyUDNQSUkzNFBSZzMxM2xpRmdubDhTM2R4UTNPRXVJeVJl?=
 =?utf-8?B?MnY2R3kxWmptYzV6TXlGVUhlSWlBUmdtQU9Jb2dKelU1Mk9yWkwwVFlJRUIw?=
 =?utf-8?B?QUpIWUhkZlFTUEVVV1lEbG90WE5PcjdhMCtIemczNXl3QXh0YmxKVHlRa3k4?=
 =?utf-8?B?R0trRHp6WEFHeFdKdFpocENjbExqamJzSkpnU2NOWTVWeEFwb3J0S2F0NU51?=
 =?utf-8?B?NGVLRDVCZG8yVE9ORlVGbUg2NjhaNHZnSlNTcGFqV01jK204QjNWbjlhYXg4?=
 =?utf-8?B?bVpjd1dlODFvOTlHTFA5b0dUcWE4b1U0MlRCWjBoRFUrRDhmKzBCSHFmNjNJ?=
 =?utf-8?B?WW91Q1h3QXkvTzRRbWo5VTJWdk1udEtTWjhPa3crb0RLL2d5Qk1WRXp0c2Q0?=
 =?utf-8?B?blk4ZWtzc2g0MjRpV0pwMHNFTWMzVndGODFFRjM3TzdCUmMzZXZaYk82Z3lK?=
 =?utf-8?B?ZFNCelRhVUtLSVp0RXFZVW14SzVoeXBQdENVT2ovY2JSNUJQanlYbkFnbmt6?=
 =?utf-8?B?cHVqYWpMU2dvQzV0N0dPYS9uMnlZb3dydzVEWnJEdFl2NkljYllKVVloMXRB?=
 =?utf-8?B?dy90K2k2dkUzK3BscHZ5VFVOd3h1VVRqa1JhSlQ2RlI0ampuTjk4elpDbFNN?=
 =?utf-8?B?WTJkVFJIV04yV3pvc3ZDMXd3Y0gwOFZUT3J3OTRHK0Y5YVBpa1lHaDRzdldZ?=
 =?utf-8?B?TGhsbzNwVS93Wk5laGVYYTlhWW5aaHVvTTRiVVNIY29WVG83M2ZWTDVKVnJo?=
 =?utf-8?B?aUZiK1krTzZiMFU3RllzZmlNd2tDQllEaCt3ekV4SHlOYjI2Mlo3M05iY3Z5?=
 =?utf-8?B?NFp5TCtMRGx0Y0ROVTdvVDN4NkFYcVVOOEpuWXdMaU9XUlBCQ3pGdVRpTWt3?=
 =?utf-8?B?R29DTEpCMVpDUCtNeTJMMThLVWxCdHRDNjh0OWNsMTZ5SXJ1bjg0akFLZDIy?=
 =?utf-8?Q?9MtouMITwU5BvH0N/rtQyRYD0?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 03e45cae-1885-45b0-6e06-08db62799691
X-MS-Exchange-CrossTenant-AuthSource: DM8PR12MB5398.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Jun 2023 08:24:16.2970
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 3iH0gXKEMDt899MnnFeojXp25I4KLRsAYONZ6uF/9oe5g2T/UxbJqAMfYHgqXDPx
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR12MB5273
X-Spam-Status: No, score=-1.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,NICE_REPLY_A,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 31/05/2023 11:28, Hangyu Hua wrote:
> If we send two TCA_FLOWER_KEY_ENC_OPTS_GENEVE packets and their total
> size is 252 bytes(key->enc_opts.len = 252) then
> key->enc_opts.len = opt->length = data_len / 4 = 0 when the third
> TCA_FLOWER_KEY_ENC_OPTS_GENEVE packet enters fl_set_geneve_opt. This
> bypasses the next bounds check and results in an out-of-bounds.
> 
> Fixes: 0a6e77784f49 ("net/sched: allow flower to match tunnel options")
> Signed-off-by: Hangyu Hua <hbh25y@gmail.com>

Reviewed-by: Pieter Jansen van Vuuren <pieter.jansen-van-vuuren@amd.com>