Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp446287rwd; Thu, 1 Jun 2023 02:27:01 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7O3ibgGaXE6ylfySpuqAoErXgE/lkNxzXcMMrexLX0TDJ/g513suZkIKbh6905E3XvAoji X-Received: by 2002:a17:902:a518:b0:1aa:e938:3ddf with SMTP id s24-20020a170902a51800b001aae9383ddfmr5250571plq.7.1685611620923; Thu, 01 Jun 2023 02:27:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1685611620; cv=none; d=google.com; s=arc-20160816; b=ya7LGY04diNCDjlTsMUay7NIzwRFe9EIVWVbryyM594m5oi3y2tdpsvZaYF9D3yATk WmJbw2QpuaJiEUS8ED5Bxexmv2ZmvNQmTI314PxWFQsLsiyIhA6LW7dDSE76zDj6B5zV cEOKMPUT1m730jcCiXy8pdhMrglXaHXBS+85XcneXTDhoRq3Obv4AVHl5M6IE/ai3XsE QJzsqKQ99WAUdjZzLYlyioRaD6oS5AQcq68ZGEj/f8YXRLnUGM6e2N9OA6FmHVQ8975b oei75brfXvJjDjwJ42PWw+duc3ZuMxAQGz/NuAZx1GOx6wvVLMOKoajePr8lqxuY66wc WZGA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:user-agent :content-transfer-encoding:references:in-reply-to:date:cc:to:from :subject:message-id:dkim-signature; bh=g14oLQSgEmt6zzVDTbcm+P3Q+U0P9qW/qGUNJAVuUPE=; b=g7PNsZzhxZnsW19cdeXfVlaVd3wvMyyZwesvyN3L9b/g6aZMMfH2PZeFt9XGnh1i01 7lWL2ej6TvpJAbb3xv5207d5EtMLQ6DNB5ZR5VA/o/D+ZBya1i4q9RxceYOq9IHeHTDr cc4vNWGOWl2WChD+4Q2Ycqd9HqeRs3/iFC4Wo+ZALFJqyzsVNqumsfjIxCsQNFgWKQ2D Kf8QtzjKGmW/OxZGHILoENc5noKPamw81dAR6P7CEla46NsaeYb/TXh5hmrz9GM499VX dQ/iZysJznqDWKa6v+BA6Q3dtL7Wt6TgMm05AuuH3uI42DIdmCFKzUhaXjtf+PxFxAMo bJDQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=VylsQlPR; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id jb7-20020a170903258700b001a9f42553ddsi503689plb.296.2023.06.01.02.26.46; Thu, 01 Jun 2023 02:27:00 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=VylsQlPR; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232683AbjFAJLi (ORCPT + 99 others); Thu, 1 Jun 2023 05:11:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35798 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232673AbjFAJLg (ORCPT ); Thu, 1 Jun 2023 05:11:36 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E192E1B0 for ; Thu, 1 Jun 2023 02:10:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1685610637; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=g14oLQSgEmt6zzVDTbcm+P3Q+U0P9qW/qGUNJAVuUPE=; b=VylsQlPRsP/8exxbLkaGXHNjXJjdQ8z86QYJYkdZHpMKqaY06lo+Fonv7hx+EUR5nXu4rK 65DQi19jNzDUEoKgFiVV5yKQs1VC4truTate37/FsMVV+5jtC+5aga0DkM4f2hmk3vpzwb jSZvqCul1cb+/KnlAwVlAvraceUVGmA= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-271-EquZ1fcWN7GPY8WLBLqrDQ-1; Thu, 01 Jun 2023 05:10:35 -0400 X-MC-Unique: EquZ1fcWN7GPY8WLBLqrDQ-1 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-3f605aec1dcso992735e9.0 for ; Thu, 01 Jun 2023 02:10:35 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685610634; x=1688202634; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=g14oLQSgEmt6zzVDTbcm+P3Q+U0P9qW/qGUNJAVuUPE=; b=hZwELfkBG6BAKfjHTLzVInwoy3Hb/AQ3pTyVcNzhQXnU7OzooTgGdWGR7IAqVfgoGa Nh3uuSe5PdrhkvxG/BzDxE/SY6G0dIFOMmA49qVjMYOO19Tm1KvI7AEYjEUiTnUao30f sMISti7L/PbXrmKMN5Uhsnvi+a2n0IjirLjCcisbBcUW0NC/X9RNe7+qwOEYaBdUbZ0d 6MUDE0bLJolw7J4XW917XAmzFszgF1bz4cTtLQjD52JGHVWvFI3E5Xt4ctc2jRp2Y39F uGHq+DfQvbvyaUFdLjffusztCMemNQcM0qMdHhl38sEtF1JEcx/FyQqFpAkFm86pSFU9 hdfQ== X-Gm-Message-State: AC+VfDzTh0IThEKEq7rGBD6TzlacFT5cbnM/sredrVyARa8NLVj35jHH Dk9u0DkG5m2mKZj2hZiPU1ZbmeaLcnuoHJ7tk2PbtUuNq88+RE18I6MmQKzgkk40Y6HH0/4VAz0 1RSkem72V0dUEPsAGWeS/pDx7 X-Received: by 2002:a5d:65cd:0:b0:30a:de3e:9662 with SMTP id e13-20020a5d65cd000000b0030ade3e9662mr4035105wrw.5.1685610634682; Thu, 01 Jun 2023 02:10:34 -0700 (PDT) X-Received: by 2002:a5d:65cd:0:b0:30a:de3e:9662 with SMTP id e13-20020a5d65cd000000b0030ade3e9662mr4035097wrw.5.1685610634405; Thu, 01 Jun 2023 02:10:34 -0700 (PDT) Received: from gerbillo.redhat.com (146-241-242-89.dyn.eolo.it. [146.241.242.89]) by smtp.gmail.com with ESMTPSA id r13-20020adfce8d000000b0030630de6fbdsm9441149wrn.13.2023.06.01.02.10.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 01 Jun 2023 02:10:33 -0700 (PDT) Message-ID: Subject: Re: [PATCH v4 4/4] sock: Remove redundant cond of memcg pressure From: Paolo Abeni To: Abel Wu , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Johannes Weiner , Michal Hocko , Vladimir Davydov , Shakeel Butt , Muchun Song Cc: Simon Horman , netdev@vger.kernel.org, linux-mm@kvack.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org Date: Thu, 01 Jun 2023 11:10:32 +0200 In-Reply-To: <20230530114011.13368-5-wuyun.abel@bytedance.com> References: <20230530114011.13368-1-wuyun.abel@bytedance.com> <20230530114011.13368-5-wuyun.abel@bytedance.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.4 (3.46.4-1.fc37) MIME-Version: 1.0 X-Spam-Status: No, score=-2.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2023-05-30 at 19:40 +0800, Abel Wu wrote: > Now with the previous patch, __sk_mem_raise_allocated() considers > the memory pressure of both global and the socket's memcg on a func- > wide level,=C2=A0 Since the "previous patch" (aka "sock: Consider memcg pressure when raising sockmem") has been dropped in this series revision, I guess this patch should be dropped, too? Is this targeting the 'net-next' tree or the 'net' one? please specify the target tree into the subj line. I think we could consider net-next for this series, given the IMHO not trivial implications. Cheers, Paolo