Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <ef3aaee1-e6ca-a89d-e002-42bf918736f4@collabora.com>
Date:   Thu, 1 Jun 2023 11:29:47 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.11.2
Subject: Re: [PATCH 4/8] mediatek: vcodec: remove the dependency of debug log
Content-Language: en-US
To:     Yunfei Dong <yunfei.dong@mediatek.com>,
        Chen-Yu Tsai <wenst@chromium.org>,
        Nicolas Dufresne <nicolas.dufresne@collabora.com>,
        Hans Verkuil <hverkuil-cisco@xs4all.nl>,
        Benjamin Gaignard <benjamin.gaignard@collabora.com>,
        =?UTF-8?Q?N=c3=adcolas_F_=2e_R_=2e_A_=2e_Prado?= 
        <nfraprado@collabora.com>, Nathan Hebert <nhebert@chromium.org>
Cc:     Hsin-Yi Wang <hsinyi@chromium.org>,
        Fritz Koenig <frkoenig@chromium.org>,
        Daniel Vetter <daniel@ffwll.ch>,
        Steve Cho <stevecho@chromium.org>, linux-media@vger.kernel.org,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org,
        linux-mediatek@lists.infradead.org,
        Project_Global_Chrome_Upstream_Group@mediatek.com
References: <20230601030256.29875-1-yunfei.dong@mediatek.com>
 <20230601030256.29875-5-yunfei.dong@mediatek.com>
From:   AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@collabora.com>
In-Reply-To: <20230601030256.29875-5-yunfei.dong@mediatek.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

Il 01/06/23 05:02, Yunfei Dong ha scritto:
> 'mtk_vcodec_debug' and 'mtk_vcodec_err' depends on 'mtk_vcodec_ctx'
> to get the index of each instance, using the index directly instead
> of with 'mtk_vcodec_ctx'.
> 
> Signed-off-by: Yunfei Dong <yunfei.dong@mediatek.com>
> ---
>   .../mediatek/vcodec/mtk_vcodec_util.h         |  36 +++--
>   .../vcodec/vdec/vdec_av1_req_lat_if.c         |  78 +++++------
>   .../mediatek/vcodec/vdec/vdec_h264_if.c       |  46 +++----
>   .../mediatek/vcodec/vdec/vdec_h264_req_if.c   |  32 ++---
>   .../vcodec/vdec/vdec_h264_req_multi_if.c      |  62 ++++-----
>   .../vcodec/vdec/vdec_hevc_req_multi_if.c      |  54 ++++----
>   .../mediatek/vcodec/vdec/vdec_vp8_if.c        |  38 +++---
>   .../mediatek/vcodec/vdec/vdec_vp8_req_if.c    |  36 ++---
>   .../mediatek/vcodec/vdec/vdec_vp9_if.c        | 128 +++++++++---------
>   .../vcodec/vdec/vdec_vp9_req_lat_if.c         |  67 ++++-----
>   .../platform/mediatek/vcodec/vdec_vpu_if.c    |  48 +++----
>   .../mediatek/vcodec/venc/venc_h264_if.c       |  74 +++++-----
>   .../mediatek/vcodec/venc/venc_vp8_if.c        |  44 +++---
>   .../platform/mediatek/vcodec/venc_vpu_if.c    |  54 ++++----
>   14 files changed, 399 insertions(+), 398 deletions(-)
> 
> diff --git a/drivers/media/platform/mediatek/vcodec/mtk_vcodec_util.h b/drivers/media/platform/mediatek/vcodec/mtk_vcodec_util.h
> index ecb0bdf3a4f4..f018af38b39d 100644
> --- a/drivers/media/platform/mediatek/vcodec/mtk_vcodec_util.h
> +++ b/drivers/media/platform/mediatek/vcodec/mtk_vcodec_util.h
> @@ -31,42 +31,38 @@ struct mtk_vcodec_dev;
>   #define mtk_v4l2_err(fmt, args...)                \
>   	pr_err("[MTK_V4L2][ERROR] " fmt "\n", ##args)
>   
> -#define mtk_vcodec_err(h, fmt, args...)				\
> -	pr_err("[MTK_VCODEC][ERROR][%d]: " fmt "\n",		\
> -	       ((struct mtk_vcodec_ctx *)(h)->ctx)->id, ##args)
> +#define mtk_vcodec_err(inst_id, fmt, args...)                          \
> +	pr_err("[MTK_VCODEC][ERROR][%d]: " fmt "\n", inst_id, ##args)
>   

This *huge* cleanup (congrats btw!) would be a great occasion to change those
pr_err() to dev_err(). Can we do that?

Regards,
Angelo