Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <78488c71-eef5-1a44-0b85-73c7ad0848c9@opensource.cirrus.com>
Date:   Thu, 1 Jun 2023 10:42:56 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.11.0
Subject: Re: CSC3551 and devices missing related _DSD bits
To:     Armas Spann <armas@codux.tech>, Luke Jones <luke@ljones.dev>,
        Takashi Iwai <tiwai@suse.de>
CC:     <linux-kernel@vger.kernel.org>, <tiwai@suse.com>,
        <sbinding@opensource.cirrus.com>, <perex@perex.cz>,
        <tangmeng@uniontech.com>, <andy.chi@canonical.com>,
        <p.jungkamp@gmx.net>, <kasper93@gmail.com>,
        <yangyuchi66@gmail.com>, <ealex95@gmail.com>,
        <james.schulman@cirrus.com>, <david.rhodes@cirrus.com>,
        <tanureal@opensource.cirrus.com>, <rf@opensource.cirrus.com>,
        <patches@opensource.cirrus.com>, <alsa-devel@alsa-project.org>
References: <1991650.PYKUYFuaPT@fedora> <87jzx3zaf8.wl-tiwai@suse.de>
 <b4c202b2-ab29-e2aa-b141-0c967b2c1645@opensource.cirrus.com>
 <19d69a5da8f1d4017ac14ed87f927ab82278073d.camel@ljones.dev>
 <12102f7419c5e44cd2133aa769e25dbd16f4e0c9.camel@codux.tech>
From:   Stuart Henderson <stuarth@opensource.cirrus.com>
In-Reply-To: <12102f7419c5e44cd2133aa769e25dbd16f4e0c9.camel@codux.tech>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk


> Hi Takashi, Hi Stuart (and of course, all others in here),
>
> would you mind to evaluate this small (pseudo-)patch to be harmless?
> (concerning the blow-up theory the first answer in this converstion)
>
> I won't push it upstream right now but I want to know if this patch
> might be harmfull. I'm owning a GA402XY myself and we digged out that
> the initial setting of the cr3551 can be done via:
>
> diff --git a/sound/pci/hda/cs35l41_hda.c b/sound/pci/hda/cs35l41_hda.c
> index 75020edd39e7..eaa06751bd48 100644
> --- a/sound/pci/hda/cs35l41_hda.c
> +++ b/sound/pci/hda/cs35l41_hda.c
> @@ -1243,6 +1243,12 @@ static int cs35l41_no_acpi_dsd(struct
> cs35l41_hda *cs35l41, struct device *physd
>   		hw_cfg->bst_type = CS35L41_EXT_BOOST;
>   		hw_cfg->gpio1.func = CS35l41_VSPK_SWITCH;
>   		hw_cfg->gpio1.valid = true;
> +	} else if (strncmp(hid, "CSC3551", 7) == 0 && strcmp(cs35l41-
>> acpi_subsystem_id, "10431463") == 0) {
> +		// TESTING - (Hook for GA402X)
> +		dev_warn(cs35l41->dev, "Warning: ASUS didn't provide
> the needed ACPI _DSD properties for GA402X series, using defaults..");
> +		hw_cfg->bst_type = CS35L41_EXT_BOOST;
> +		hw_cfg->gpio1.func = CS35l41_VSPK_SWITCH;
> +		hw_cfg->gpio1.valid = true;
>   	} else {
>   		/*
>   		 * Note: CLSA010(0/1) are special cases which use a
> slightly different design.
I wouldn't recommend making speculative changes like the above. There 
are no "default" values as these attributes describe the hardware for 
the particular device and these can be different on each SKU.  In this 
case, it looks like the boost is being set incorrectly.  We're looking 
into how we can support these older devices, so please bear with us 
while we investigate.