Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230529140711.896830-1-hugo@hugovil.com> <20230529140711.896830-8-hugo@hugovil.com>
 <ZHUpWQafRPHW1RJQ@surfacebook> <20230530113649.73f28b9f6ba91f17ace1e12f@hugovil.com>
 <CAHp75Vf35rN93sXFBU0nRZQLpUgQHR2caGC8BmHkEgPZqF=dQg@mail.gmail.com> <20230531195723.462b140ac041b790711c1a7f@hugovil.com>
In-Reply-To: <20230531195723.462b140ac041b790711c1a7f@hugovil.com>
From:   Andy Shevchenko <andy.shevchenko@gmail.com>
Date:   Thu, 1 Jun 2023 12:24:42 +0300
Message-ID: <CAHp75VcNihyzn3t8C48w1V+WWRk_zj8Br7shTfbHLU09u4OtcA@mail.gmail.com>
Subject: Re: [PATCH v4 7/9] serial: sc16is7xx: fix regression with GPIO configuration
To:     Hugo Villeneuve <hugo@hugovil.com>
Cc:     gregkh@linuxfoundation.org, robh+dt@kernel.org,
        krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
        jirislaby@kernel.org, jringle@gridpoint.com,
        l.perczak@camlintechnologies.com, tomasz.mon@camlingroup.com,
        linux-serial@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org,
        Hugo Villeneuve <hvilleneuve@dimonoff.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Thu, Jun 1, 2023 at 2:57=E2=80=AFAM Hugo Villeneuve <hugo@hugovil.com> w=
rote:
> On Wed, 31 May 2023 00:56:57 +0300
> Andy Shevchenko <andy.shevchenko@gmail.com> wrote:
> > On Tue, May 30, 2023 at 6:36=E2=80=AFPM Hugo Villeneuve <hugo@hugovil.c=
om> wrote:
> > > On Tue, 30 May 2023 01:38:17 +0300
> > > andy.shevchenko@gmail.com wrote:
> > > > Mon, May 29, 2023 at 10:07:09AM -0400, Hugo Villeneuve kirjoitti:

...

> > > > > +           of_property_for_each_u32(dev->of_node, "nxp,modem-con=
trol-line-ports",
> > > > > +                                    prop, p, u) {
> > > > > +                   if (u >=3D devtype->nr_uart)
> > > > > +                           continue;
> > > > > +
> > > > > +                   /* Use GPIO lines as modem control lines */
> > > > > +                   if (u =3D=3D 0)
> > > > > +                           mctrl_mask |=3D SC16IS7XX_IOCONTROL_M=
ODEM_A_BIT;
> > > > > +                   else if (u =3D=3D 1)
> > > > > +                           mctrl_mask |=3D SC16IS7XX_IOCONTROL_M=
ODEM_B_BIT;
> > > > > +           }
> > > >
> > > > Can we use device properties, please?
> > >
> > > I have converted this section to use device_property_count_u32() and =
device_property_read_u32_array(). Is that Ok?
> >
> > Yes, thank you!
>
> Hi Andy,
> now that I am using the device property API, I think I no longer have the=
 need to test for "if (dev->of_node)" before reading the new property "nxp,=
modem-control-line-ports"?
>
> If that is the case, I will leave the test "if (dev->of_node)" only for t=
he "irda-mode-ports" property.
>
> The pseudo code woulk look like this:
>
>         if (dev->of_node) {
>                 struct property *prop;
>                 const __be32 *p;
>                 u32 u;
>
>                 of_property_for_each_u32(dev->of_node, "irda-mode-ports",
>                                          prop, p, u)
>                         if (u < devtype->nr_uart)
>                                 s->p[u].irda_mode =3D true;
>         }
>
>         /* Read "nxp,modem-control-line-ports" using device property API.=
 */
>         sc16is7xx_setup_mctrl_ports(dev);

Looks good to me, thank you for following the advice!

--=20
With Best Regards,
Andy Shevchenko