Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp545896rwd; Thu, 1 Jun 2023 03:50:37 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7lAdxILefGbscj+4JT/MRntzMgHlqE8jq7r3zxuy7fdYY40EUAZSXcRMw0G5VK20gpZ3SM X-Received: by 2002:a05:6e02:5cf:b0:33b:b6b9:a79d with SMTP id l15-20020a056e0205cf00b0033bb6b9a79dmr4795726ils.31.1685616637237; Thu, 01 Jun 2023 03:50:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1685616637; cv=none; d=google.com; s=arc-20160816; b=w7gtCc2M11hm5ubOWmFeqpNy8oawvXVWIq8/0PXmT9EZVJ+abhaIvC2JFTSStIwdLO YyrqbBCyF46hOz7iqDNbm7I23q4wNVsPIS3NirhcTrkpgMhsv6/QGFxR4SFn9xpJHzsP sf8Ks6nsCAqJvB97yG3zdR/niXll/I83qpPvl7pwdNpU7iVcK5j8Al2IHfwoFy08da3n xAC905B2boOpDY3vpzmmNW5kVWi/aPYUIu9JQMKRpWwRB1RQdrqmWhaflecR9Y+mJ3DO Lq4LecWF3Ij443rNNMXypkSaVPkKgF2+XwvGN7yCyJcSxTOJPV/jTQY/tjaX07WLFiBn yIsA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:dkim-signature; bh=/uEoDe0BdlTJWH5TzZPVetiG1tUaWPoBMaxRoL8Qq0k=; b=jiwu2rX0OF5m2kMxQ121xy288zMKjcrvhbuLR1v2cHITmxuo4xNBFjhxX9DMo4m6dQ QpYqLkDWQHsRpA/b4GNAR/bmiklU624ySiEr1YmWGP6ulS/cnEW4+aEk6q3ZkfKpdTjT Pvhzwy4MtUaAMwegoS4kFgyZWS+TMEWVBnD3cbkIG/GLyG87icniLnIUjItO45WlTyFN TSea7v/K5sDOD9Dfu5iVK1fphYm/4p7De9jVdQ6TtTCk8GtcQRMvx2r63YoXGLdWHC8b zdnKCrrBSVCgpNoY6aoWAsbSsWWES8NeRJU/cgVxhRCkSEOVi5nLNK/x8/28OSSAzons 5UEg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=RdHL7c+U; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id z128-20020a626586000000b0064d6a514682si3350398pfb.366.2023.06.01.03.50.23; Thu, 01 Jun 2023 03:50:37 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=RdHL7c+U; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232877AbjFAK2u (ORCPT + 99 others); Thu, 1 Jun 2023 06:28:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35836 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232910AbjFAK21 (ORCPT ); Thu, 1 Jun 2023 06:28:27 -0400 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3F4B51738; Thu, 1 Jun 2023 03:27:43 -0700 (PDT) Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 351AN8eF020217; Thu, 1 Jun 2023 10:27:21 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=qcppdkim1; bh=/uEoDe0BdlTJWH5TzZPVetiG1tUaWPoBMaxRoL8Qq0k=; b=RdHL7c+U4yCmqqI9JNh/jelydsI4BUHktbRg9iOKQ0yuaebmFIg6qnhjK8fAd6EyxlmM BFi5xZtleU8s5FtmX1S+eTVVVNIVi5HW+Z8T0nxE3l+lQIzrihHho1hAr/mvfG94obl+ Orq7OqBXmV1CDoQ1a4iDWXlCMLhVXhh6FwNFszJlVWduoGrnC6uPqygJXNzs/utI5Aer XZqdTHkyVfIkbQH1jO+PWJNiU3PlMwaS3uHOBjqAAMUVZIQTfopePfCa0TO6aacBwlUw mr3Wuwo0JyMveT+sEKxHXgtte5FoiX3YpYygcY/foQRxXtE7MIfCIQFJB1RE2WC260dm Uw== Received: from nasanppmta02.qualcomm.com (i-global254.qualcomm.com [199.106.103.254]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3qxpt70drq-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 01 Jun 2023 10:27:21 +0000 Received: from nasanex01a.na.qualcomm.com (nasanex01a.na.qualcomm.com [10.52.223.231]) by NASANPPMTA02.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 351ARK0E003031 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 1 Jun 2023 10:27:20 GMT Received: from [192.168.143.77] (10.80.80.8) by nasanex01a.na.qualcomm.com (10.52.223.231) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.42; Thu, 1 Jun 2023 03:27:19 -0700 Message-ID: <962ae163-ffc1-6e4b-35b9-dd893a49d038@quicinc.com> Date: Thu, 1 Jun 2023 03:27:19 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH v1 1/1] scsi: ufs: core: Fix ufshcd_inc_sq_tail function bug Content-Language: en-US To: Zhang Hui , Alim Akhtar , Avri Altman , Bart Van Assche , "James E . J . Bottomley" , "Martin K . Petersen" CC: Can Guo , Manivannan Sadhasivam , Asutosh Das , Arthur Simchaev , Krzysztof Kozlowski , zhanghui , Bean Huo , , , , References: <20230601091357.1365-1-zhanghui31@xiaomi.com> From: "Bao D. Nguyen" In-Reply-To: <20230601091357.1365-1-zhanghui31@xiaomi.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nasanex01a.na.qualcomm.com (10.52.223.231) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-ORIG-GUID: uQSpTuZAm2DljchH2-OEguR08OjgkORI X-Proofpoint-GUID: uQSpTuZAm2DljchH2-OEguR08OjgkORI X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.573,FMLib:17.11.176.26 definitions=2023-06-01_06,2023-05-31_03,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 lowpriorityscore=0 impostorscore=0 spamscore=0 malwarescore=0 mlxlogscore=999 priorityscore=1501 phishscore=0 mlxscore=0 clxscore=1011 bulkscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2304280000 definitions=main-2306010093 X-Spam-Status: No, score=-2.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_LOW, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 6/1/2023 2:13 AM, Zhang Hui wrote: > From: zhanghui > > If q->max_entries is not multiple of 32, mask not every bit is 1. > So q->sq_tail_slot some bit will be cleared by use this way. Hi Zhang, Maybe reword the commit message a little bit? Otherwise, it is a good patch. Reviewed-by: Bao D. Nguyen