Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp557687rwd; Thu, 1 Jun 2023 04:00:59 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6xPptezYLaHmjYmSbyS5Gejy+zrYuA/pDxwv2wD59ZSEGnr+QIyxvVWp9KAmp9r0FgZo0G X-Received: by 2002:a05:6808:309d:b0:39a:618b:17e2 with SMTP id bl29-20020a056808309d00b0039a618b17e2mr3081539oib.21.1685617259526; Thu, 01 Jun 2023 04:00:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1685617259; cv=none; d=google.com; s=arc-20160816; b=UrTEH/LHTBtJX1kUmKTqhn8qkB9YDYWR4+pFH++q5OnIapho+VZ3J2uxlOkM4j2XbZ 8X/qsgzoqdxRZMYY4oTS74+9PGw7GOsZsXOpM3MT8tycYyfPV6YPesrqy++nbbYOogtx IMvTkAlm4+zRJO/tAFMjDznLWaieUWBS88XAd2IrH4OXVwVjmBkA/v/zB1zHuDONfNqO Ld83eg3jMKvG5F71fvGh4WQZQsAir8LDnGF3vh8+YVNXy92HVNJggPSxCU6uHzKL+mZ+ cICHkkrULSgRoDwwghPKjakku7nwqiBxz6Qz3OtoBCG4C0UtnP6G36QByEoDlIc9Y7SG 96VA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :organization:references:in-reply-to:message-id:subject:cc:to:from :date; bh=djmFyPD2JDzBgr0B3ATuJWDhy06JS+4Uu42pcB8uaJ0=; b=sfE4Ja3BFIdRUqWsu9Wy1LniroV1Ym7HwGz9BZE/Er7HEXa1WtN3GNJeNUHDA5fK3N 80msuyJTeRriQCbq6wwUyVFVtE0VZ0doPtTSRX2R/fI1R7tzi2rMtXJkL3st2SvbbSaC hfKaA69x6aJiLnPRTRrYpx+KeAkqIdrAVGTbRAcJZyDpM9TmMDdtrB+wSK8QhI6FrQ7d h44EodP8aN7h4/bin+iqCueUs/QxzOrQED1hlZkld8H3J1oU6OqbQQRU0DRNosqMrtvJ zhemoD/dzbFGNnMzMGoOj/XkFY7XtNMoxr4PhD/J/LlFBwFXGlimHYDaxzA0h3QJrCnP 9aJg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id t14-20020aa7946e000000b006434e20d01asi5227092pfq.199.2023.06.01.04.00.45; Thu, 01 Jun 2023 04:00:59 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232840AbjFAKwe (ORCPT + 99 others); Thu, 1 Jun 2023 06:52:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50484 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232146AbjFAKwc (ORCPT ); Thu, 1 Jun 2023 06:52:32 -0400 Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F3C41124; Thu, 1 Jun 2023 03:52:30 -0700 (PDT) Received: from lhrpeml500005.china.huawei.com (unknown [172.18.147.206]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4QX2wC18R9z67nNy; Thu, 1 Jun 2023 18:50:19 +0800 (CST) Received: from localhost (10.202.227.76) by lhrpeml500005.china.huawei.com (7.191.163.240) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Thu, 1 Jun 2023 11:52:28 +0100 Date: Thu, 1 Jun 2023 11:52:27 +0100 From: Jonathan Cameron To: Terry Bowman CC: , , , , , , , , , Subject: Re: [PATCH v4 05/23] cxl/pci: Refactor component register discovery for reuse Message-ID: <20230601115227.000027c7@Huawei.com> In-Reply-To: <20230523232214.55282-6-terry.bowman@amd.com> References: <20230523232214.55282-1-terry.bowman@amd.com> <20230523232214.55282-6-terry.bowman@amd.com> Organization: Huawei Technologies Research and Development (UK) Ltd. X-Mailer: Claws Mail 4.1.0 (GTK 3.24.33; x86_64-w64-mingw32) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.202.227.76] X-ClientProxiedBy: lhrpeml100003.china.huawei.com (7.191.160.210) To lhrpeml500005.china.huawei.com (7.191.163.240) X-CFilter-Loop: Reflected X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 23 May 2023 18:21:56 -0500 Terry Bowman wrote: > The endpoint implements component register setup code. Refactor it for > reuse with RCRB, downstream port, and upstream port setup. > > Move PCI specifics from cxl_setup_regs() into cxl_pci_setup_regs(). > > Move cxl_setup_regs() into cxl/core/regs.c and export it. This also > includes supporting static functions cxl_map_registerblock(), > cxl_unmap_register_block() and cxl_probe_regs(). > > Co-developed-by: Robert Richter > Signed-off-by: Robert Richter > Signed-off-by: Terry Bowman Reviewed-by: Jonathan Cameron