Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <bede29c5-d4e0-7925-dcdc-c724b98d25ca@linaro.org>
Date:   Thu, 1 Jun 2023 12:50:15 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.11.2
Subject: Re: [PATCH] arm64: dts: qcom: sm8550: Add missing interconnect path
 to USB HC
Content-Language: en-US
To:     Abel Vesa <abel.vesa@linaro.org>
Cc:     Andy Gross <agross@kernel.org>,
        Bjorn Andersson <andersson@kernel.org>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Conor Dooley <conor+dt@kernel.org>,
        linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
References: <20230601103817.4066446-1-abel.vesa@linaro.org>
 <34cd6db8-9f05-23cc-cd41-7fd48ec1a286@linaro.org>
 <ZHh3pyQprqKDn+TS@linaro.org>
From:   Konrad Dybcio <konrad.dybcio@linaro.org>
In-Reply-To: <ZHh3pyQprqKDn+TS@linaro.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 1.06.2023 12:49, Abel Vesa wrote:
> On 23-06-01 12:42:22, Konrad Dybcio wrote:
>>
>>
>> On 1.06.2023 12:38, Abel Vesa wrote:
>>> The USB HC node is missing the interconnect paths, so add them.
>>>
>>> Fixes: 7f7e5c1b037f ("arm64: dts: qcom: sm8550: Add USB PHYs and controller nodes")
>> For context, it's a fix in the context of "we should prooobably have
>> this if we want to fix the icc driver to include sync state".
> 
> Fair enough...
> 
>>> Signed-off-by: Abel Vesa <abel.vesa@linaro.org>
>>> ---
>> Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
>>
>>
>>
>> sidenote:
>>
>> on recent SoCs there's also an USB-IPA path:
>>
>> aggre1_noc MASTER_USB3_0 <-> &config_noc SLAVE_IPA_CFG
> 
> AFAIK, support for IPA on SM8550 is not added yet.
> 
> We can worry about this 3rd path when IPA support for this platform is
> upstreamed.
Right, that's what I'm saying. I'm not even sure we have tethering
acceleration upstream (where IPA pushes data quickly for sharing mobile
data via USB).

Konrad
> 
>>
>> I don't think we really make use of that upstream today or whether it
>> would make enabling IPA necessary (to enable the clocks and reach the
>> IPA hardware), but it's something to think about.
>>
>> Konrad
>>>  arch/arm64/boot/dts/qcom/sm8550.dtsi | 4 ++++
>>>  1 file changed, 4 insertions(+)
>>>
>>> diff --git a/arch/arm64/boot/dts/qcom/sm8550.dtsi b/arch/arm64/boot/dts/qcom/sm8550.dtsi
>>> index 75cd374943eb..4991b2e962d1 100644
>>> --- a/arch/arm64/boot/dts/qcom/sm8550.dtsi
>>> +++ b/arch/arm64/boot/dts/qcom/sm8550.dtsi
>>> @@ -2793,6 +2793,10 @@ usb_1: usb@a6f8800 {
>>>  
>>>  			resets = <&gcc GCC_USB30_PRIM_BCR>;
>>>  
>>> +			interconnects = <&aggre1_noc MASTER_USB3_0 0 &mc_virt SLAVE_EBI1 0>,
>>> +					<&gem_noc MASTER_APPSS_PROC 0 &config_noc SLAVE_USB3_0 0>;
>>> +			interconnect-names = "usb-ddr", "apps-usb";
>>> +
>>>  			status = "disabled";
>>>  
>>>  			usb_1_dwc3: usb@a600000 {