Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp612292rwd; Thu, 1 Jun 2023 04:39:18 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4cNRoBEKfMggXTsUqClJapxJNb71cEqqZ1yFzUe0dbqcobk4Tp8qTyxwafoOhSZh+5MlWS X-Received: by 2002:a05:6a20:7346:b0:10c:d3e5:1953 with SMTP id v6-20020a056a20734600b0010cd3e51953mr7408238pzc.3.1685619558270; Thu, 01 Jun 2023 04:39:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1685619558; cv=none; d=google.com; s=arc-20160816; b=YLCzp/YB6h+x4wZJEMnKvmHMPejCyC4P5GbE0so1aWmW9rRBh7zRamSDkcgQM6HLeL hK8TzVwYEW3QtaIbXaxMvpB16CZFdXBQGn87rzsZuEmgH58FGY3/mO4LJ5jcM26ZtxM8 0V3YSXU1UmJ5MS/ZpHSt44NuetEKEJljISFFONgTO8JsnwpKUGLHAXIW24tP3e0UYBuP jk4PnAU7sGXRmiS7jOlo62odcd17ma1xwpX6xxJBAeDJeBLLcUTZyPnK/21QKbh+KqCc KnVoEYSVAYZrZ1vKXIEmGC5Cv9MASuzwo6AQh3JnwovdzNT7L4E1uBD2NpoKFw/Ba2II PmWw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=8vMskHhtUuRlMIt2Ncz0GeUAC2vyDx9pgosUjZg/dMk=; b=HKqcJqCr+aLu3vGBuNlJbb59rnKJDXr4jzr91/HaOvpoaNTfclih70nDVizLA6JZ0p p1JComn0aAsEm500Fs5mGHAeIfjRI7K5nPUzu9S3zKQffkwX8jSQ9uMGgpfLpEpp9ptu UJmuBU/yDwy5QcfWkDsC05qZ1ZLQO6zD8mk37knlHTdjg/M7FQ7KNJyDp9KRW6p6ne4Y xBp47804O3JUt9thqVtjIngRm6R9P5VSmWJVL61nZOAURU0tqpt4g3NCFrDNLU38DPPd qrHt2JSPPRQwDnJLbgHq1QKhcsahbEVEeEqQSDjONM5/6bWSgWcD4QlG9cbr+YqiByQ1 e4jw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=EE58CAOm; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id x18-20020a63b212000000b0053eef60f940si2716701pge.765.2023.06.01.04.39.04; Thu, 01 Jun 2023 04:39:18 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=EE58CAOm; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231737AbjFALNX (ORCPT + 99 others); Thu, 1 Jun 2023 07:13:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33284 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230222AbjFALNW (ORCPT ); Thu, 1 Jun 2023 07:13:22 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1D48111F; Thu, 1 Jun 2023 04:13:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=8vMskHhtUuRlMIt2Ncz0GeUAC2vyDx9pgosUjZg/dMk=; b=EE58CAOmZjgyHlXe6PwbCLYrPE +9I426e7goRJX287noW4a2DkzzDotI4J1/O5HyeG2E1WS+RJr5xIOL6vqV3cmn4C7XUe8D336Zt3U Ar4YX+z/WnxLDQHHzLpm3dcbeOkXEqBp2frmsTcmCU9Xr7l7GI6n+O4I0hZpoqr6COQA9VBmVdGvG yc2+LWklZABDo76ncn4l6Jxjqy1VUa51l+ztFaYrTUyTtDXwbQpUf4wrmjbbBlmafhds2u0X91rMg oR7WhMsQV9Cn4Ds8RF42U18nYrB+7sHNghT1E2nmQjY9wU0uCs1Jl1Tzap2NBht27gmwWlJxvpA88 a7euVC5A==; Received: from hch by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1q4gF3-003CdT-0T; Thu, 01 Jun 2023 11:13:17 +0000 Date: Thu, 1 Jun 2023 04:13:17 -0700 From: Christoph Hellwig To: Baoquan He Cc: Christoph Hellwig , linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, arnd@arndb.de, christophe.leroy@csgroup.eu, agordeev@linux.ibm.com, wangkefeng.wang@huawei.com, schnelle@linux.ibm.com, David.Laight@aculab.com, shorne@gmail.com, willy@infradead.org, deller@gmx.de Subject: Re: [PATCH v5 RESEND 14/17] mm/ioremap: Consider IOREMAP space in generic ioremap Message-ID: References: <20230515090848.833045-1-bhe@redhat.com> <20230515090848.833045-15-bhe@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 30, 2023 at 05:37:23PM +0800, Baoquan He wrote: > If we want to consolidate code, we can move is_ioremap_addr() to > include/linux/mm.h libe below. Not sure if it's fine. With it, > both kernel/iomem.c and mm/ioremap.c can use is_ioremap_addr(). Can we just add a ne header for this given that no one else really needs it?