Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <4aee3a8f-66ff-387b-73a1-31fc16eb7ffc@ti.com>
Date:   Thu, 1 Jun 2023 17:18:56 +0530
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.11.0
Subject: Re: [PATCH] arm64: dts: ti: k3-j784s4: Fix wakeup pinmux range and
 pinctrl node offsets
From:   Thejasvi Konduru <t-konduru@ti.com>
To:     Nishanth Menon <nm@ti.com>
CC:     Tero Kristo <kristo@kernel.org>, Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        <linux-arm-kernel@lists.infradead.org>,
        <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        Andrew Davis <afd@ti.com>,
        Vignesh Raghavendra <vigneshr@ti.com>,
        Apurva Nandan <a-nandan@ti.com>, Udit Kumar <u-kumar1@ti.com>
References: <20230503083143.32369-1-t-konduru@ti.com>
 <20230503114625.gqnijd3bog5bwemz@parameter>
 <31b31af7-6c54-7d05-f7ef-fcceba48580e@ti.com>
 <20230504115207.h6trzy4mqjcbkcm3@comment>
 <67eccecb-f4a4-7f15-5316-27fd39e65b51@ti.com>
 <20230504142239.hqhni2c52k3a3asz@prune>
 <efab17de-aeb4-9fdb-6c97-ab2f2bc8c8f4@ti.com>
Content-Language: en-US
In-Reply-To: <efab17de-aeb4-9fdb-6c97-ab2f2bc8c8f4@ti.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 09/05/23 15:19, Thejasvi Konduru wrote:
>
> On 04/05/23 19:52, Nishanth Menon wrote:
>> On 17:40-20230504, Thejasvi Konduru wrote:
>>> On 04/05/23 17:22, Nishanth Menon wrote:
>>>> On 14:36-20230504, Thejasvi Konduru wrote:
>>>>> On 03/05/23 17:16, Nishanth Menon wrote:
>>>>>> On 14:01-20230503, Thejasvi Konduru wrote:
>>>>>>> The wkup_pmx register region in j784s4 has multiple non-addressable
>>>>>>> regions, hence the existing wkup_pmx region is split as follows to
>>>>>>> avoid the non-addressable regions. The pinctrl node offsets are
>>>>>>> also corrected as per the newly split wkup_pmx* nodes.
>>>>>>>
>>>>>>> wkup_pmx0 -> 13 pins (WKUP_PADCONFIG 0 - 12)
>>>>>>> wkup_pmx1 -> 11 pins (WKUP_PADCONFIG 14 - 24)
>>>>>>> wkup_pmx2 -> 72 pins (WKUP_PADCONFIG 26 - 97)
>>>>>>> wkup_pmx3 -> 1 pin (WKUP_PADCONFIG 100)
>>>>>>>
>>>>>>> Fixes: 4664ebd8346a ("arm64: dts: ti: Add initial support for 
>>>>>>> J784S4 SoC")
>>>>>>> Signed-off-by: Thejasvi Konduru <t-konduru@ti.com>
>>>>>>> ---
>>>>>> Could you provide a link to the output of:
>>>>>> $ cat /sys/kernel/debug/pinctrl/*/pins
>>>>> https://gist.github.com/thejasvikonduru/05b1a8e0fd8176116b7a3cc4e43b244a 
>>>>>
>>>> Was this failing prior to this patch? Trying to understand the "Fix"
>>>> aspect of this patch.
>>>>
>>> Yes,it was failing prior to this patch.
>>>
>> next time some asks this question - give summary AND give a log. Even
>> better, please don't make folks even ask the question in the first
>> place by including the logs in the diffstat of the patch.
>>
>> Please share the log to understand what kind of "failure" was occurring.
>
> Link to logs:
> Before Fix: 
> https://gist.github.com/thejasvikonduru/e217edf4839c348793a5671aa9331595
> After Fix : 
> https://gist.github.com/thejasvikonduru/05b1a8e0fd8176116b7a3cc4e43b244a
>
Are these logs fine and can we go forward with this patch?