Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp753115rwd; Thu, 1 Jun 2023 06:14:01 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6pj6xE6j/5eYDA6HP22mgnvr9lKLrZ6eeHYas0v1pAjWGG5KJcJRDMFzvl6KwYyLqcTt98 X-Received: by 2002:a17:902:8503:b0:1aa:ff41:31a7 with SMTP id bj3-20020a170902850300b001aaff4131a7mr5781614plb.13.1685625241068; Thu, 01 Jun 2023 06:14:01 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1685625241; cv=none; d=google.com; s=arc-20160816; b=EiI/wxQnZ/giWDslEyuqG8R/WpgNOExUvp/4G7TJoi/ghMP5wLERjgARhTsFjAniJf 5bRPeoi6bp9IiqINsKlWGPdlVf+oVjc4JgHPj39S91/mtaLWTTh4Hr6ZiF4qzXKyznqb mAG41hFenpdnpQFe0PbbfytUCWD7gKKUeNsKudCQg8URw5JrJaw3CUzZzmV4vudKUTu9 xNt4zvhnY3olOchcj6H5M5K417kYme7B5+r+ewoEReQaWxd6l34H4SPokVNpYEqcm+n5 hrpggEBZGMaesYQe8QGk4HQYn+WWHcUdm39yWkw37q16F3Jo3TXpJyaVm1mkDXnDsQn6 wXTQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :organization:references:in-reply-to:message-id:subject:cc:to:from :date; bh=O43DCHBA7BBFtGJdXgfXQ5PvdM0D9s4JSFZn1h5etEc=; b=Zh5uoXJ4rDPvZdjJ/3pOhBw4gfows3gMOikVtyekW5sWzDZrn69pjutbTrZhl5E+oz 2uDe1xwf1AuacEfjM/5fqOqS7kOPpNfSZ1e3yNcnjzxdFX62Ib86Qga4ju7LbLBA6Wim TA7BwVbQTbEOELns4HBqEO6FRTKSgf992/gw69QkrG2Q6Q1+DqoLxsnhIK46pmU3XqNK LWvf5r3O4koEfiTEZoP5H5RCcS8JdK6wgRPftbiPXQLCt5E503yDgOiFw3f91xkVCo5j GIbeXBmRE9SOQx0Wtn1LfEb+ZRC/ibPRlRt2/SUty90AbkKBYSUKXTpkYMC/lx8fS2a8 GQFQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id u4-20020a170902b28400b001b02d0941dfsi2673445plr.354.2023.06.01.06.13.47; Thu, 01 Jun 2023 06:14:01 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233206AbjFAMto (ORCPT + 99 others); Thu, 1 Jun 2023 08:49:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44202 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233209AbjFAMtn (ORCPT ); Thu, 1 Jun 2023 08:49:43 -0400 Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2DB93124; Thu, 1 Jun 2023 05:49:40 -0700 (PDT) Received: from lhrpeml500005.china.huawei.com (unknown [172.18.147.226]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4QX5Ws6rXLz67g6l; Thu, 1 Jun 2023 20:47:53 +0800 (CST) Received: from localhost (10.202.227.76) by lhrpeml500005.china.huawei.com (7.191.163.240) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Thu, 1 Jun 2023 13:49:37 +0100 Date: Thu, 1 Jun 2023 13:49:37 +0100 From: Jonathan Cameron To: Terry Bowman CC: , , , , , , , , , Subject: Re: [PATCH v4 08/23] cxl/regs: Remove early capability checks in Component Register setup Message-ID: <20230601134937.00005bf8@Huawei.com> In-Reply-To: <20230523232214.55282-9-terry.bowman@amd.com> References: <20230523232214.55282-1-terry.bowman@amd.com> <20230523232214.55282-9-terry.bowman@amd.com> Organization: Huawei Technologies Research and Development (UK) Ltd. X-Mailer: Claws Mail 4.1.0 (GTK 3.24.33; x86_64-w64-mingw32) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.202.227.76] X-ClientProxiedBy: lhrpeml100002.china.huawei.com (7.191.160.241) To lhrpeml500005.china.huawei.com (7.191.163.240) X-CFilter-Loop: Reflected X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 23 May 2023 18:21:59 -0500 Terry Bowman wrote: > From: Robert Richter > > When probing the Component Registers in function cxl_probe_regs() > there are also checks for the existence of the HDM and RAS > capabilities. The checks may fail for components that do not implement > the HDM capability causing the Component Registers setup to fail too. > > Remove the checks for a generalized use of cxl_probe_regs() and check > them directly before mapping the RAS or HDM capabilities. This allows > it to setup other Component Registers esp. of an RCH Downstream Port, > which will be implemented in a follow-on patch. > > Signed-off-by: Robert Richter > Signed-off-by: Terry Bowman Reviewed-by: Jonathan Cameron