Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <33979417-2c0c-5474-23e0-7e72add99873@linaro.org>
Date:   Thu, 1 Jun 2023 15:27:22 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.11.0
Subject: Re: [PATCH V7 4/8] pinctrl: qcom: Add IPQ5018 pinctrl driver
From:   Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To:     Sricharan Ramabadhran <quic_srichara@quicinc.com>,
        andy.shevchenko@gmail.com
Cc:     agross@kernel.org, andersson@kernel.org, konrad.dybcio@linaro.org,
        robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
        mturquette@baylibre.com, sboyd@kernel.org, ulf.hansson@linaro.org,
        linus.walleij@linaro.org, catalin.marinas@arm.com, will@kernel.org,
        p.zabel@pengutronix.de, linux-arm-msm@vger.kernel.org,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-mmc@vger.kernel.org, linux-gpio@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org, robimarko@gmail.com
References: <20230519125409.497439-1-quic_srichara@quicinc.com>
 <20230519125409.497439-5-quic_srichara@quicinc.com>
 <CAHp75VfVx+oGYKcija3h9-eWc6jggMx8p5SAQTEHTBEbjTaJKw@mail.gmail.com>
 <1823419a-6bb4-03f7-d5ae-e32204c5e598@quicinc.com>
 <ZHTK7uEzO7kcx_cV@surfacebook>
 <aefd0df1-8dfb-1b69-589b-974dea312845@quicinc.com>
 <664940c3-9ec1-b4bd-9db5-fa3529e3d1ff@linaro.org>
 <8146f367-c539-bea5-12b6-424213018488@quicinc.com>
 <eb109116-94eb-5b6d-0049-7bb31feada36@linaro.org>
Content-Language: en-US
In-Reply-To: <eb109116-94eb-5b6d-0049-7bb31feada36@linaro.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 01/06/2023 13:53, Krzysztof Kozlowski wrote:
> On 01/06/2023 13:41, Sricharan Ramabadhran wrote:
>>
>>
>> On 6/1/2023 3:21 PM, Krzysztof Kozlowski wrote:
>>> On 01/06/2023 11:50, Sricharan Ramabadhran wrote:
>>>>
>>>>
>>>> On 5/29/2023 9:25 PM, andy.shevchenko@gmail.com wrote:
>>>>> Mon, May 29, 2023 at 03:58:09PM +0530, Sricharan Ramabadhran kirjoitti:
>>>>>> On 5/20/2023 12:17 AM, Andy Shevchenko wrote:
>>>>>>> On Fri, May 19, 2023 at 3:55 PM Sricharan Ramabadhran
>>>>>>> <quic_srichara@quicinc.com> wrote:
>>>>>
>>>>> ...
>>>>>
>>>>>>>      depends on OF || COMPILE_TEST
>>>>>>
>>>>>>    Yeah sure. COMPILE_TEST could be standalone. Will fix it and repost.
>>>>>
>>>>> Standalone COMPILE_TEST will give you definitely NOT what you want.
>>>>> And actually it's strange to have it standalone.
>>>>>
>>>>
>>>>    Ho ok, i meant like this, "depends on ARM64 || COMPILE_TEST"
>>>
>>> Don't do it differently than all other drivers. Open the Kconfig and
>>> look at existing entries.
>>>
>>    The latest added has this below, will use this
>>
>> 	depends on OF || COMPILE_TEST
> 
> I would even drop this... Lemme check, it looks odd. We depend on
> ARCH_QCOM which uses OF. We have few drivers which depend on ACPI, but
> that also seems wrong. These are platform drivers so they should expect
> platform select proper firmware interface. I think none of other
> platform drivers do like this (neither Samsung pinctrl nor other
> Qualcomm drivers)).
> 
> I will fix this. For your patch I would just skip OF entirely.

Correction: you need OF :(

Best regards,
Krzysztof