Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Wang, Wei W" <wei.w.wang@intel.com>
To:     "Yamahata, Isaku" <isaku.yamahata@intel.com>,
        "kvm@vger.kernel.org" <kvm@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
CC:     "Yamahata, Isaku" <isaku.yamahata@intel.com>,
        "isaku.yamahata@gmail.com" <isaku.yamahata@gmail.com>,
        Paolo Bonzini <pbonzini@redhat.com>,
        "Aktas, Erdem" <erdemaktas@google.com>,
        "Christopherson,, Sean" <seanjc@google.com>,
        "Shahar, Sagi" <sagis@google.com>,
        David Matlack <dmatlack@google.com>,
        "Huang, Kai" <kai.huang@intel.com>,
        Zhi Wang <zhi.wang.linux@gmail.com>,
        "Chen, Bo2" <chen.bo@intel.com>,
        Sean Christopherson <sean.j.christopherson@intel.com>
Subject: RE: [PATCH v14 011/113] KVM: TDX: Add C wrapper functions for
 SEAMCALLs to the TDX module
Thread-Topic: [PATCH v14 011/113] KVM: TDX: Add C wrapper functions for
 SEAMCALLs to the TDX module
Thread-Index: AQHZkeUO9CJK5Ein70KPqCCkDQrVv691oygw
Date:   Thu, 1 Jun 2023 13:24:35 +0000
Message-ID: <DS0PR11MB63736AAA616C74E5F8316B1ADC499@DS0PR11MB6373.namprd11.prod.outlook.com>
References: <cover.1685333727.git.isaku.yamahata@intel.com>
 <37b118268ccf73d8e9cc1ef8f9fb7376fb732d60.1685333727.git.isaku.yamahata@intel.com>
In-Reply-To: <37b118268ccf73d8e9cc1ef8f9fb7376fb732d60.1685333727.git.isaku.yamahata@intel.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?4Z9bi8xmmWXeai2X9wvtD9KKpp54Ad6UItMcxHSAA0PxJrImpt057nVp4Tnp?=
 =?us-ascii?Q?c0Nu56mqpC5UaHPvhk5/dSlIaqrgpIEw74Bhe+CFSzlgJb1yH92t1O10y88r?=
 =?us-ascii?Q?TxZZGeSKdZsmr9FZXVQQMU05IkOgfgFQfX6N1NBtWUDSjiJ8amFI0axyXwJF?=
 =?us-ascii?Q?7w9BlPTQYR92xk/Dr/jGnPgpv4glNhvLJ9BDF+8k8rHhOZZqTA+Zn4D7mBNC?=
 =?us-ascii?Q?Dg2JxTqiqDi+U0VWhr631rQJccEp9rRPozzMzRHuhOHeR1z1PtT5aWrJGSxg?=
 =?us-ascii?Q?W1eYzOVWvdNv6ip6EGTPxKm9bBqZsFgSCiRQobQWyRVEKneGGzH34ZAVfbub?=
 =?us-ascii?Q?B5Ln/51zVZc6+H+67V0D3Q9x3AUIfzg8jsKho3qHDYMSjrkDAEeXVuEvx9LC?=
 =?us-ascii?Q?Q2k7BQF+SwKySGvIX7EoUEtP5JPbth7tOf72ZLD0+85+udRUGEP27+MMyyW2?=
 =?us-ascii?Q?0ehwxULe0CQzM1M2jlx8n7YPMvibCEPusKPIC3+9fxOH6CRLBWjKaEbkeJms?=
 =?us-ascii?Q?UrQucL2ABYAsFPDhPRRtQUk19HQiey9oCcSY6/RZeYAm2K4JAs7TpOlcBquC?=
 =?us-ascii?Q?d/AvVbpfv7n6/LubIf6DrT0ZcHUBeVTBBP2VY8Rn/oMbahRJ8p41XIQSQQgD?=
 =?us-ascii?Q?56I3b/Q+96VFQKxLVYyz16U909r8pOS8s9xlJk7fXFSzPY5cprCO4OktgmEj?=
 =?us-ascii?Q?+jRBHJ+lQCc21TttK/2tiGOztsNrZlyd+Z4t6EHmVDcP2KeHm0OCoX/bNd2t?=
 =?us-ascii?Q?QY9pkHPBOkYj6eeG/7eNF8HHndBkD2grSi7jxJ0h0wKX/ipgW2Ul7RforBAV?=
 =?us-ascii?Q?9EZCFYvmgavM9sWqbebmEJeabkhh6s0QJIYtT4tuuQJO34/CXJ56KO4OxuNL?=
 =?us-ascii?Q?RO13akFB2iCCJJjcgwVIXnZf5t5jHfjyvSvPU6wcLtGSykjUCNsHTUGh8WSr?=
 =?us-ascii?Q?QyL77BN0fYVOHf6HqHsVKMlyardpgrNoBV0a9jCWQnaqe58do82AIEDVm7At?=
 =?us-ascii?Q?NshbeMQdBrpbCy9fZocgOW49B5aXesSjeod3xP3vQiOXPcts52iwuGq6ITkU?=
 =?us-ascii?Q?9GeUH+xI03CTHOSmSD+4N4CPQRXiZIS0/EjuC3MxgF84/qR1HHxSNCOkB3C9?=
 =?us-ascii?Q?H/JsjNI5zzdA0j5WKzJeQu01o7/ePdeBBQ90xGlvgg1hUiQD2vk/MMUfoDYg?=
 =?us-ascii?Q?GOgJVoiQdjyUAlsrHZ1/V8mNRctgC7bcbcMaX7/nWlpXfPAOdm8lb7AJ1dYy?=
 =?us-ascii?Q?0l9nkSsllvdx1lpCvfqZUrtXpsEIg1K0m33QETpl5+AbyYzhQV5bF+XCsZ6g?=
 =?us-ascii?Q?OlcMF99EgTkOZ9LUPDQi3uDext4CJzimG9PIL9ao50nlTFMJgLqZt9nqAuHb?=
 =?us-ascii?Q?PgdEsGFIxf6yEORYnoXePywZWHdY7YWaPFppe5iJv2Ba73DMvlPWtVzNeKgi?=
 =?us-ascii?Q?m/c452clIyk7nk0UAIoZ/HXRzBJowjLaHcYT/Ut4t7VA07SQXx1Q3ZlKOphe?=
 =?us-ascii?Q?YxGM1am8AlOcxZYDm/aydLQbw1ADS7nmtIKLze8ka5pryn1zaPOUBktwWcbd?=
 =?us-ascii?Q?xaSQwvw/7STlJhvkM1F0mBSvKdSjdTtLXlHvdEbZ?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB6373.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 54640215-4562-47c3-079a-08db62a38b50
X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Jun 2023 13:24:35.9445
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: ywoZ3BONelMj7SgaR6woGc/S5BKGRjR96G+xlgQqc9sS1mRENY3K42niIe2AKB7e2SmUbtIbljJzQPSRA2sq6g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR11MB4780
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Monday, May 29, 2023 12:19 PM, isaku.yamahata@intel.com wrote:
> From: Isaku Yamahata <isaku.yamahata@intel.com>
>=20
> A VMM interacts with the TDX module using a new instruction (SEAMCALL).
> For instance, a TDX VMM does not have full access to the VM control
> structure corresponding to VMX VMCS.  Instead, a VMM induces the TDX
> module to act on behalf via SEAMCALLs.
>=20
> Export __seamcall and define C wrapper functions for SEAMCALLs for
> readability.
>=20
> Some SEAMCALL APIs donate host pages to TDX module or guest TD, and the
> donated pages are encrypted.  Such SEAMCALLs flush cache lines (typically=
 by
> movdir64b instruction), but some don't.  Those that don't clear cache lin=
es
> require the VMM to flush the cache lines to avoid cache line alias.
>=20
> Signed-off-by: Sean Christopherson <sean.j.christopherson@intel.com>
> Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>
> ---
>  arch/x86/include/asm/tdx.h       |   4 +
>  arch/x86/kvm/vmx/tdx_ops.h       | 202
> +++++++++++++++++++++++++++++++
>  arch/x86/virt/vmx/tdx/seamcall.S |   2 +
>  arch/x86/virt/vmx/tdx/tdx.h      |   3 -
>  4 files changed, 208 insertions(+), 3 deletions(-)  create mode 100644
> arch/x86/kvm/vmx/tdx_ops.h
>=20
> diff --git a/arch/x86/include/asm/tdx.h b/arch/x86/include/asm/tdx.h inde=
x
> 112a5b9bd5cd..6c01ab572c1f 100644
> --- a/arch/x86/include/asm/tdx.h
> +++ b/arch/x86/include/asm/tdx.h
> @@ -104,10 +104,14 @@ static inline long tdx_kvm_hypercall(unsigned int
> nr, unsigned long p1,  bool platform_tdx_enabled(void);  int
> tdx_cpu_enable(void);  int tdx_enable(void);
> +u64 __seamcall(u64 op, u64 rcx, u64 rdx, u64 r8, u64 r9,
> +	       struct tdx_module_output *out);
>  #else	/* !CONFIG_INTEL_TDX_HOST */
>  static inline bool platform_tdx_enabled(void) { return false; }  static =
inline int
> tdx_cpu_enable(void) { return -EINVAL; }  static inline int tdx_enable(vo=
id)
> { return -EINVAL; }
> +static inline u64 __seamcall(u64 op, u64 rcx, u64 rdx, u64 r8, u64 r9,
> +			     struct tdx_module_output *out) { return
> TDX_SEAMCALL_UD; };
>  #endif	/* CONFIG_INTEL_TDX_HOST */
>=20
>  #endif /* !__ASSEMBLY__ */
> diff --git a/arch/x86/kvm/vmx/tdx_ops.h b/arch/x86/kvm/vmx/tdx_ops.h
> new file mode 100644 index 000000000000..893cc6c25f3b
> --- /dev/null
> +++ b/arch/x86/kvm/vmx/tdx_ops.h
> @@ -0,0 +1,202 @@
> +/* SPDX-License-Identifier: GPL-2.0 */
> +/* constants/data definitions for TDX SEAMCALLs */
> +
> +#ifndef __KVM_X86_TDX_OPS_H
> +#define __KVM_X86_TDX_OPS_H
> +
> +#include <linux/compiler.h>
> +
> +#include <asm/cacheflush.h>
> +#include <asm/asm.h>
> +#include <asm/kvm_host.h>
> +
> +#include "tdx_errno.h"
> +#include "tdx_arch.h"
> +#include "x86.h"
> +
> +static inline u64 kvm_seamcall(u64 op, u64 rcx, u64 rdx, u64 r8, u64 r9,
> +			       struct tdx_module_output *out) {

As discussed somewhere before, kvm_* is more common to be labelled for the
generic code. Would it be better to be named tdx_seamcall here?