Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <1a14013cc3e205265e4564094d4faf971b651810.camel@redhat.com>
Subject: Re: [PATCH net] net: dsa: mv88e6xxx: Increase wait after reset
 deactivation
From:   Paolo Abeni <pabeni@redhat.com>
To:     Andrew Lunn <andrew@lunn.ch>,
        Andreas Svensson <andreas.svensson@axis.com>
Cc:     Florian Fainelli <f.fainelli@gmail.com>,
        Vladimir Oltean <olteanv@gmail.com>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>, kernel@axis.com,
        Baruch Siach <baruch@tkos.co.il>, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Date:   Thu, 01 Jun 2023 15:42:06 +0200
In-Reply-To: <133860f9-e745-44ce-9b74-c5d990cf92db@lunn.ch>
References: <20230530145223.1223993-1-andreas.svensson@axis.com>
         <be44dfe3-b4cb-4fd5-b4bd-23eec4bd401c@lunn.ch>
         <f89e203a-af77-9661-1003-0e9370ff6fab@axis.com>
         <133860f9-e745-44ce-9b74-c5d990cf92db@lunn.ch>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.46.4 (3.46.4-1.fc37) 
MIME-Version: 1.0
Precedence: bulk

On Thu, 2023-06-01 at 14:01 +0200, Andrew Lunn wrote:
>  On Thu, Jun 01, 2023 at 11:10:58AM +0200, Andreas Svensson wrote:
> > On 5/30/23 19:28, Andrew Lunn wrote:
> > > On Tue, May 30, 2023 at 04:52:23PM +0200, Andreas Svensson wrote:
> > > > A switch held in reset by default needs to wait longer until we can
> > > > reliably detect it.
> > > >=20
> > > > An issue was observed when testing on the Marvell 88E6393X (Link St=
reet).
> > > > The driver failed to detect the switch on some upstarts. Increasing=
 the
> > > > wait time after reset deactivation solves this issue.
> > > >=20
> > > > The updated wait time is now also the same as the wait time in the
> > > > mv88e6xxx_hardware_reset function.
> > >=20
> > > Do you have an EEPROM attached and content in it?
> >=20
> > There's no EEPROM attached to the switch in our design.
> >=20
> > >=20
> > > It is not necessarily the reset itself which is the problem, but how
> > > long it takes after the reset to read the contents of the
> > > EEPROM. While it is doing that, is does not respond on the MDIO
> > > bus. Which is why mv88e6xxx_hardware_reset() polls for that to
> > > complete.
> >=20
> > Ok, yes that makes sense. I could add the mv88e6xxx_g1_wait_eeprom_done
> > function after the reset deactivation.
>=20
> I don't think that works, because how to talk to the switch is not
> determined until after the switch has been detected.
>=20
> > The datasheet for 88E6393X also states that it needs at least 10ms
> > before it's ready. But I suppose this varies from switch to switch.
>=20
> O.K, let go with this change and see if anybody really complains. We
> can always add a DT property later.
>=20
> Reviewed-by: Andrew Lunn <andrew@lunn.ch>
>=20
> You probably need to repost with my Reviewed-by added, now that Paolo
> has changed the status of the patch.

Not needed. I can restore the patch in PW.

Thanks,

Paolo