Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Wang, Wei W" <wei.w.wang@intel.com>
To:     "Christopherson,, Sean" <seanjc@google.com>
CC:     "dmatlack@google.com" <dmatlack@google.com>,
        "mizhang@google.com" <mizhang@google.com>,
        "isaku.yamahata@gmail.com" <isaku.yamahata@gmail.com>,
        "pbonzini@redhat.com" <pbonzini@redhat.com>,
        "kvm@vger.kernel.org" <kvm@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v2] KVM: allow KVM_BUG/KVM_BUG_ON to handle 64-bit cond
Thread-Topic: [PATCH v2] KVM: allow KVM_BUG/KVM_BUG_ON to handle 64-bit cond
Thread-Index: AQHZUPwYxSWFJqdvM0K0D4p/iJpYU67xiL+AgISXfTA=
Date:   Thu, 1 Jun 2023 13:30:29 +0000
Message-ID: <DS0PR11MB6373F567D22270CA3CE86696DC499@DS0PR11MB6373.namprd11.prod.outlook.com>
References: <20230307135233.54684-1-wei.w.wang@intel.com>
 <ZAkZjzQ8pJQXQhJR@google.com>
In-Reply-To: <ZAkZjzQ8pJQXQhJR@google.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?23mOP5CtrDs/lUERyvAA/4lTV4AuhCuKXxYmZYRg0KcHYfqQu8BT5JL8zj3k?=
 =?us-ascii?Q?OgxGaXBIJ5CUNjNrwl0UpFgl/Ra9apA8fOIcMxcT9kkkyFqBaQCaC5aKFxfn?=
 =?us-ascii?Q?CPp80/jwCOdhmKJlLUmrtCn7niY7EY4K4uQU/3Pp6mPIR4QT83cbEjs3iVXf?=
 =?us-ascii?Q?EAKwkPm7cIoPerGl/wuczfcji1ZFOVY8bX7zjlZzUzLdpxV55wRLcinH7ZVi?=
 =?us-ascii?Q?CCimnumIw6OXLgYVWZi+FH0TClRNWrWSAoMJi/uIuliH1rBtSCUed2mOXG8t?=
 =?us-ascii?Q?wMfRFRhP2KIAD+dBM8J+UuaMDfwLM5E7mHrcLNrBEQuiKMqOapjYxa1f7ilV?=
 =?us-ascii?Q?XV31etnEMri9HtBIXs8o+FQTtD5LQwSbydf2ouT4FsvBts0Lsn1HEeYZFLBF?=
 =?us-ascii?Q?GrT3ZkngfsyLrwstzm2P61c6yGF3fsjxNveq50Ylkk541OY2VM2F+UjuXMG5?=
 =?us-ascii?Q?xiBm4GCWHrExW/jKBs20jdITW0+mDC51GYTInIo1JxAT9Aq4lF0q6yePoH05?=
 =?us-ascii?Q?UU66pY3FSK0iZjA76DyZNIgLWhO7y2bwyAcoPU9gF/d2Xl4henY3gzglrmhF?=
 =?us-ascii?Q?zUTOQp36HgoAqzPZ9EbU/9jHT8iPsCRX4KAEMqh2iYP6Sh2kRBlPOdjdtT9c?=
 =?us-ascii?Q?o45mkyDZL/nuBIH3ccbWCmPNzwPg4DZrzm6av3iotQHlNdBsf6sgccbqixZS?=
 =?us-ascii?Q?5EZ7bjm6zFPasYl8TGN0S8M7H8F/VLXmf3q24E4oWNfMfIFaCEYbuJY0B2nq?=
 =?us-ascii?Q?Gu4JgLFZ4tE9XpdAaOy1kZX0kQ2nxffEyD6GLq1cYbROf/qtQSoZa8sDy19o?=
 =?us-ascii?Q?byaOb0yav4sVSTXYiavBQ9/KHj6MmbaR4vKW9V21BQy4PZ2u2N/GcRYdyiPE?=
 =?us-ascii?Q?kKE7FaeuT2MhPW+h3WSDFNsHOGWbg+MkOuPC5ORXsRixPLdSAgrCnIlL+GyU?=
 =?us-ascii?Q?KBF0iJMimS2Mx/MTXxMJJ6UkmDDurbU1vV6/PgOCWiPra/y6ZBV3bZiq1QT1?=
 =?us-ascii?Q?LY3ur8DOVqOLuwrkDVx0GVcr67qT59JpiOGfyweW0P+MZ5Hniy8TsDIUN81V?=
 =?us-ascii?Q?peWqCzCEJHJWCD7GY5MU28B1H0iCF/NTTkaUZfk/OUX3GTpccUjsceL8Izvi?=
 =?us-ascii?Q?/QWs9iZstGDPq9nTC6VpRO7ECWOQpjmr1Mxy8gNeFjfZDzrGDX6NDzZKokYn?=
 =?us-ascii?Q?SyEBnKBbtt+Tn5ElfANnpevCJ+za4W0vPOGai0xMO8oLVGdAOjG6vfkUH/FW?=
 =?us-ascii?Q?On355w/M8GLRKMWSUz8Nr1Sklojbt0IE2Hq5HgzL3aAhoYIGUBjXZboSDeKe?=
 =?us-ascii?Q?eMzQE8aQMwzKPIRLNSkrJN+n6J3HmplObjp9hcnDV+Dhlc1CT9JTo5eaVGKN?=
 =?us-ascii?Q?NeXTOStuE6FevwY8E4lnkZJu61+jEHB699PU208zEw57GjX4iwx5rUuwDIqw?=
 =?us-ascii?Q?uHssKoxH79Utrs65jqSRtgV3BXeOgw3EMLRV0pQmXgX/ApnOOMNZ55zBOhK5?=
 =?us-ascii?Q?1kFc9RGjTRnofO8rVSFG01E4XucORiLYR3vqS1DyzRlG/lU7ww6E+QQOm+ZJ?=
 =?us-ascii?Q?ed+u7pRccSyNOSFHw/c/U+z29+4pAH5YR6mvrEF/?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB6373.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 964e9e11-5381-48a0-a8d9-08db62a45dc7
X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Jun 2023 13:30:29.0161
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: pV6ZL+O0Ktc4rZRTX59OpytsXlVqjvBAYr//rN3ZHxLeIxF1HCJhgd0zB3TBVzqdzWLSMiXgHX+3O2uloobKHg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB8477
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thursday, March 9, 2023 7:26 AM, Sean Christopherson wrote:
> On Tue, Mar 07, 2023, Wei Wang wrote:
> > Current KVM_BUG and KVM_BUG_ON assume that 'cond' passed from
> callers
> > is 32-bit as it casts 'cond' to the type of int.
>=20
> You're very generous, I would have led with "Fix a badly done
> copy+paste ..." ;-)
>=20
> > Fixes: 0b8f11737cff ("KVM: Add infrastructure and macro to mark VM as
> > bugged")
> > Signed-off-by: Wei Wang <wei.w.wang@intel.com>
> > ---
>=20
> Reviewed-by: Sean Christopherson <seanjc@google.com>

Kind ping on this patch.
Seems it wasn't noticed for months. Just check if it would be good to be
merged or not proper for any reason?

Thanks,
Wei