Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 1 Jun 2023 11:14:41 -0300
From:   Jason Gunthorpe <jgg@ziepe.ca>
To:     Nipun Gupta <nipun.gupta@amd.com>
Cc:     Alex Williamson <alex.williamson@redhat.com>,
        linux-kernel@vger.kernel.org, kvm@vger.kernel.org,
        masahiroy@kernel.org, nathan@kernel.org, ndesaulniers@google.com,
        nicolas@fjasle.eu, git@amd.com, harpreet.anand@amd.com,
        pieter.jansen-van-vuuren@amd.com, nikhil.agarwal@amd.com,
        michal.simek@amd.com
Subject: Re: [PATCH v6] vfio/cdx: add support for CDX bus
Message-ID: <ZHin0Redl/YIgNFg@ziepe.ca>
References: <20230517095718.16117-1-nipun.gupta@amd.com>
 <20230524104529.28708ae8.alex.williamson@redhat.com>
 <20230524134831.28dc97e2.alex.williamson@redhat.com>
 <1bf0323b-1191-de11-061e-00227e09dc35@amd.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1bf0323b-1191-de11-061e-00227e09dc35@amd.com>
Precedence: bulk

On Mon, May 29, 2023 at 01:36:30PM +0530, Nipun Gupta wrote:
> 
> 
> On 5/25/2023 1:18 AM, Alex Williamson wrote:
> > 
> > On Wed, 24 May 2023 10:45:29 -0600
> > Alex Williamson <alex.williamson@redhat.com> wrote:
> > 
> > > On Wed, 17 May 2023 15:27:18 +0530
> > > Nipun Gupta <nipun.gupta@amd.com> wrote:
> > > 
> 
> <snip>
> 
> > > > +
> > > > +MODULE_DEVICE_TABLE(cdx, vfio_cdx_table);
> > > > +
> > > > +static struct cdx_driver vfio_cdx_driver = {
> > > > +   .probe          = vfio_cdx_probe,
> > > > +   .remove         = vfio_cdx_remove,
> > > > +   .match_id_table = vfio_cdx_table,
> > > > +   .driver = {
> > > > +           .name   = "vfio-cdx",
> > > > +           .owner  = THIS_MODULE,
> > > > +   },
> > > > +   .driver_managed_dma = true,
> > 
> > Hmm, looks like cdx bus is broken here, there's no actual
> > implementation of a dma_configure callback and no setup of the IOMMU
> > default domain for theoretical cdx drivers that might want to use the
> > DMA API.  Without that, this driver_manged_dma flag doesn't provide any
> > guarantees to a vfio driver that we have exclusive ownership of the
> > group.  Please fix, this flag needs to actually have some meaning on
> > cdx.  Thanks,
> > 
> > Alex
> 
> Agree, this change was missed on CDX bus and we are working on fixing this.
> Shall I send this fix as a commit with this patch?

You should send it as a rc fixup for your already merged CDX bus stuff

Jason