Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <9997bc22-239b-ccc5-e7d4-a179144fdde3@intel.com>
Date:   Thu, 1 Jun 2023 08:24:43 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Betterbird/102.11.0
Subject: Re: [PATCH] acpi: Fix header declaration of acpi_arch_dma_setup() w/o
 CONFIG_ACPI
To:     Robin Murphy <robin.murphy@arm.com>,
        Hanjun Guo <guohanjun@huawei.com>, <lpieralisi@kernel.org>,
        <sudeep.holla@arm.com>
CC:     kernel test robot <lkp@intel.com>,
        Jianmin Lv <lvjianmin@loongson.cn>,
        "Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
        <rafael@kernel.org>, <lenb@kernel.org>,
        <linux-acpi@vger.kernel.org>,
        <linux-arm-kernel@lists.infradead.org>,
        <linux-kernel@vger.kernel.org>
References: <168477156440.3873520.6153672647621739139.stgit@djiang5-mobl3>
 <0953941a-ad4e-ba7e-4f4e-64c47de71f0b@huawei.com>
 <1751a3c4-a6b0-0a8c-cd1b-c05d25d30380@arm.com>
Content-Language: en-US
From:   Dave Jiang <dave.jiang@intel.com>
In-Reply-To: <1751a3c4-a6b0-0a8c-cd1b-c05d25d30380@arm.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?d3B0a3lvRW1aQ1ZDMFlSNmdiWkQ2NnV6WnFEVkVpcUc1SG5wRDdUSHVFV0lF?=
 =?utf-8?B?K0ZiSGR3aUwweWhPRkI3bml6QU1SV1BWMmxyU29EbmYvNmFmU0VUam5oUWxy?=
 =?utf-8?B?M2hFRGN6MStDbHFWTVNmZ0RRL0hEZHlod1JOTVZXVHUwaE1uanF6SkFvWFZ6?=
 =?utf-8?B?UG83ejdyUG1hdWdrYXRRWE5jc3NySnV0QnRSOWljaStQZCt2SWNRbUk0TEdX?=
 =?utf-8?B?cndycXpQeWlWOXY3bEdmeXlmbGhEZ3o4RjJnb0pKWjFsS0pLOEtPUURGQm9N?=
 =?utf-8?B?OW1rRFU0b3FMVkE2WVRqTkpnaXdHZEZ6Vkswa0JISHhIR044OEVXSjNQazBE?=
 =?utf-8?B?V0VQdTJYNmxoMTNaZWlSeE1UUHlhdW1aMFBWbHRPV1lHcjMwYjBMZ2RZcDh2?=
 =?utf-8?B?TEZOVnd2VnNyRTVIV2hteVdXWTFpTXRCejRzTWF6YlcycFQ3SDhaYzVvRDVF?=
 =?utf-8?B?WUlvUFg2TkVPZUU5N1FrMFBqaVpEbXAvS3VwZEltdDNsZWVuRXFSQm85VnVx?=
 =?utf-8?B?a3ZHa2RCYWNsSC9oRUZtSUZzMy9TVjlzN3hrV2hQNXQrNGkySDFIRTJFbTZP?=
 =?utf-8?B?MFB0ZUtLRVdjakVQWnJUejdYckYyM2R1TVlSZWhFZzczNkRPc2lqblpYQXpL?=
 =?utf-8?B?K0xJYll4a29PT3FTQnAxYWU5cUV0NkM2aTRjN1Avcy9oSVVlTUpVbityMW9L?=
 =?utf-8?B?WFNYcFY0emhrL0NqSnEyMEIyZTVNZ2thK042QjJzRjhjRk9rOVpSZGt3L2xI?=
 =?utf-8?B?dTFub2d5SGlqcEtIMXZsZmhqdlR5d2pQb2lCY3M1VmgrNDBGbzdhSU5qN0s2?=
 =?utf-8?B?bEJIU1dIaERWZTFnTlhSVkplaFpYQmcxai8rZjRmYjdpUXZYM3lCMFNJL0FP?=
 =?utf-8?B?c3dNbk9PdTNVMTFSYnJ6YkR3Sk1iYWdOVDl6MUgyMWZNNGhuZm4rb0FtYnBs?=
 =?utf-8?B?VHZveEE2RHN5eFJGK0d0T3o1cSt4UkU1MVNlc1d6cjJROFZWaWVNWUZDakRa?=
 =?utf-8?B?QVBkSnFNaFFvNyt1cFZCdGNUZkl3NjFrUkhQb0VpbGFSY1ZtdFRZejJ2UGM3?=
 =?utf-8?B?ZUM3Zm1yaEhnNDI4K25TR3ZzalNQbFoxZkUwUy90T1NIUyszYVpHRGpnOTc3?=
 =?utf-8?B?L0pVR3EvYlZ5d0ZGbVkzdHRTTHVXNGVUSmZ4UGFTQ25NR0RmRVFqdUNRcVF5?=
 =?utf-8?B?Q0xiYkc4NzY3ci9HM08zTEU3MXhCNTdoN0lndlIwcTRFdlhOMkEzaEIwcTg4?=
 =?utf-8?B?L1prZ0IwSEVpVHhBZkg4aHdsRzV3QlQ1aXZPS2dBd1lvUVJxZ0NISEpYZ05q?=
 =?utf-8?B?RXJyaFJ4Zi8yVFJSazZkeTVPS3J6QlZWaGJuVk81amtaQnFCajJ2VDVoTXVi?=
 =?utf-8?B?bndhbmZ2VG1FZC9xcUJ0cWlWWm1qOU5tSmNjYUlaK3R3K001VzI0T29tQ0Rx?=
 =?utf-8?B?Rnhsc0MyMUtPSW9rWkVwWk11eXRndmJ2Y081bjVVYitRTWhIdFVtNUhBdVAx?=
 =?utf-8?B?czJuRnlmdi9NOFg0SmxJcDBzVEVyUEpkaHZVeVpTTmRwNytFMmxMWk1HUkls?=
 =?utf-8?B?QjZUZTYvWnJGaWxhaTJTY2ZmN095b010ZUNyUC9IUmF1ZytuRHBGc1U3R044?=
 =?utf-8?B?YUVyV1QyZWpJRDRmcE9CeWljZDk1QWxQclNJWHF2QXJ5YnJ2Q0w1cjlPeitK?=
 =?utf-8?B?OW5NMkI4RUZOaHFHeFpYVnZjQXlVQXVaeWtUY2RDdEl0OUdIRWlKWkd2VCtL?=
 =?utf-8?B?QjFMdk1WWTM3VnVBMFZCWVFQcHp6RUpDVCtrZHFnMHIrR1BUT21rYm9PNFBV?=
 =?utf-8?B?a29iTDdTQS9KVUFXVUl4c1E1M1AvYTNFWjA1RTlaalBqclFUNmpDVUxxaWM5?=
 =?utf-8?B?cDlyb1IvVWtuaUE5YUo2UXYwY1dnaEQxenlTdVhFUlpjRDZMeTRTWDZZcHNO?=
 =?utf-8?B?dlhJK3lzSTdnWHo2YlNZenpGQkM0V25aKzFIaG9HNFZZOFpoV2NaSDN1Zm9T?=
 =?utf-8?B?TFMzQ1NWTTRWOHZvOGo4aUkzWEZ2WGwycUZWMnNmb3JBVzhaSVpkRWlmblU2?=
 =?utf-8?B?QUJoMnAwVkhGcmtvMmoyT1YvVGVpNmVYelhpNUxtWFZYNk5UTzAxeUYxUG5w?=
 =?utf-8?Q?EwePyB5xrRZa7Ntv89+00stcZ?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 8f46799f-9de8-41f6-638d-08db62b4559a
X-MS-Exchange-CrossTenant-AuthSource: PH7PR11MB5984.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Jun 2023 15:24:47.7273
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: WfILlAMv6oSQLJuB8EgRxDHRX6sR3FCK2Q0Ag6Xq1X6t3FxETMG91SoibnvYDPWHWMiCoeslvREp/1tndGs4wg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR11MB5826
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 6/1/23 03:31, Robin Murphy wrote:
> On 2023-06-01 02:48, Hanjun Guo wrote:
>> Hi Dave,
>>
>> Sorry for the late reply, I have some comments inline.
>>
>> On 2023/5/23 0:06, Dave Jiang wrote:
>>> arm64 build can be done without CONFIG_ACPI. The ifdef bits for
>>> acpi_arch_dma_setup() is placed inside CONFIG_ACPI. When CONFIG_ACPI is
>>> not set, this causes warning reported by kernel test bot. Move the
>>> prototype declaration for acpi_arch_dma_setup() outside of CONFIG_ACPI.
>>
>> ...
>>
>>>
>>>>> drivers/acpi/arm64/dma.c:7:6: warning: no previous prototype for 
>>>>> function 'acpi_arch_dma_setup' [-Wmissing-prototypes]
>>>     void acpi_arch_dma_setup(struct device *dev)
>>>          ^
>>>     drivers/acpi/arm64/dma.c:7:1: note: declare 'static' if the 
>>> function is not intended to be used outside of this translation unit
>>>     void acpi_arch_dma_setup(struct device *dev)
>>>     ^
>>>     static
>>>     1 warning generated.
>>
>> drivers/acpi can only be compiled with CONFIG_ACPI=y, so
>> drivers/acpi/arm64/ will be the same, not sure how to trigger
>> this compile warning.
>>
>> I disable CONFIG_ACPI on my ARM64 machine, but didn't get the
>> warning you reported.
>
> Looking at the linked LKP report, it seems it's it's explicitly trying 
> to build drivers/acpi/arm64/ despite the config:
>
>         mkdir build_dir && cp config build_dir/.config
>         COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 
> O=build_dir ARCH=arm64 olddefconfig
>         COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 
> O=build_dir ARCH=arm64 SHELL=/bin/bash drivers/acpi/arm64/
>
> So I guess it's a problem with the LKP setup? In general, trying to 
> build arbitrary parts of the kernel which are configured out can never 
> be expected to work.

It seems to be a problem triggered because I was working on some patches 
that added obj-y at the drivers/Makefile for acpi/ and opened the ACPI 
dir for !CONFIG_ACPI compile. The code has been reworked after comments 
from Rafael. So this is no longer a problem. Please ignore patch. Sorry 
about the noise.


>
> Thanks,
> Robin.