Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 1 Jun 2023 10:00:29 -0500
From:   Nishanth Menon <nm@ti.com>
To:     Hari Nagalla <hnagalla@ti.com>
CC:     <vigneshr@ti.com>, <kristo@kernel.org>, <robh+dt@kernel.org>,
        <krzysztof.kozlowski+dt@linaro.org>, <conor+dt@kernel.org>,
        <linux-arm-kernel@lists.infradead.org>,
        <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 3/3] arm64: dts : ti: k3-j721s2-som-p0: Add DDR carveout
 memory nodes for R5F and C71x DSPs
Message-ID: <20230601150029.hkjgohk3ivs2xz7k@trickster>
References: <20230529220941.10801-1-hnagalla@ti.com>
 <20230529220941.10801-4-hnagalla@ti.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20230529220941.10801-4-hnagalla@ti.com>
Precedence: bulk

On 17:09-20230529, Hari Nagalla wrote:
[...]
> +&mcu_r5fss0_core0 {
> +	mboxes = <&mailbox0_cluster0 &mbox_mcu_r5fss0_core0>;

I just noticed this, and noticed, this has been going on for quite some
time and was slipped
Use:
mboxes = <&mailbox0_cluster0>, <&mbox_mcu_r5fss0_core0>;

and respin. I am in the middle of cleaning up the ones that have crept
in already on too many platforms already.

> +	memory-region = <&mcu_r5fss0_core0_dma_memory_region>,
> +			<&mcu_r5fss0_core0_memory_region>;
> +};

-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D