Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 1 Jun 2023 16:44:34 +0100
From:   Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To:     Marek Szyprowski <m.szyprowski@samsung.com>
Cc:     Tony Lindgren <tony@atomide.com>,
        Jiri Slaby <jirislaby@kernel.org>,
        Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        Andy Shevchenko <andriy.shevchenko@intel.com>,
        Dhruva Gole <d-gole@ti.com>,
        Ilpo =?iso-8859-1?Q?J=E4rvinen?= <ilpo.jarvinen@linux.intel.com>,
        John Ogness <john.ogness@linutronix.de>,
        Johan Hovold <johan@kernel.org>,
        Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
        Vignesh Raghavendra <vigneshr@ti.com>,
        linux-omap@vger.kernel.org, linux-serial@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] serial: core: Fix probing serial_base_bus devices
Message-ID: <2023060123-shelf-bagging-4463@gregkh>
References: <20230601141445.11321-1-tony@atomide.com>
 <CGME20230601142147eucas1p1ae331f80a07ad6280f8f759b2d03ade7@eucas1p1.samsung.com>
 <2023060112-onion-disparate-8ce8@gregkh>
 <d7c857b8-4aa1-cd5d-4c45-392f7ed6857b@samsung.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <d7c857b8-4aa1-cd5d-4c45-392f7ed6857b@samsung.com>
Precedence: bulk

On Thu, Jun 01, 2023 at 05:09:52PM +0200, Marek Szyprowski wrote:
> On 01.06.2023 16:21, Greg Kroah-Hartman wrote:
> > On Thu, Jun 01, 2023 at 05:14:44PM +0300, Tony Lindgren wrote:
> >> If a physical serial port device driver uses arch_initcall() we fail to
> >> probe the serial_base_bus devices and the serial port tx fails. This is
> >> because as serial_base_bus uses module_initcall().
> >>
> >> Let's fix the issue by changing serial_base_bus to use arch_initcall().
> > This will only work if the linking order is such that this will always
> > come before the drivers.  Is that the case here?
> 
> Yes, serial_base_bus is linked as a second object, just after the 
> serial_core. Device drivers come later.

Oh good, I guess it wouldn't work at all as the serial_core is needed by
all of those drivers first too, so this should work, thanks for
checking.

greg k-h