Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 1 Jun 2023 18:00:53 +0200
From:   Richard Gobert <richardbgobert@gmail.com>
To:     Eric Dumazet <edumazet@google.com>
Cc:     davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com,
        lixiaoyan@google.com, alexanderduyck@fb.com, lucien.xin@gmail.com,
        linyunsheng@huawei.com, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/1] gro: decrease size of CB
Message-ID: <20230601160051.GA9082@debian>
References: <20230531141825.GA8095@debian>
 <20230531143010.GA8221@debian>
 <CANn89iJme7C4p1v6fnhUdXccgXQ3-9tUqFHbfjGMbGVqUtyT=Q@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CANn89iJme7C4p1v6fnhUdXccgXQ3-9tUqFHbfjGMbGVqUtyT=Q@mail.gmail.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Precedence: bulk

> Could you add a comment here or in front of gro_try_pull_from_frag0() ?
> 
> /* Must be called before setting NAPI_GRO_CB(skb)->{age|last} (/

Of Course, I will post a new version with it.