Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 1 Jun 2023 17:57:22 +0200
From:   Christian Brauner <brauner@kernel.org>
To:     Beau Belgrave <beaub@linux.microsoft.com>
Cc:     Alexei Starovoitov <alexei.starovoitov@gmail.com>,
        Steven Rostedt <rostedt@goodmis.org>,
        Masami Hiramatsu <mhiramat@kernel.org>,
        LKML <linux-kernel@vger.kernel.org>,
        linux-trace-kernel@vger.kernel.org,
        Alexei Starovoitov <ast@kernel.org>,
        Daniel Borkmann <daniel@iogearbox.net>,
        Andrii Nakryiko <andrii@kernel.org>, bpf <bpf@vger.kernel.org>,
        David Vernet <void@manifault.com>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        Dave Thaler <dthaler@microsoft.com>,
        Christoph Hellwig <hch@infradead.org>
Subject: Re: [PATCH] tracing/user_events: Run BPF program if attached
Message-ID: <20230601-legten-festplatten-fe053c6f16a4@brauner>
References: <20230509130111.62d587f1@rorschach.local.home>
 <20230509163050.127d5123@rorschach.local.home>
 <20230515165707.hv65ekwp2djkjj5i@MacBook-Pro-8.local>
 <20230515192407.GA85@W11-BEAU-MD.localdomain>
 <20230517003628.aqqlvmzffj7fzzoj@MacBook-Pro-8.local>
 <20230516212658.2f5cc2c6@gandalf.local.home>
 <20230517165028.GA71@W11-BEAU-MD.localdomain>
 <CAADnVQK3-NBLSVRVsgArUEjqsuY2S_8mWsWmLEAtTzo+U49CKQ@mail.gmail.com>
 <20230601-urenkel-holzofen-cd9403b9cadd@brauner>
 <20230601152414.GA71@W11-BEAU-MD.localdomain>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20230601152414.GA71@W11-BEAU-MD.localdomain>
Precedence: bulk

On Thu, Jun 01, 2023 at 08:24:14AM -0700, Beau Belgrave wrote:
> On Thu, Jun 01, 2023 at 11:46:13AM +0200, Christian Brauner wrote:
> > On Wed, May 17, 2023 at 05:10:47PM -0700, Alexei Starovoitov wrote:
> > > On Wed, May 17, 2023 at 9:50 AM Beau Belgrave <beaub@linux.microsoft.com> wrote:
> > > > >
> > > > > >
> > > > > > Looks like user events were designed with intention to be unprivileged.
> > > > > > When I looked at kernel/trace/trace_events_user.c I assumed root.
> > > > > > I doubt other people reviewed it from security perspective.
> > > > > >
> > > > > > Recommending "chmod a+rw /sys/kernel/tracing/user_events_data" doesn't sound like a good idea.
> > > > > >
> > > > > > For example, I think the following is possible:
> > > > > > fd = open("/sys/kernel/tracing/user_events_data")
> > > > > > ioclt(fd, DIAG_IOCSDEL)
> > > > > >   user_events_ioctl_del
> > > > > >      delete_user_event(info->group, name);
> > > > > >
> > > > > > 'info' is different for every FD, but info->group is the same for all users/processes/fds,
> > > > > > because only one global init_group is created.
> > > > > > So one user can unregister other user event by knowing 'name'.
> > > > > > A security hole, no?
> > > 
> > > ...
> > > 
> > > > Regarding deleting events, only users that are given access can delete
> > > > events. They must know the event name, just like users with access to
> > > > delete files must know a path (and have access to it). Since the
> > > > write_index and other details are per-process, unless the user has
> > > > access to either /sys/kernel/tracing/events/user_events/* or
> > > > /sys/kernel/tracing/user_events_status, they do not know which names are
> > > > being used.
> > > >
> > > > If that is not enough, we could require CAP_SYSADMIN to be able to
> > > > delete events even when they have access to the file. Users can also
> > > > apply SELinux policies per-file to achieve further isolation, if
> > > > required.
> > > 
> > > Whether /sys/kernel/tracing/user_events_status gets g+rw
> > > or it gets a+rw (as your documentation recommends)
> > > it is still a security issue.
> > > The "event name" is trivial to find out by looking at the source code
> > > of the target process or just "string target_binary".
> > > Restricting to cap_sysadmin is not the answer, since you want unpriv.
> > > SElinux is not the answer either.
> > > Since it's unpriv, different processes should not be able to mess with
> > > user events of other processes.
> > > It's a fundamental requirement of any kernel api.
> > > This has to be fixed before any bpf discussion.
> > > If it means that you need to redesign user_events do it now and
> > > excuses like "it's uapi now, so we cannot fix it" are not going to fly.
> > 
> > Looking at this a little because I have a few minutes.
> > What's all this unused code?
> > 
> 
> These are stubs to integrate namespace support. I've been working on a
> series that adds a tracing namespace support similiar to the IMA
> namespace work [1]. That series is ending up taking more time than I

Look, this is all well and nice but you've integrated user events with
tracefs. This is currently a single-instance global filesystem. So what
you're effectively implying is that you're namespacing tracefs by
hanging it off of struct user namespace making it mountable by
unprivileged users. Or what's the plan?

That alone is massive work with _wild_ security implications. My
appetite for exposing more stuff under user namespaces is very low given
the amount of CVEs we've had over the years.

> anticipated.

Yet you were confident enough to leave the namespacing stubs for this
functionality in the code. ;)

What is the overall goal here? Letting arbitrary unprivileged containers
define their own custom user event type by mounting tracefs inside
unprivileged containers? If so, what security story is going to
guarantee that writing arbitrary tracepoints from random unprivileged
containers is safe?

> 
> > static inline struct user_event_group
> > *user_event_group_from_user_ns(struct user_namespace *user_ns)
> > {
> >         if (user_ns == &init_user_ns)
> >                 return init_group;
> > 
> >         return NULL;
> > }
> > 
> > static struct user_event_group *current_user_event_group(void)
> > {
> >         struct user_namespace *user_ns = current_user_ns();
> >         struct user_event_group *group = NULL;
> > 
> >         while (user_ns) {
> >                 group = user_event_group_from_user_ns(user_ns);
> > 
> >                 if (group)
> >                         break;
> > 
> >                 user_ns = user_ns->parent;
> >         }
> > 
> >         return group;
> > }
> > 
> > User namespaces form strict hierarchies so you always end up at
> > init_user_ns no matter where you start from in the hierarchy. Return the
> > init_group and delete that code above.
> > 
> 
> This is a good point, I'll delete this code and bring it back as part of
> the namespace support patch series when appropriate.
> 
> > static char *user_event_group_system_name(struct user_namespace *user_ns)
> > {
> >         char *system_name;
> >         int len = sizeof(USER_EVENTS_SYSTEM) + 1;
> > 
> >         if (user_ns != &init_user_ns) {
> >                 /*
> >                  * Unexpected at this point:
> >                  * We only currently support init_user_ns.
> >                  * When we enable more, this will trigger a failure so log.
> >                  */
> >                 pr_warn("user_events: Namespace other than init_user_ns!\n");
> >                 return NULL;
> >         }
> > 
> > Your delegation model is premised on file permissions of a single file
> > in global tracefs. It won't work with user namespaces so let's not give
> > the false impression that this is on the table.
> > 
> 
> Users that are given access to the single file still should be able to
> be isolated for each other. The series I'm working on does this by

How? You currently have a single file that will have to be shared across
all unprivileged containers which ultimately can only mean that you need
to either bind-mount tracefs or bind-mount the single file into each
container. If you have 1000 containers each with isolated idmaps from
each other you're going to have a lot of fun trying to ensure that each
container has access rights to that file.

> changing the system name of user_events on a per-namespace basis.

What is the "system name" and how does it protect against namespaces
messing with each other?