Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp1038328rwd; Thu, 1 Jun 2023 09:37:33 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4pfkdCe/iaqUt7aSXgRDEDLcYlME6Ln+DO8j6Cmbl4iRq4MgnrMIe2IDrCI5sJg88d0djr X-Received: by 2002:a05:6a00:2283:b0:64d:413b:1e1b with SMTP id f3-20020a056a00228300b0064d413b1e1bmr9272601pfe.23.1685637453469; Thu, 01 Jun 2023 09:37:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1685637453; cv=none; d=google.com; s=arc-20160816; b=xJ8vifVM+aqs3AlSWACsiBVA68jb0/hUAC6P47xXW3PptVB5SeFJiuNPT2D184jcYP 5YH5mw8jCyzpyy0fQB75gHh4wt8fIueHLC90Fwej2xrc329zF6pGvvm8axoXmnNcCVym OFHY88eY9Re7/bWPnwcXh+9mrsFSH7id4NXsH2Lmqmb2lrbpjCl/0bwOKvxBA8u4ySQB YcDoMsf48Fa5NgKNMAQc5J3QZrZJDJEdfBM1YSWzVfXiGLxxfDQzBY/t5/ZpQdalR62d KRmse+4BvIN+jifEw2jbPzEbSekiZ8a1sAdApaRJ1uP+L8gZaEA5mcAOiMAc/uowqgZx 1AAQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=MNEX8C9YooWYSDDaYe+Qcb4YjjWj096sIcgpgIg+A3c=; b=I8S7aGCMNNjhi1+WVDN9j15a2hCA1yog1b8QrejyoYQSKPVO6d72D2H1JnKuaw0aZO u/0IELjGQDC1E2EQrap3/jCL3gh1gTsr2yxMlgoo0m3k+v9+UXdlJ+CYFem1xNsbBYHm JSmKWwvSajwnrhmB/+2b6CMN7VFvVoiTzyKBrjn8tx4bIUbaJY5nqQR4hgqm7s3tXzDF SpTKrjZWGdtNm8P0dUY90SJl7qo2OLzffTrxoM44HC2oaRUWitMWaoTT0AaQuPw2lVcv zD80yIRSw2f7JiZ6rY3Txz637L3NdCOEezLO2QcQaxgpqqzL6ubte6IGYv5KvT/q6+JL KHDg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=uask0kYg; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id k28-20020aa79d1c000000b00643aa8d8cb7si5814094pfp.185.2023.06.01.09.37.21; Thu, 01 Jun 2023 09:37:33 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=uask0kYg; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231415AbjFAQY4 (ORCPT + 99 others); Thu, 1 Jun 2023 12:24:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46322 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231455AbjFAQYr (ORCPT ); Thu, 1 Jun 2023 12:24:47 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 090B912C for ; Thu, 1 Jun 2023 09:24:47 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 921C564765 for ; Thu, 1 Jun 2023 16:24:46 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5C591C433EF; Thu, 1 Jun 2023 16:24:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1685636686; bh=z2jRM0EP0gZuG8P+depP6m9f5gvxbYTHzOyRjArHXiA=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=uask0kYgt+bwbE+OcZI076XeSB0HLseqNmZTb7q/WcN3i6WAu38JXB+TJOPbMAehk 8jb7KAXjQJsdJSFpQ2edobdk80XTpn6BodnF1sjEhjxFoA6SYbGZ5JR85z3pkyX3Qk pOQSmj0MCqkdQlah23m5k/33eW5YiBWjp1D8bO/xu/Krocto8/rXSMg8Ffmxy9jP4z ICMCshl5u4+Gm0Q9dZMQeeGKsI5X3zZopz1F6b43yZ8ACtlIkOF/trlvJ+6tiCR6dD g9k88jjqWjV+w4u0dT4il4S3/i2m+95CJW7pV8xBiZP2wZpPnqWF1h5NNrM6dTEonQ pQhixEyPqpjlg== Date: Thu, 1 Jun 2023 09:24:44 -0700 From: Jakub Kicinski To: Anjali Kulkarni Cc: "davem@davemloft.net" , "edumazet@google.com" , "pabeni@redhat.com" , "zbr@ioremap.net" , "brauner@kernel.org" , "johannes@sipsolutions.net" , "ecree.xilinx@gmail.com" , "leon@kernel.org" , "keescook@chromium.org" , "socketcan@hartkopp.net" , "petrm@nvidia.com" , "linux-kernel@vger.kernel.org" , "netdev@vger.kernel.org" Subject: Re: [PATCH v4 1/6] netlink: Reverse the patch which removed filtering Message-ID: <20230601092444.6b56b1db@kernel.org> In-Reply-To: References: <20230331235528.1106675-1-anjali.k.kulkarni@oracle.com> <20230331235528.1106675-2-anjali.k.kulkarni@oracle.com> <20230331210920.399e3483@kernel.org> <88FD5EFE-6946-42C4-881B-329C3FE01D26@oracle.com> <20230401121212.454abf11@kernel.org> <4E631493-D61F-4778-A392-3399DF400A9D@oracle.com> <20230403135008.7f492aeb@kernel.org> <57A9B006-C6FC-463D-BA05-D927126899BB@oracle.com> <20230427100304.1807bcde@kernel.org> <472D6877-F434-4537-A075-FE1AE0ED078A@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 1 Jun 2023 16:15:31 +0000 Anjali Kulkarni wrote: > >> I don't have sufficient knowledge to review that code, sorry :( > > > > Is there anyone who can please help review this code? > > Christian, could you please help take a look? > > Gentle ping again - Christian could you please help review? The code may have security implications, I really don't feel like I can be the sole reviewer. There's a bunch of experts working at Oracle, maybe you could get one of them to put their name on it? I can apply the patches, I just want to be sure I'm not the _only_ reviewer.