Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <2ccdf297-0998-d1a8-5a66-0abdc6e37c1b@oracle.com>
Date:   Thu, 1 Jun 2023 11:10:50 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.11.2
Subject: Re: [RFC PATCH 0/8] vhost_tasks: Use CLONE_THREAD/SIGHAND
Content-Language: en-US
To:     Christian Brauner <brauner@kernel.org>,
        Thorsten Leemhuis <linux@leemhuis.info>,
        Linus Torvalds <torvalds@linux-foundation.org>
Cc:     oleg@redhat.com, nicolas.dichtel@6wind.com, axboe@kernel.dk,
        ebiederm@xmission.com, linux-kernel@vger.kernel.org,
        virtualization@lists.linux-foundation.org, mst@redhat.com,
        sgarzare@redhat.com, jasowang@redhat.com, stefanha@redhat.com,
        Linux kernel regressions list <regressions@lists.linux.dev>,
        hch@infradead.org, konrad.wilk@oracle.com
References: <20230519-vormittag-dschungel-83607e9d2255@brauner>
 <ab8c9f95-c9e9-de04-4e28-78163a32da80@leemhuis.info>
 <20230601-herzallerliebst-dschungel-4515db351a0c@brauner>
From:   Mike Christie <michael.christie@oracle.com>
In-Reply-To: <20230601-herzallerliebst-dschungel-4515db351a0c@brauner>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UDdSU2FhWU85dzJVZnNtWEc5U3E1N29vemh1UWhMMWs0Y0ZOMEJQQ1V1QURq?=
 =?utf-8?B?MFdpaFAxaXE4NGJOcnAzNVhJTHRwUy9hWmtmSGVkN1pSdFovRysvcGRHek5Y?=
 =?utf-8?B?SWtSakpDaVpDckZ2bXNPemJkWkxvSHI1bEF3WXVmT3RXdk9NL1NRZW1Kd21q?=
 =?utf-8?B?R1NBQzg3Tm1aSUpyRUtNUm8vQUluei9RZkdpNmlTRFgvS2lldldKSWxKTGYw?=
 =?utf-8?B?Yy9jUEcxaWsyNFI2MnZ6dHBsdVVld2tja2pyNlVKOGRpZ1k1UTl4VnNCL3cx?=
 =?utf-8?B?SE1kNDdnZjVoTmYrd1U5eFJURERDUnhkMG9oekVNc3o4N3BiV2RLTWEvM3E1?=
 =?utf-8?B?RkswOXdDUndzang1d0lnTmI0dS9TL0tGWEViZ0dVb1NlWklXU1JCTUluYjcy?=
 =?utf-8?B?R3hpQno2VVdSbkpkd1QxSTk2anF1bFZVMDB6RzAvTEJKNnVXY3JuNk5WZzZQ?=
 =?utf-8?B?RjQwa3BTbGhvT2pxY296cDNTT2lLb0dPcVVrL1ZSTXdNNEdsUTRXdTlzL0VK?=
 =?utf-8?B?T3JKSkl5WDBKSkpMeXZyWGlNZ3hvTnczeUl1SFk5VFFBLyt2ZkhIRVowRDh2?=
 =?utf-8?B?d1lraVZDNFBkOFpxdTh5emJCbmJBQ1RpR2RORWVkRW1NY3prcmRBYkhST3Yy?=
 =?utf-8?B?YS9WQkdKc1BQMnU1aW9VN29rMmVpRDk0aHk1L2F1Y1JsOWJLNTdpT0RiTmhM?=
 =?utf-8?B?NHZ3MEtyRnQ0elVwTEF5MVZNZGFBeDIvL2NZeEdmc1FOQkt5UlFzUVIxWHJC?=
 =?utf-8?B?TmpiSUlVOG0zVjZpMTJpQzVTTTY1bVErNWJsSEtHaHRic1MrcU5aVG1YTzls?=
 =?utf-8?B?Yy9ldTNGWEdXZkFpM2ROQTU5UU4rS3kySlU4blV6amlIVXdpakRjaW5nSGdK?=
 =?utf-8?B?cGszTnJTcnV3UDRQdXBLU1c4V25sdVRaQ0hlK01uZVNlaC9UckJIVFBqdzg0?=
 =?utf-8?B?TGExUG9vbEY4dGFMb3B6OWk4R2IyOEtVV3k4a085Z2xDY0dudWM2QlduM2pM?=
 =?utf-8?B?ZG5qL2pNRm1YRTlOQ3JxNVpvNmNiNWdEdngxRkFJVmJRVXFFRk51UVNZZEE4?=
 =?utf-8?B?N3pUeTJFMFBxVjYxSEtzZWZhQ09JcmEyU0dJY1ZiWTdqM0RNd0U2cjNqQ3Ux?=
 =?utf-8?B?VU52MHFIaml3SnZkRXBlVGFjM1hsUjRvY3hSbU1iTlllR0RYZkcwcG5oeHBX?=
 =?utf-8?B?Qk1ZbnZPemVQSmI4VUhNRXh2ZE1vM1NEN3F3ZTdSZkJLbU5LTzZpb0NTanIw?=
 =?utf-8?B?MmJwV01xVzZHb08yekU5TnJ3TEFDZVpvaEJaUUNYYnpxZ2ZsWkhjNWNqd2pJ?=
 =?utf-8?B?Vm5MWmQyL1o0MnVzUVRNSk5KZ2FVbERsRmhwdkM3N3RXemE0Z1EwRExIYnMw?=
 =?utf-8?B?U0laUWp2V1VxZU5pOHJZOEJHT2JKd1E0dDhyb0ZBUExMYnMrZDE0R2duMFU2?=
 =?utf-8?B?emVFV2xhcmw0b0xIa2FiSDJlSHRDQjA2Q2tzNDVOdlFtMTV1K1c1SGNPY3A4?=
 =?utf-8?B?Mm1oTWhQbm5wNDBReFNpU25iWU90LzdmRTV1bHBKdVE1R0RVd1RldG84M2Uy?=
 =?utf-8?B?RlMwbE1UWkI0R01Ndm5TSkNCZFFlMmVhQlZ6dTY4ejU3c0RNbE9EZ2NNYm1R?=
 =?utf-8?B?WEt4NkMxREdwdjZXdTA4VkxWcXJEUUFVbk4ySEhIeHhCbHYwdldZSHNrLzJQ?=
 =?utf-8?B?NURNK1NSTVNCdStsWlQ0ZW1FdlRNSUNrUDJxemRJdGNMUHdJWmNMTnAyek9E?=
 =?utf-8?B?QllxR1BjNERqRDh1RG5ZR2NxamU4TmZIVEdXR3BPQVNYemdhT1BxanNBc2s1?=
 =?utf-8?B?M1doNHJVd21jd0l4b2NnNjNsekxIaGU4ZGZoTVhwQ0hlc2sxZ056Tzg0V0pB?=
 =?utf-8?B?Q1ZsWEVocWI3UEhqSWN1Qnh1ZUlxRUo1WDR4cUdDM0E2dWRYaXF3ZTZ2d3pR?=
 =?utf-8?B?UE1HSWVtamRHNVUxSHJMYlAzemtVUC82QnVPZmV1aW1TWEZKSlZQeTI5cll5?=
 =?utf-8?B?VThpWndYc09mb1FlRUtjV2pKWVZ2cmRMTysvYXpzWkdtRzBOdkVKM2FOYUNO?=
 =?utf-8?B?aXE3VUVoOXVCeHJEZHVkM1ZqNTlqaG9YeWhBNnRJd0Q5bkZ5WUNZbWJyNC9S?=
 =?utf-8?B?OXpVWXNQMnAxMlNaczVOWEcvcEdjd2pDNTVCWUJvMDAwZGFSYTNWUWZBdE1F?=
 =?utf-8?B?RlE9PQ==?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?utf-8?B?dWlWZ0ZlT1E0d0FLZWY2RDMyVm5Rd3V2UWVrTjhvL3dPUDc3a2lXNmgrSXVL?=
 =?utf-8?B?M0VrKzV2WnZLd1NNM3JSWTB5cU0xcUJWK1ZKR3RQZlFpZytRb0ViOFRtc3Vy?=
 =?utf-8?B?bHRoNFRsbi9Zb3JBWkM0YzVHMXlscjdPTkpDVVJzbmpQQTcvVHF2OHRIM1RW?=
 =?utf-8?B?Y3MzbTFiRS9IemxpRjJ3WEl1WFZvZENjRFlrcjlDN2h0TERQVlNGak1PS3gw?=
 =?utf-8?B?MkQrR0QvTzNiQnF0cjAvRTd0WUw4T3d4ajFtWkx6djR5MXJLVlUrYVIrd2VK?=
 =?utf-8?B?V2h2bU9mMm5XY2FPMmpxdVh0M0dzMnBNN3VzR0VRYk11MXlRdEFKejY0V2lz?=
 =?utf-8?B?YkowcGMzMVBJOGI3ODVWVFdpc2ZYaC9pMWp3YzFsT01uTTRiSEFJS0xBR1pZ?=
 =?utf-8?B?TEh5RUNMUFEySUM0N0RhcUFRV05nSk02b1JJd25lSFNpbmNlUmJsRStJWXg1?=
 =?utf-8?B?eTY4ZE9YT0lGaG9Cd2RUV3hvV2YvYlpuc0ZLSGY2SEplcnJwSGpHZ0d6L0xn?=
 =?utf-8?B?RmsyRmpjN0h6WWNoS0J0S3ZMS1l6Slpackx4a0c1VHMwYnlMU1hOWEdxWUU4?=
 =?utf-8?B?NmozdVpndVprMGNUUkJEcWZ3UVJEdHcraWhhaitrN2lIWTVrTDVScjU1TldR?=
 =?utf-8?B?WmNWb0JLNHRMVDU0WFBGNGJNalZMclpjKzhzdmJKWEg0K2ZqQkYwNWFVMjVP?=
 =?utf-8?B?RGtxQ3dRalhMSzlnVHE5aUZIaWV6dlRIbGttREdGeVlqOHVwbnNDK05YSE11?=
 =?utf-8?B?SWlnb3JJTG5MNVFrdjhoVUNsOHdHb2QyQTVURFZnSVUrRmxON3hGUFE5ek1k?=
 =?utf-8?B?QUcxd2tQVEFtbThwTHJsN2JWRFFjTUpMR2NDSG9DekJtS0k1QngrK1EzcHFS?=
 =?utf-8?B?OEY0L3FLSFBkL0JackN0UU5mY2FHUjhtYUxpdjBNTnVMOU1lTURJcDVDWkQ3?=
 =?utf-8?B?MEdiN05KZjFqdmZxYXlQaVh4MUVpQXlFV00zKzEwdjFmN1huQUVjQjhqZTlT?=
 =?utf-8?B?VWtnM1pjaEhBeG9sTWZ3NXBpcGNIWGJUY0ZhMmxGN0lwOTlPeHpBdnhaS01I?=
 =?utf-8?B?dStVYjdhZmJVWW1YSndXQUJUb0ZselJRdVNDaUxTODRRQldHQUhiT1U4QTQy?=
 =?utf-8?B?UEVtWHFtVk1wNjVsbjVWaDZ6dXhKRG04aXQxMTAvbVprZVhxWER3dHRxb280?=
 =?utf-8?B?ZUxjcEwyREx6ell5ZVBZSzZ2aFZ0V25NQWRyVnlXY0ZzQ05YSjlVa0djQUxH?=
 =?utf-8?B?T2NxRS82OTBlMGVDU0ZkMys3d2NSY3YrYVcxdXB0QXh6TzNzcjZtM25NYXgx?=
 =?utf-8?B?NDdmdHowYmtybVhPMlFUMm12c2RFVS8wWDdueGc5SVFBcTZ5Rnd1cnJjNWd5?=
 =?utf-8?B?QUJpYW1JOHlFL29MaU1TVkRob2QxMmpCSlhtcE1UTmFQWTFkR0NHNDdydm5R?=
 =?utf-8?B?bkxZajJ5Z1NadWJNWXA3NVhyNWQxaVYwWFpUNXZqQ1lxelNmVVoyNnpuUU5i?=
 =?utf-8?B?ejRUT0ZPZ0sxUk9GcnJtcWlJR0VpcWFQVDZuaW50aTFPTFY2cUlsYUR3RVdY?=
 =?utf-8?B?WXhhQT09?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4373a65b-c45b-48b2-94ad-08db62bac68f
X-MS-Exchange-CrossTenant-AuthSource: CY8PR10MB7243.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Jun 2023 16:10:53.9328
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: O3cpzMdj5lJ/IJDarrBDoAL0hKFO8yYB6u3a+rTKLaG4vH1L1mp+/L885MQLd7qC42p8AnHjQIpyEItUs+cFedkURFWp630Wjk3vwhWAN14=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR10MB7691
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.573,FMLib:17.11.176.26
 definitions=2023-06-01_08,2023-05-31_03,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 adultscore=0 spamscore=0
 phishscore=0 malwarescore=0 mlxlogscore=999 mlxscore=0 bulkscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2304280000
 definitions=main-2306010140
X-Proofpoint-ORIG-GUID: hS4XglQpkapDkPyPNgFGuML9ritvmoIs
X-Proofpoint-GUID: hS4XglQpkapDkPyPNgFGuML9ritvmoIs
X-Spam-Status: No, score=-2.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 6/1/23 5:47 AM, Christian Brauner wrote:
> On Thu, Jun 01, 2023 at 09:58:38AM +0200, Thorsten Leemhuis wrote:
>> On 19.05.23 14:15, Christian Brauner wrote:
>>> On Thu, May 18, 2023 at 10:25:11AM +0200, Christian Brauner wrote:
>>>> On Wed, May 17, 2023 at 07:09:12PM -0500, Mike Christie wrote:
>>>>> This patch allows the vhost and vhost_task code to use CLONE_THREAD,
>>>>> CLONE_SIGHAND and CLONE_FILES. It's a RFC because I didn't do all the
>>>>> normal testing, haven't coverted vsock and vdpa, and I know you guys
>>>>> will not like the first patch. However, I think it better shows what
>>>> Just to summarize the core idea behind my proposal is that no signal
>>>> handling changes are needed unless there's a bug in the current way
>>>> io_uring workers already work. All that should be needed is
>>>> s/PF_IO_WORKER/PF_USER_WORKER/ in signal.c.
>> [...]
>>>> So it feels like this should be achievable by adding a callback to
>>>> struct vhost_worker that get's called when vhost_worker() gets SIGKILL
>>>> and that all the users of vhost workers are forced to implement.
>>>>
>>>> Yes, it is more work but I think that's the right thing to do and not to
>>>> complicate our signal handling.
>>>>
>>>> Worst case if this can't be done fast enough we'll have to revert the
>>>> vhost parts. I think the user worker parts are mostly sane and are
>>> As mentioned, if we can't settle this cleanly before -rc4 we should
>>> revert the vhost parts unless Linus wants to have it earlier.
>> Meanwhile -rc5 is just a few days away and there are still a lot of
>> discussions in the patch-set proposed to address the issues[1]. Which is
>> kinda great (albeit also why I haven't given it a spin yet), but on the
>> other hand makes we wonder:
> You might've missed it in the thread but it seems everyone is currently
> operating under the assumption that the preferred way is to fix this is
> rather than revert. See the mail in [1]:
> 
> "So I'd really like to finish this. Even if we end up with a hack or
> two in signal handling that we can hopefully fix up later by having
> vhost fix up some of its current assumptions."
> 
> which is why no revert was send for -rc4. And there's a temporary fix we
> seem to have converged on.
> 
> @Mike, do you want to prepare an updated version of the temporary fix.
> If @Linus prefers to just apply it directly he can just grab it from the
> list rather than delaying it. Make sure to grab a Co-developed-by line
> on this, @Mike.

Yes, I'll send it within a couple hours.