Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 1 Jun 2023 13:09:48 -0300
From:   Jason Gunthorpe <jgg@nvidia.com>
To:     Arnd Bergmann <arnd@kernel.org>
Cc:     Mustafa Ismail <mustafa.ismail@intel.com>,
        Shiraz Saleem <shiraz.saleem@intel.com>,
        Leon Romanovsky <leon@kernel.org>,
        Arnd Bergmann <arnd@arndb.de>,
        Sindhu-Devale <sindhu.devale@intel.com>,
        linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] RDMA/irdma: avoid fortify-string warning in
 irdma_clr_wqes
Message-ID: <ZHjCzHfNPubWUXcL@nvidia.com>
References: <20230523111859.2197825-1-arnd@kernel.org>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230523111859.2197825-1-arnd@kernel.org>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?QdNwZZaZXdT9pgSeopOFMjup0fOgmTszBBg56XTlCtT233c9k4rqzhGP7kbk?=
 =?us-ascii?Q?PRndRqWKkayjkLDpoNYjl0o/4WEB5wmhxY/sBMlPjWGwpeSTX5cu7xAGmfN3?=
 =?us-ascii?Q?u1xRSL7fchCWNnyAjgp2GNgFkAVOqEmXNt/RamhbOBf7LA98wD/BZidpLgd1?=
 =?us-ascii?Q?OCcP+aLxd1G1EkqF7/9tU54xyYFT6mRwUsEjXmSJOgeaRIvWgE/UGt7Jm+gd?=
 =?us-ascii?Q?svRTCxIp6TIz5JMK4X7Xym0nddE7qAsu9yHXit2KlMAzlj/eEs2rLVktkUvY?=
 =?us-ascii?Q?2FMLuoPL+SQC+yNhPPNaNsW8pMQxX4DZrf8KbxzbgQAcPiVrfIFY6ixLMcuh?=
 =?us-ascii?Q?BU19VQk4RMsF8C9jzi/QKT9aXCOKssdkLDQ+rM0qDWKY4czPf9L+Ol2sSln4?=
 =?us-ascii?Q?3oP84++HXI54gokhrpHFDwkehI7B5LVWrrU4XPnjre8KXk/VwRaj1Og5UBMh?=
 =?us-ascii?Q?fDwsQoTjJf5ZmXwTdzKmPYYUtdY8BbUhRz9j8TgJvq19RfGej55I/753zcb1?=
 =?us-ascii?Q?0MpT4mvegnZWKOhe7Qb7zf2QcxFlqT5W7f4EnWS4avIAvSuLbhS6JxTqFJ4H?=
 =?us-ascii?Q?pbFoYF6BISp6E26OGFGotrLRkhSuA99i2JL9kNNVIBXET/yJ/cI3j3zgM7Xx?=
 =?us-ascii?Q?EkBHjE3IZRNnqXGOw+eaJ6MftvXKA9U+OPhXbttiIJYhgzx/+Zsv1fALGOSN?=
 =?us-ascii?Q?8VXvVbQPnH3/rtjvBgX1L+zZ78BX89LQn2f5/P92KpcKs5M2Sm9vgKU2Qalf?=
 =?us-ascii?Q?i2dnBcPP8RRU4ZwKRLDU/JKLwPVrOh4VEOYaiqwfVnkHvvGUYyTqufDFpZDT?=
 =?us-ascii?Q?a4vwG1zALi6u6UJLSco52LdKdTayCQAmuj71OHIxnBfQ5HOaX3pjC8wdjRCt?=
 =?us-ascii?Q?qdK4py6Wx9PVR5f0Lc1qIZWKckT3SZyRLN0rMAfklHn5TdrIbRsxfUwYsNHz?=
 =?us-ascii?Q?o7n9C8QVpPAlCzoxcVuyQx5r3rL5aUl2xtLTXDkGVfC4v+e2tHd99mL5JWIJ?=
 =?us-ascii?Q?RHTN8S28AdW06pg1rqFTjwUZMFpE0kI1ETbX37Ao/rQyGGSPzw10AsIIXypV?=
 =?us-ascii?Q?lHCHdY6qsrjQBSJYollOwyueF0V35YohAR/5eim8m8Fv5CYH/rhJLs1AEQ1C?=
 =?us-ascii?Q?oEgMcKCV94fGNG03LYM8ExvHj8wiwi5QvijMffdL0JLL9kNNcajCljOFxGRm?=
 =?us-ascii?Q?qEtDT7BvYtHs5OJ5ujgZvQ4LYLVoVbjfoq8l9WbCYl3OFowknPlzbWbzLz3X?=
 =?us-ascii?Q?fAm0AMz2Uzg/pbum19VwGQAqytVQAwt0x8Us4K0DNoyajb716O/Kdvd+BehQ?=
 =?us-ascii?Q?AptN/xiGKtMGleo8gQbxRQTTwsJZ66dnjyUHsOgJFTd2cCYtx+C2hYl9MvrG?=
 =?us-ascii?Q?8KqDIpVBZsdoA4a9JceyU+yCFP5oBVcU8qLV7mVYDE9lM1ME/LfCxfrDOxcw?=
 =?us-ascii?Q?7+nWnay+JCVVSdBWZCO9k7IPElmtj72PPcFaan+C9cXnCP1Y6qFEqgCZ/eat?=
 =?us-ascii?Q?Di2aFXUogMRjzKLQPjXshmScB4j6kxBiaYUDIKJK/rpRLFVyiSuI9jHeOqZ4?=
 =?us-ascii?Q?e9rqj0r1jBVMlmQAHNjis0md+VfHYNRINM+CdAjm?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 23d62477-f241-4471-995d-08db62baa10d
X-MS-Exchange-CrossTenant-AuthSource: LV2PR12MB5869.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Jun 2023 16:09:50.9950
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 0yPXSFUQ8ntMmBd4mJlKqfTIMsNZtFWY7wH03WmhnHSSIQj7iprPYHwxkb52hzYU
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR12MB4542
X-Spam-Status: No, score=-1.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, May 23, 2023 at 01:18:45PM +0200, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
> 
> Commit df8fc4e934c1 ("kbuild: Enable -fstrict-flex-arrays=3") triggers
> a warning for fortified memset():
> 
> In function 'fortify_memset_chk',
>     inlined from 'irdma_clr_wqes' at drivers/infiniband/hw/irdma/uk.c:103:4:
> include/linux/fortify-string.h:493:25: error: call to '__write_overflow_field' declared with attribute warning: detected write beyond size of field (1st parameter); maybe use struct_group()? [-Werror=attribute-warning]
>   493 |                         __write_overflow_field(p_size_field, size);
>       |                         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> 
> The problem here isthat the inner array only has four 8-byte elements,
> so clearing 4096 bytes overflows that. As this structure is part of an
> outer array, change the code to pass a pointer to the irdma_qp_quanta
> instead, and change the size argument for readability, matching the
> comment above it.
> 
> Fixes: 551c46edc769 ("RDMA/irdma: Add user/kernel shared libraries")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Acked-by: Shiraz Saleem <shiraz.saleem@intel.com>
> ---
>  drivers/infiniband/hw/irdma/uk.c | 10 ++++++----
>  1 file changed, 6 insertions(+), 4 deletions(-)

Applied to for-next, thanks

Jason