Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp1054927rwd; Thu, 1 Jun 2023 09:51:43 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5KBOAfjh68bp12Zr8EdraIMdElB66hseR5KFmlEqUF8ZZQp9RyG8BY4TD6/c4h0MUH3V5z X-Received: by 2002:a05:6a20:9f08:b0:105:12ab:878f with SMTP id mk8-20020a056a209f0800b0010512ab878fmr9708203pzb.56.1685638303194; Thu, 01 Jun 2023 09:51:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1685638303; cv=none; d=google.com; s=arc-20160816; b=01vle3dRzluQJBpkj65Vx6WR1XPq/fIkQDI39xxmPajOWssQM1i52pDkqh30tvKLjr 2UxS7uoA70mwGAlb1YESdUfcmwpMRrUnjWsEuaS+j9xgSALprt6UYNRWh6IyIGOrdoRi eHqgDV0wxGMA92kF9ftmzVXop1L8R8u8OyXY3uzTXs3paUjXuRkRoIFc8sb3MhtQvkPI jRBvVlT0qiRgTT9jVL+oTaMVET7D/e1DDex6bsJU0R/IFzD1ffEr6JFZzfJC1tcMkh8W c7ZogQBpWcdECrqmp88vR6yrcntlLWCzzsrsYLyqbLI1CDUPLk9MB/xjez+GKBJGhx2i TAyw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=onqXnHQ5F7barTOU/acm/lAQPuCJUFC4FX9w9PM5Mlg=; b=pr/vEL5PqWNaE89NW962nvppYstGv698xC9OZ07XUX/W/Q7jU77dLBrVZwNE2clAd5 psmRpNbiWlb6PlAjM7N41awQf14pPT4+rdE9GD1fHQubyhDTUT2PXMtFhFNL5UAvSjYs YvHPLcr9xP6vZ695AxfwmFGVzReZmsJsFv8j7xGl18dlcw7Asao+fkCOJvjA6QRwcQ7t /aW9LSXkFsYiQv71DPutvOxKlLAL/dcrHqjDpL5G6h2Rk1DCVumEleE43FSRqWc6Y8Ff KUI5UcUwmqu0AobxJ87Z+DyibUoPlLCRTbKYOiFtd8Yg5hMCAKZUy5C3v9s5+J0XDnZf 21Eg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=cKyGGBpt; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id az9-20020a056a02004900b0053fbb3f1581si3303715pgb.701.2023.06.01.09.51.28; Thu, 01 Jun 2023 09:51:43 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=cKyGGBpt; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231603AbjFAQsc (ORCPT + 99 others); Thu, 1 Jun 2023 12:48:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60134 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231359AbjFAQsa (ORCPT ); Thu, 1 Jun 2023 12:48:30 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C3308195 for ; Thu, 1 Jun 2023 09:48:29 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 60095647AB for ; Thu, 1 Jun 2023 16:48:29 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2B124C4339B; Thu, 1 Jun 2023 16:48:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1685638108; bh=NAEpQiWq9IAmY1tOE/V+2ZvrYEYSuad9TRbmAHGYccY=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=cKyGGBptkS8lmAm8KpkDIU5YS0wj2xi1fEgibcRpwQyssiRTp1BlZ1tCCyHN6Qf6c LbIZQtpDWJcV8KRO5ViUQG2tgjKnjhDI3EsB1PYp77fGmNLAlgVsi9CE/VFwkhKDGR qp1DpNDICBS5pdcK4bQcmZL7fUJION6LVDmwDGigwu+yisY1Vuf+q6K4OfTbqgJ952 hKwGkCs6xWwXt8fSsK+kCQdD46SSC2g7/YGpdU1ocwRHep9p5XwdegjzXFbRypIukl BkpMhL9DosyJfIVzMAiQ/8b5/IzfsGR4sCnuo/yYMFaW1PIY8YjfCvSfUK6wZ/MJod rGiNHpNoxxi4A== Date: Thu, 1 Jun 2023 09:48:27 -0700 From: Jakub Kicinski To: Anjali Kulkarni Cc: "davem@davemloft.net" , Eric Dumazet , "pabeni@redhat.com" , Evgeniy Polyakov , Christian Brauner , "johannes@sipsolutions.net" , "ecree.xilinx@gmail.com" , "leon@kernel.org" , "keescook@chromium.org" , "socketcan@hartkopp.net" , "petrm@nvidia.com" , "linux-kernel@vger.kernel.org" , "netdev@vger.kernel.org" Subject: Re: [PATCH v4 5/6] connector/cn_proc: Performance improvements Message-ID: <20230601094827.60bd8db1@kernel.org> In-Reply-To: References: <20230331235528.1106675-1-anjali.k.kulkarni@oracle.com> <20230331235528.1106675-6-anjali.k.kulkarni@oracle.com> <20230601092533.05270ab1@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-7.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 1 Jun 2023 16:38:04 +0000 Anjali Kulkarni wrote: > > The #define FILTER and ifdefs around it need to go, this much I can > > tell you without understanding what it does :S We have the git history > > we don't need to keep dead code around. > > The FILTER option is for backwards compatibility for those who may be > using the proc connector today - so they do not need to immediately > switch to using the new method - the example just shows the old > method which does not break or need changes - do you still want me to > remove the FILTER? Is it possible to recode the sample so the format can be decided based on cmd line argument? To be honest samples are kinda dead, it'd be best if the code was rewritten to act as a selftest.