Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp1055880rwd; Thu, 1 Jun 2023 09:52:41 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7rwBNBbDPoKaDScSpL2xesjmFpUxcDFTym54twcLkd2iXYvpMjfpmUKxvDLOuvlCM1dKJI X-Received: by 2002:a05:6a21:980e:b0:104:ad71:f080 with SMTP id ue14-20020a056a21980e00b00104ad71f080mr5957188pzb.34.1685638360760; Thu, 01 Jun 2023 09:52:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1685638360; cv=none; d=google.com; s=arc-20160816; b=y78biHk7Rj/EnDz2dHOK6nPdX7Hm/EtSTqaWNhCrciiQY+y0UaGE9o71o5fqX7BWNo KXz/5U+Yps5F8O26lgoI83W9dztPTxNTJ/DKWjHNaGUGxHQ3p2hsZHzigvskEho8YX6K GbU6d1/HPz2nuS3YnOQXQSE+HpXhTFp+o939i6pF6Bm2yAvEQc57UozrY9DO6entol++ yaEg0qdLhpNYrddpFxYUHa1/ZzSrbIy1RD0olub2vo0vX6Jvw0oCNnqImp9WSBsMwtCn cg7zAab3XUGmD/SdLMiaGxTK8AleYVyZnycFOHIgsHO/D8TbhqcEc4CP43axbUqRzde2 V+Rg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:organization:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=Zmd7efuO5OHWzrLCDOo3rEkW6LkTVnh/NIwD9UJcQNA=; b=fNAN38vsy9Vi7+peBlA1GxxtwTpeU0pA6+7y6Nr+M4mKDoRV/WqZj48u8h2BHPyqPR MHPTPij9LJM8jOBX7acUcJF9OTwDliJGzScK8h+wvbdtST07K2llZV4ZV1E5imWDCUZL wnyECn1oTK9Wymd10F9ym9hQCrADlXVCKJZp5jbD7CERxgjBDVRQqO0TWOmaIsZge9M4 PO2DcwXoU7g4UFhGnTdywC/lR1Us/+Wk0sxEPq4dLJk0x+vi9bAPxJQbeKFqbFESErsF idboDkau62ifCxNzQ4qFfaEKoNKSB8mNHDK08ZHzqb0wfzumGSdMMFbzfri/ry9KnZxf D+Vg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=EMBV4H1u; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id h11-20020aa79f4b000000b00640f7f287dcsi1105579pfr.174.2023.06.01.09.52.28; Thu, 01 Jun 2023 09:52:40 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=EMBV4H1u; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231520AbjFAQrQ (ORCPT + 99 others); Thu, 1 Jun 2023 12:47:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59566 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231354AbjFAQrO (ORCPT ); Thu, 1 Jun 2023 12:47:14 -0400 Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1A060D1; Thu, 1 Jun 2023 09:47:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1685638034; x=1717174034; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=mwd7Xa2qyhdeHinpRyrfZnTV5zF/HG4nOp7b7yy8waE=; b=EMBV4H1ux5GDpre7NTiIDR0j0JvZDUXwsDWEyHnqOqXWEaHCCXjDWx+C aLykyR2AFd0pSNNAur2LEohK3hWNmuWMzo1oY+zJpZJkzIpzSzdZULDiH xzFjfF+MUxcOXZzAuFPgD+T3y1EQ45i5rm5GbVaIPaY/QutmQEnmO3gpX KpyPtKPn1nPX5aY6fW7TrNb+eee5cC6gHCHSaLlrCEzvJ2drJHmvO0YH0 DGMz5fdnX+6gkDR11qX1hbz4sh244tbFqSwFsLHXOXBgdxjsGMYvoEYwQ PFGNbaCiJe2lDfMC+9fMITwsT5ESK1Hp97aDg/+eQZdTOAdiGXlFHjAN0 g==; X-IronPort-AV: E=McAfee;i="6600,9927,10728"; a="353109928" X-IronPort-AV: E=Sophos;i="6.00,210,1681196400"; d="scan'208";a="353109928" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Jun 2023 09:47:13 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10728"; a="684920986" X-IronPort-AV: E=Sophos;i="6.00,210,1681196400"; d="scan'208";a="684920986" Received: from smile.fi.intel.com ([10.237.72.54]) by orsmga006.jf.intel.com with ESMTP; 01 Jun 2023 09:47:11 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1q4lS9-000Smc-1o; Thu, 01 Jun 2023 19:47:09 +0300 Date: Thu, 1 Jun 2023 19:47:09 +0300 From: Andy Shevchenko To: Henning Schild Cc: Pavel Machek , Lee Jones , Hans de Goede , Mark Gross , linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org, platform-driver-x86@vger.kernel.org Subject: Re: [PATCH v4 1/4] leds: simatic-ipc-leds-gpio: add terminating entries to gpio tables Message-ID: References: <20230524124628.32295-1-henning.schild@siemens.com> <20230524124628.32295-2-henning.schild@siemens.com> <20230530171100.75e5b86c@md1za8fc.ad001.siemens.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230530171100.75e5b86c@md1za8fc.ad001.siemens.net> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-Spam-Status: No, score=-4.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 30, 2023 at 05:11:00PM +0200, Henning Schild wrote: > Am Sat, 27 May 2023 11:54:08 +0300 > schrieb Andy Shevchenko : > > > On Wed, May 24, 2023 at 02:46:25PM +0200, Henning Schild wrote: > > > The entries do not seem to be stricly needed when the number of > > > entries is given via the number of LEDs. But adding them is a > > > safeguard should anyone ever iterate over the tables to their end, > > > it also gets us in line with other drivers that register > > > "leds-gpio" tables. > > > > Reported-by? > > Reviewed-by: Andy Shevchenko > > I think we could do > > Reported-by: Andy Shevchenko > > on merge. But i would not want to send the whole series again for that > one line. Since you added it, `b4` will happily take it, I believe no manual work even needed for that, thank you! -- With Best Regards, Andy Shevchenko