Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Anjali Kulkarni <anjali.k.kulkarni@oracle.com>
To:     Jakub Kicinski <kuba@kernel.org>
CC:     "davem@davemloft.net" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        "pabeni@redhat.com" <pabeni@redhat.com>,
        Evgeniy Polyakov <zbr@ioremap.net>,
        Christian Brauner <brauner@kernel.org>,
        "johannes@sipsolutions.net" <johannes@sipsolutions.net>,
        "ecree.xilinx@gmail.com" <ecree.xilinx@gmail.com>,
        "leon@kernel.org" <leon@kernel.org>,
        "keescook@chromium.org" <keescook@chromium.org>,
        "socketcan@hartkopp.net" <socketcan@hartkopp.net>,
        "petrm@nvidia.com" <petrm@nvidia.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [PATCH v4 5/6] connector/cn_proc: Performance improvements
Thread-Topic: [PATCH v4 5/6] connector/cn_proc: Performance improvements
Thread-Index: AQHZZCxMA20H0kIuSECLZNtWm5vHUK92gweAgAADfoA=
Date:   Thu, 1 Jun 2023 16:38:04 +0000
Message-ID: <B9B5E492-36A1-4ED5-97ED-1ED048F51FCF@oracle.com>
References: <20230331235528.1106675-1-anjali.k.kulkarni@oracle.com>
 <20230331235528.1106675-6-anjali.k.kulkarni@oracle.com>
 <20230601092533.05270ab1@kernel.org>
In-Reply-To: <20230601092533.05270ab1@kernel.org>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?/4ZhalhOb/CmXHmChgESaQKrmve4WqsTXQopXgCRZOe8xFzV6//ex2tqBo3c?=
 =?us-ascii?Q?fOSMI8fkamFZxLmKQtxDSy5hd/PMJwEqFFEm5DVYXx+DWNyaDnztI9LaVDth?=
 =?us-ascii?Q?0mK8/smG2wlneHimZhyMlY8Ce8R/1r8EYVhGQeQp8Z2a7ugyWaYWxCP3j/Zb?=
 =?us-ascii?Q?T0nbG97UCOal9kgoWe05OgJTzT8y0BV8c+W1rayrLgUQrsO4AeCTMBclzzyK?=
 =?us-ascii?Q?rynvQ/1R9RKOAZxj5RjtLTjmzhnkpy+dkcurv16X8f2OcUPuf+S+GD9NBGpr?=
 =?us-ascii?Q?3FWcCA/0GPPUt9xq2LeyAwc44Td1VnYLNNiQeRrVfj5LsOb8ad/Xz3Uxz4kI?=
 =?us-ascii?Q?Ho+wGX59kTquCc3pWvOF0nWqvOOkN38CUB/hYtUr8KNuQuzj5QhR9RJuJlpx?=
 =?us-ascii?Q?l+niehHJyiDFHsNdUh1KOCAWjJjcjiZCivMy7syL92VDhTl9YVirMzo+z//a?=
 =?us-ascii?Q?oK/AD1wtjfBy74gYbH60m0FIz891SyW/jiDNQEE1OazXDXD5d1bLjBHfc26+?=
 =?us-ascii?Q?X3Puf8p5Y2y67QInIPKv+cXddtvzWVKXDaFsdUxsy4pyT32dU/OQ4Jpqeema?=
 =?us-ascii?Q?cgW6cd+PsFvD4xrhgQtFd/6+CMk4mBc+FNoScWbChed9xYdsPvfQ/pJP3zwU?=
 =?us-ascii?Q?zNfZ3MzQSILlRRzuGNFFpkD/dUk/JTX5Tig4D0xuIzozg5cDAKFE0I48PPWW?=
 =?us-ascii?Q?zKqtfqhNt010Kd9btXLToufU7N/+/dfolDSgSlz+LRy4FeikY9Zxc8UalRre?=
 =?us-ascii?Q?sDeYhaCvmMmOYGcP0e3BbIswYsDY6ONRY5+My9pRLV3W14/VYbaOHXS/XNJR?=
 =?us-ascii?Q?//uHhYDr+2CtJlUq5mpnq+mTgkK7LaXoI8kTHXDtnUjDCTWTHHxwNc9HIJ0g?=
 =?us-ascii?Q?gU7qFxYF9rTsyhKHu3RYGkpZRbCYLViL0i2Zzdh77c0j9mmTxPV2qoxrSZOc?=
 =?us-ascii?Q?vnfIO27BXXu5r5vnwVC31V1nty5Rm3pth3N/q+U9B49YhkJQsWurlJL2VO8D?=
 =?us-ascii?Q?erJs3smRY2o98XIu3FSNYFXbnXJUkRoiv3XkiTwlmytG+MR3Hu0/X3wD+2CK?=
 =?us-ascii?Q?qsRyPY/uGXzAVqasOjgNOkr+w8AZElkH+b96CB0SXU2xvJNv/+/JOpiuP6JH?=
 =?us-ascii?Q?VHGqp1tHuRv8w/JqcScRDvuOtNXwwj9pIv1Dmu6wD9SdQ5d2XPSIBlQJPGAJ?=
 =?us-ascii?Q?UqAl3ugVTcAVoCerz1WoJgDj0WG+TqKMePYzLqpIDn5w1/6hGBxhWm5CxWpj?=
 =?us-ascii?Q?M+eHLC3HgwhwR99Nth3BUSPVl4dao4CJA6slfOgZa52ATwSm/466suBjQ8TJ?=
 =?us-ascii?Q?1xmceNRt5UcPxBjRUo0GH22qIeHNaId2ZCZZLIhlxJZ1zpKlA3RHoQrIoXGw?=
 =?us-ascii?Q?Sa58QIoiwyFZoDRH7HJWRyo+qKAHfoTUzOR4ZRuIKBuXUpVaRH+PI8yGXCQe?=
 =?us-ascii?Q?8mBLY707JSXcZ/hgVcBy9SVAcEEB5Vn74FSBnlIPyce/RWCGsOFTrn/nPrcy?=
 =?us-ascii?Q?uLmPHfOrVGZN9l4H29c35KQnR/2i0iABoSNqigDPxkWXd4f8KDOCH2HG+c10?=
 =?us-ascii?Q?Ea9T364nDN5+WUwIJHwmVbFVOXDkXwgaoSe0eSXk+RcjbhtthwKcUq+GAIhR?=
 =?us-ascii?Q?Vw=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <E4467883B049014DB2BBA336531C837F@namprd10.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?us-ascii?Q?Ii3gtfkR75dfq+VHuWRK+yrRrhZjOwJmh+8wvdAxOmB9RIvPsOMGP1o84fCq?=
 =?us-ascii?Q?cJUsk1t5VBIEhJY4ZEgQbiFHNjo5MNDt8uYUdAyRYS71uPERGYtQNmf4k8u4?=
 =?us-ascii?Q?9CPmPh6HpLBLt+0rPbUg3PxGzhUBi+ulCzMUhdUgTMGMHRh+g9OVy/W4ZR8F?=
 =?us-ascii?Q?xyv0PO3fgCl1iV3550NrsL2iHkV+AD69LKrBTNi0Oa/OHLFyWSbUZaEIurTf?=
 =?us-ascii?Q?KxXvx20sXn4s3YHDFPmsL4AKTr2k9cKm5wW9kSi76lSniKw8Y5vea+bmE6n5?=
 =?us-ascii?Q?b1mVzRgVBAFTYc5sGgCRjoZilyMxQYxaBrWx5FEsPK06wSi12eFPEMEHrH/A?=
 =?us-ascii?Q?RLEp6+f3vJ4Hy6pj3isekLWnZje4Fvm2Fjz9SOR74erKDgqMmdLiB1KdJPXO?=
 =?us-ascii?Q?/Ku+aAadwGqAb4ulX1HbEm9f+6XwVEkkYCUP0Z1UqlfxEciqrVaEeO5ifkoP?=
 =?us-ascii?Q?gSxSB3/+Phwz+O2qTEd6g1Xw8fyM9cvoiB/3ofPge4vNdtQMuefg2ltY/mZ4?=
 =?us-ascii?Q?BrZAnFzOaI1v5pfhrL+bjtMC6tCcyAh0dE5QzGm+vEj9oYzz0ydPwBcK1KHd?=
 =?us-ascii?Q?4fXDKnn5boQ3MouBtOCEoUtEP2UaDjcz2eJFkXMb6oz1jsR+5StBMlCe3IWv?=
 =?us-ascii?Q?Dx6dnhA3o8MusNfiX9VpapV2bbRvtzL430RvESNy8XfEto2FHESZChbVR198?=
 =?us-ascii?Q?e6q16Zun6dj0kq/+mc4f+N3UUlIoqJnWFEKIrg5vqzdnxEV+yshUgMhV/jrO?=
 =?us-ascii?Q?sb4IcG0IVgUhDyRp3LaQkTdgXSWHNNB2p+kgu1Kdmfn3oIVfzAE1gK7tUv0a?=
 =?us-ascii?Q?4eGkLtxTOzjTjvAHtoM9WUnpicNzcGk9ER/+w35ra3CRYt/gh5gf9MN+MEVH?=
 =?us-ascii?Q?OPD8vW8P5U7aIsfq0HkyMBcm6RuS8woOWBUOLPXbUeArzg/Kzrcjusfd0XsC?=
 =?us-ascii?Q?zx6o1BKVobcYFHOeiUZnAZ4UWOfWsj4kRU7CiuMAkGeITmVKpHK9CBa6kCC5?=
 =?us-ascii?Q?Qgu/z/8ewsRW0CVbhpEe43hQV62HhgN1lhwxluHb6wzy4PUEfuKXOMDrX1Bf?=
 =?us-ascii?Q?92HWId5AexnCGH5R1ADsMfWrP8dz7g=3D=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BY5PR10MB4129.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1fd5b240-27c6-44ee-0b3e-08db62be925e
X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Jun 2023 16:38:04.1763
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: ssftjggalYsIgjRd4uK8nsHuOa8iYFWp4MDsIvseRic9b7RHFu9qVVP6y+Jok+ecQT35b4RBqGSuze5gH5WjDxUQk/sK8MASscbIBDbCXWg=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR10MB7370
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.573,FMLib:17.11.176.26
 definitions=2023-06-01_08,2023-05-31_03,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 adultscore=0 spamscore=0
 phishscore=0 malwarescore=0 mlxlogscore=937 mlxscore=0 bulkscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2304280000
 definitions=main-2306010145
X-Proofpoint-GUID: KXf4nvLu58LR86ehq2WG8AII9adEyPLP
X-Proofpoint-ORIG-GUID: KXf4nvLu58LR86ehq2WG8AII9adEyPLP
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> On Jun 1, 2023, at 9:25 AM, Jakub Kicinski <kuba@kernel.org> wrote:
>=20
> On Fri, 31 Mar 2023 16:55:27 -0700 Anjali Kulkarni wrote:
>> +#define FILTER
>> +
>> +#ifdef FILTER
>> +#define NL_MESSAGE_SIZE (sizeof(struct nlmsghdr) + sizeof(struct cn_msg=
) + \
>> +			 sizeof(struct proc_input))
>> +#else
>> #define NL_MESSAGE_SIZE (sizeof(struct nlmsghdr) + sizeof(struct cn_msg)=
 + \
>> 			 sizeof(int))
>> +#endif
>=20
> The #define FILTER and ifdefs around it need to go, this much I can
> tell you without understanding what it does :S We have the git history
> we don't need to keep dead code around.

The FILTER option is for backwards compatibility for those who may be using=
 the proc connector today - so they do not need to immediately switch to us=
ing the new method - the example just shows the old method which does not b=
reak or need changes - do you still want me to remove the FILTER?=20

Anjali