Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Anjali Kulkarni <anjali.k.kulkarni@oracle.com>
To:     Jakub Kicinski <kuba@kernel.org>
CC:     "davem@davemloft.net" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        "pabeni@redhat.com" <pabeni@redhat.com>,
        Evgeniy Polyakov <zbr@ioremap.net>,
        Christian Brauner <brauner@kernel.org>,
        "johannes@sipsolutions.net" <johannes@sipsolutions.net>,
        "ecree.xilinx@gmail.com" <ecree.xilinx@gmail.com>,
        "leon@kernel.org" <leon@kernel.org>,
        "keescook@chromium.org" <keescook@chromium.org>,
        "socketcan@hartkopp.net" <socketcan@hartkopp.net>,
        "petrm@nvidia.com" <petrm@nvidia.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [PATCH v4 5/6] connector/cn_proc: Performance improvements
Thread-Topic: [PATCH v4 5/6] connector/cn_proc: Performance improvements
Thread-Index: AQHZZCxMA20H0kIuSECLZNtWm5vHUK92gweAgAADfoCAAALogIAAAUyA
Date:   Thu, 1 Jun 2023 16:53:07 +0000
Message-ID: <FD84A5B5-8C98-4796-8F69-5754C34D2172@oracle.com>
References: <20230331235528.1106675-1-anjali.k.kulkarni@oracle.com>
 <20230331235528.1106675-6-anjali.k.kulkarni@oracle.com>
 <20230601092533.05270ab1@kernel.org>
 <B9B5E492-36A1-4ED5-97ED-1ED048F51FCF@oracle.com>
 <20230601094827.60bd8db1@kernel.org>
In-Reply-To: <20230601094827.60bd8db1@kernel.org>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?aVd0qqWucvIDUnxWpp2NG6B60JaT79rGIBfwCqREi63BODmbgDNya70O1Wcb?=
 =?us-ascii?Q?KqzfuFoZYe9JqXUMPsfs+1RUrIbR5QQCE8V1EufzSEZnf9CEE0Is54ORc6Dh?=
 =?us-ascii?Q?fV0Cyuqu6/O3cpXBDc66uh4cylvbNf6ir0KJ4t/P3KRzHawCnLn/85O9MGnY?=
 =?us-ascii?Q?HSozos4Kex9YRWOsbz6xw0S6K3HaCCdtY2E+MoVPDXzaJ5/Xkz61VLDlzXmV?=
 =?us-ascii?Q?KckQHGuwv2EfhOdrNPxLs6vWoRcc9OA9hqqik7hjmT9drZfDb04G+QOXq+YH?=
 =?us-ascii?Q?w+L22d2Wl76aoJWHlAV5PsdcOO/PBVrmBALb4llv3GNQ9wHEUJHbXydQWoVJ?=
 =?us-ascii?Q?ubi6NazKuC5v8UafEl+PxQi9vpZ3ox956BXUmKkF2+l3IvMVYpUoVvSx8Eic?=
 =?us-ascii?Q?cb8WRZqJXePIU0IowyT66FpDokz9gnQq4HMBF6jh8O1Y3wxIJFpGUGnVLFhF?=
 =?us-ascii?Q?KZREsnSQJHuzpiyggJIZR1Ivxd9cDEK/GY0DdYI4RB76GvpdwYGgRiodUrBx?=
 =?us-ascii?Q?e/AWqkrzxOShv2NOVgYDMkJOCpuyUIV9Cbzw/elOos09tm8EWVBLkg9PlKUn?=
 =?us-ascii?Q?du3Ah9bfVQLna7Lmog6fDam/miQIdWKRycra17cufnuRAO70VuOmrnTwoEgz?=
 =?us-ascii?Q?q5JyfRqnYD+fZrsGBg5ympdCEsBl6LdXmVqtjDdcn3LVBzEwPkeijX08OnOq?=
 =?us-ascii?Q?Hul8PKek7i3/cuTyyLk5efnEwEWUMUOJq+SgxDTj/gEWETdQkrkDjH52G3il?=
 =?us-ascii?Q?Y/pFAX/BE6wfcWYjok5sbyy7Vih7t11Fu2MOxVAYXERNH+0r770rxvLlJsqE?=
 =?us-ascii?Q?/FQqdscygUh780Po8HRGzwYxSDCEBDtq5G1weqYtoJnpX+FsTzNP8Dv5yUgP?=
 =?us-ascii?Q?YxPMYMLP41u0wq7q2Xvu0VZrEqVhDiUfwWAU7smN9NvsSq8NO5p+vC9hfXbu?=
 =?us-ascii?Q?Jlq29n1MaQuYf31wC5BfajhhPTpSil2WDBysfGMNnaWeMJ7XutdHBTAr9S1+?=
 =?us-ascii?Q?thdiVG3DRUuKqwYewC9ngcErTwT3rLpGZIsnj+koEoHYRE4ru8mKe5s+ApmP?=
 =?us-ascii?Q?5BWeD0QPUKyyEtcUKvZi3JTwrbvQWAEGxlv94dFWgzpBi20IAXxBXJawYtXM?=
 =?us-ascii?Q?f74tFDzkHH7BGJdy0g8vE+/hGOyE0n+cein/g2jH+qj5iZASCXVHnuWR/zdF?=
 =?us-ascii?Q?XzHpQnmWVrcb60w9mt4XrXVJTWAXKizkWfUBEF4IWddjZTj4M9X7EgAxfNGo?=
 =?us-ascii?Q?5MP4bcz0JQP7E5HiMf18rSE+V7tab/s6yNn2vAc0wmM7YsGxoFT8T1u84DwL?=
 =?us-ascii?Q?bCs2I4RfOMB8s5BRJX5LJPczpRh/K8MrAejlPgyXhbk371ojFZCLrAPg+Dq8?=
 =?us-ascii?Q?5zoZRD9P7b/r8E7DrcyRlABMoUg9tpquMKGyN1kASc54i2F3PBNkYIlPbz7V?=
 =?us-ascii?Q?t8np2RTD8ThPq1HAGvZ37i80yeTCcU4d2AfnVliPGFhJIbUnCtnBotWW1tqY?=
 =?us-ascii?Q?Cxc4+w4yPg1q4EBGfcec9Cqd/dw5k+tt879BLtmpcENrVQnbkDbVDaVlIdkA?=
 =?us-ascii?Q?3+J3DDHS3clz/PJ2ctgoDARvmVdS44L5EBOF429nzOC5/yfK18PK1bTxEIFM?=
 =?us-ascii?Q?/Q=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <7F11A43F1032EE46930BEFB8455F098F@namprd10.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?us-ascii?Q?GOL4MRLzlg7zBBCOJB3m46COyLcDSlGk9fxPls3qYbjj3si+1mTgVas2j8V4?=
 =?us-ascii?Q?nucv7Zlvzls9jo7kSHgJV2pCO9K5BF++0qJvxOixFRrhKDH5+rDAjzK1mdK8?=
 =?us-ascii?Q?VmCzUhA1GeQpCM02eKWmPwLkU0WT2HnWa8YfBN+Ebvk3Vs1bHCcdsxJtSIF8?=
 =?us-ascii?Q?qC1iVU+UtlDPV0/8EwEjx1rFklZdESjGbi8bzHSQM9Z9K8vavxsWzPPHV5rU?=
 =?us-ascii?Q?RNlGFYW1rQu2jYi9GHGvTIXOcoYxk2xfwGMxhFotZbO1Lt8HdFXCC1LZj0Dt?=
 =?us-ascii?Q?pSs5bseOaT2Mylv3cdvD5u3IDuibrMCETtDeplEvewiStdE4+pLZFFgYTJfj?=
 =?us-ascii?Q?Tnyf5zZ04bdUA2MMxpX6yn6u9BReDYOKH0Y8JST9ZtmekHJ34OcrNb9Do0QU?=
 =?us-ascii?Q?LAlFJgtotEskKYuGIRPQ2k5sHEMpOOeSUmrzV2aBlL6bTKG2ijU2f7e0aCbf?=
 =?us-ascii?Q?3c5OONGQ5+FJ59wbn8Pzt24mTSvGsvFeP+NFXdtXjmszT9xZzXIIJlDEFGcU?=
 =?us-ascii?Q?qkZedkQFjTyQrn8ZtyMTDzOnzxtlVC89ESW8mzukILI0XjQnb4+c8aonkZKY?=
 =?us-ascii?Q?xchnbk9It/7MrG3p631Wkf/ni/tjfMoK7wX9+WYr++LpJ0MobxeLezdnySb/?=
 =?us-ascii?Q?tPIXY93GZXrNnjU2tL1GnLQpkPb+xzhnb6RpUSfpMeu8b8CPve7N2r84cYrA?=
 =?us-ascii?Q?gcGBGe4gIJscgx7/NROyk9ElBdsK7TDzOICahqacClPNKnCe0WBB3dR0z6MU?=
 =?us-ascii?Q?XvKYsrcPqTeXy3Z+8pxjCZqwezDSeQwLQa84X1xQHHZP0uqLL52GU5Zo/fI0?=
 =?us-ascii?Q?FWjAniVJViWdaCGwpPTepHbVXpVnzdqBxPu50avR1AITkVpgmOos/H7nZL/v?=
 =?us-ascii?Q?3if8csdYhFnuPD8kC/ymq2WUeBC+A84SQZkZKYDBINmOBC5Ij+1ReRgHdRZb?=
 =?us-ascii?Q?HbilOSHo6mD1tCu6a7FBcdW7oKxQqK4vJjpscuTuJgk2SP9j5XrjdE6wrxMg?=
 =?us-ascii?Q?kSGkVAZdBdaPKU/RYvnD4X72VDRX8jwb7q+MFrL04DdU6IU+FsJFVqcqz7Nw?=
 =?us-ascii?Q?9/dQu6mRNvh6dkNZjGqoEJAuCyTMhg=3D=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BY5PR10MB4129.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 786067d8-8743-44c8-10f7-08db62c0ac93
X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Jun 2023 16:53:07.1357
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: qJj9awBO87t5/kSyphjYlm8GW6NiwEoossVnS3PByCBroldKujMMzw/Os9eeVPyrNG5S8gXrWxZQxgSHKSa7hFsy7foHX/8hy0NK9+0whU0=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR10MB6818
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.573,FMLib:17.11.176.26
 definitions=2023-06-01_08,2023-05-31_03,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 phishscore=0 spamscore=0
 adultscore=0 mlxlogscore=764 bulkscore=0 malwarescore=0 mlxscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2304280000
 definitions=main-2306010146
X-Proofpoint-GUID: 74LDKp-bZtm7iiJyPjtRjMoMagSy2mKI
X-Proofpoint-ORIG-GUID: 74LDKp-bZtm7iiJyPjtRjMoMagSy2mKI
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> On Jun 1, 2023, at 9:48 AM, Jakub Kicinski <kuba@kernel.org> wrote:
>=20
> On Thu, 1 Jun 2023 16:38:04 +0000 Anjali Kulkarni wrote:
>>> The #define FILTER and ifdefs around it need to go, this much I can
>>> tell you without understanding what it does :S We have the git history
>>> we don't need to keep dead code around. =20
>>=20
>> The FILTER option is for backwards compatibility for those who may be
>> using the proc connector today - so they do not need to immediately
>> switch to using the new method - the example just shows the old
>> method which does not break or need changes - do you still want me to
>> remove the FILTER?=20
>=20
> Is it possible to recode the sample so the format can be decided based
> on cmd line argument? To be honest samples are kinda dead, it'd be best
> if the code was rewritten to act as a selftest.

Yes, I can recode to use a cmd line argument. Where would a selftest be com=
mitted? This is kind of a self test in the sense that this is working code =
 to test the other kernel code. What else is needed to make it a selftest?

Anjali