Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <da7bd23e-e860-9569-bd29-4f63add710c0@intel.com>
Date:   Thu, 1 Jun 2023 10:14:28 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Firefox/102.0 Thunderbird/102.11.0
Subject: Re: [PATCH v1 3/9] x86/resctrl: Add resctrl_mbm_flush_cpu() to
 collect CPUs' MBM events
Content-Language: en-US
To:     Peter Newman <peternewman@google.com>
CC:     Fenghua Yu <fenghua.yu@intel.com>, Babu Moger <babu.moger@amd.com>,
        "Thomas Gleixner" <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>,
        "Borislav Petkov" <bp@alien8.de>,
        Dave Hansen <dave.hansen@linux.intel.com>, <x86@kernel.org>,
        "H. Peter Anvin" <hpa@zytor.com>,
        Stephane Eranian <eranian@google.com>,
        James Morse <james.morse@arm.com>,
        <linux-kernel@vger.kernel.org>, <linux-kselftest@vger.kernel.org>
References: <20230421141723.2405942-1-peternewman@google.com>
 <20230421141723.2405942-4-peternewman@google.com>
 <38b9e6df-cccd-a745-da4a-1d1a0ec86ff3@intel.com>
 <CALPaoChcra+qJd9ETQT+nZ17ahH0RCCarjuT3jn8EyzV2HyCbw@mail.gmail.com>
From:   Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <CALPaoChcra+qJd9ETQT+nZ17ahH0RCCarjuT3jn8EyzV2HyCbw@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RjVWSml5ZkhmdURkVk5FaHppUjR3eHp2RlpvckpYQjhYd2ZUemx4MGh1OFda?=
 =?utf-8?B?UVE3cUlaNzBvTlZ5OXBRSUNLRTk5cTBTSzVLS3RBOE1nc2pXNnk0V1dkZzBn?=
 =?utf-8?B?OTdxdlJJUXpsYWlIS0FmNmM0Y28vL0RhNVZXSGhza3VuYmwxdFpTWjRzekkv?=
 =?utf-8?B?bzl5Ymx4QVdQMzZlMEJJdm4wUzZrZ0ZjbmlDZGUyLzNVVG1kYnk4RFVRME14?=
 =?utf-8?B?N0V3Mm9WaGVkcWF5cnVBLzV2ZHdPSnhKekpWV2EvMytjSnluK0pZUmV5SHMr?=
 =?utf-8?B?d1RTZUVnZDBIc1lPVzg2QWcrZHplVnpiVEdIVHNyeUNza2VIZ09Vc0NIQXZ1?=
 =?utf-8?B?bmlWQkJQWE9CZ1oxN0dCM0huTkk0SGM4eUJRVVNHWE9UbGRwZldoRTAyUmc4?=
 =?utf-8?B?eTdsYjJxNUd0RERzb1BGTCtLb2RueDR3TEFyM0xlYXNZV1Q0YStDVkgwWC96?=
 =?utf-8?B?Y0hoMHNCV21rR2wwaFJ3bFcxOGdpTTFzRmNsY1h6TnU2QjA0Z2Z0VlBhdElh?=
 =?utf-8?B?bWw0cGoxUlBUY3cwcW5wdkh0NXpSQlRqN0Y5bFVQSS9oSW82V1pnd3JPQ2lk?=
 =?utf-8?B?Wi9Ib2FmeFNKSU82R016OGZtZ2FSV3FWVnBwOUZMUFpVQmlzRnZ3aFRodjNN?=
 =?utf-8?B?M2FWemRZUGcyeGlYZ1lmaGVQamcvZVVUZGVkV2tNZEpnQm40RC81WWM1NW1S?=
 =?utf-8?B?YzZRQkJxM3BQMFR3WVdwOXdVZTVxNnhkOTF3WFJBbDF3MURRSEVLMDlyVkhh?=
 =?utf-8?B?Z2MvRHJsZjZ0VnI2WEg3THN6VzBKU0FDYjNKbkx5dTdXaGN2VHRIa0hGMC9S?=
 =?utf-8?B?VzVHTk1WbVhGY1FVOEtHUWV5VHhVWWZ1Wk9lc3VOTVVKdnVRaW82WDhlK0pH?=
 =?utf-8?B?bGtUd3plMnBsN0lWS0E2VWMxdVExRzFkZ1pUSWtHMU5mRUxta0FuSXhxcDNQ?=
 =?utf-8?B?dkIybnlNRGd2K3dScDR4RkJON21RYnpWVkYzcGpob2pxQlBEazFrWlNwUWpa?=
 =?utf-8?B?bDJGZmc2Zk1DRWlxQVBJeGxseUY3R3VaTTh5ZWN0TVIwSDB3SHdHMVpzVkVy?=
 =?utf-8?B?VkFiRXAvZC9aZnZDNkxqRUlzNCtMTGtDT0VFdkNrRmxmakc5QzY0TkdFNFJ6?=
 =?utf-8?B?a3p2RnJmM2t3U2RxSjdXYlQ5WGI4cGlkdGZtVlBSOGxoKy9UYWdIbnB1SFNo?=
 =?utf-8?B?R0pmZTJ0VmFXcFc4NzVReGc0cFFYWnczRFJ6ZU9oYVowTDEraURNQWh5bDNY?=
 =?utf-8?B?UWZEM1FBbXpIMFc5NTg1T09oNUo1VzJVUmMrbGt4czN4VlU5dEpUUVNTcmQw?=
 =?utf-8?B?SGQ4T0tndS9QOXVFZ1N5NUJsVFYyeVlNZ2VuVzRYWWRtazRmV3hocTF2ZzY5?=
 =?utf-8?B?V3V1cXpQQjBMQUxlMzNZN1Z4L0hrdkdjZVFTZ0paWGNQUHZnNVhJUnVieW9q?=
 =?utf-8?B?RDM0VjQzNWdLeWgzang5QVVJTFBaaGpPUGJvc25Sb1BnSERsNEhVWEZZVDdQ?=
 =?utf-8?B?T0FjYTBab1pON0RHajN4dEJBV1BsSlJacWpFaFBCLzdvUkk5Z1VablNjZW9E?=
 =?utf-8?B?eGxkbm9oUXl1aWJrVnk2cGdieXk4Uk1WZmtadGJPQkxHcWNSd0h1dERKMmov?=
 =?utf-8?B?OXRqNUdFTDQvVzNKNkVtSi9IQzNGY3Y4TjAyVUlVRWtHTW5MazBLaGt0M1Jv?=
 =?utf-8?B?SjJPOHZxZ3pwekozQVBJM3BFanozTDBMcWg4OXg4dGtYKzZISVZIZ252ZEtp?=
 =?utf-8?B?MUZMQm1GcG1PRjZwT0RNSkJpZlVYNnpFRzZsRlN6di91WklkYzNlOWhVNmdt?=
 =?utf-8?B?WGlBQzY2UnVtRHMxNWRQaERzVHNXY3VJMStiNVdtUTBvN2NPQTdQb2pQRzlo?=
 =?utf-8?B?bytlT2VReWFWdzFWdmYyMFA5WmdVdjFXSGtWTnUxeXJXYS9GZkcxbC9jcWcx?=
 =?utf-8?B?OUxIamhkK0VwL3NxdlBvMG95Z3FlUzFCZmxVSlVNWnBXTjVhcTY1Vko1SW1h?=
 =?utf-8?B?Y1hhSlV1TDRLMDJDVm9BNnQ4eStPOTNhdHNHQXNzampEYk5wa0pubmU5ME10?=
 =?utf-8?B?NmJocWpPREZvbDlkNmpUL0ZBZTYxU0Q5NHg0K2dVOXVyeVJpWVJhWGtyWjBs?=
 =?utf-8?B?N3ZpbDcwbjF6ZHMrZUVidHhmekd6THdnWWVaaXJML1paUXN0ZEtpaUdUTGs0?=
 =?utf-8?B?VFE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 4a0d28e4-2e3f-4624-a0a3-08db62c3acad
X-MS-Exchange-CrossTenant-AuthSource: SN7PR11MB7566.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Jun 2023 17:14:36.1719
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: MeltbwwD4DSd50bSUy0t5OFKd0qSGjPuOo/qhUobLVv6oONbTOcvVX52sDgQiG5bNJ6vIWfucAi0PNCObL6QvQ17EZdrcX0/qQppAEzGMEM=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM8PR11MB5669
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Peter,

On 6/1/2023 7:45 AM, Peter Newman wrote:
> Hi Reinette,
> 
> On Thu, May 11, 2023 at 11:37 PM Reinette Chatre
> <reinette.chatre@intel.com> wrote:
>> On 4/21/2023 7:17 AM, Peter Newman wrote:
>>> +     /* Count bandwidth after the first successful counter read. */
>>> +     if (counter->initialized) {
>>> +             /* Assume that mbm_update() will prevent double-overflows. */
>>> +             if (val != counter->prev_bytes)
>>> +                     atomic64_add(val - counter->prev_bytes,
>>> +                                  &m->soft_rmid_bytes);
>>> +     } else {
>>> +             counter->initialized = true;
>>> +     }
>>> +
>>> +     counter->prev_bytes = val;
>>
>> I notice a lot of similarities between the above and the software controller,
>> see mbm_bw_count().
> 
> I see the "a=now(); a-b; b=a;" and the not handling overflow parts
> being similar, but the use of the initialized flag seems quite
> different from delta_comp.
> 
> Also mbm_state is on the arch-independent side and the new code is
> going to the arch-dependent side, so it wouldn't be convenient to try
> to use the mbm_bw structures for this.
> 
> From this, I don't think trying to reuse this is worth it unless you
> have other suggestions.

At this time I am staring at mbm_state->prev_bw_bytes and mbm_soft_counter->prev_bytes
and concerned about how much confusion this would generate. Considering the
pending changes to data structures I hope this would be clear then.

Reinette