Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 1 Jun 2023 14:22:51 -0300
From:   Jason Gunthorpe <jgg@nvidia.com>
To:     Li Zhijian <lizhijian@fujitsu.com>
Cc:     haris.iqbal@ionos.com, jinpu.wang@ionos.com,
        linux-rdma@vger.kernel.org, leon@kernel.org,
        guoqing.jiang@linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH for-next v3 0/3] RDMA/rtrs: bugfix and cleanups
Message-ID: <ZHjT64eBLGDW9lvr@nvidia.com>
References: <1682384563-2-1-git-send-email-lizhijian@fujitsu.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1682384563-2-1-git-send-email-lizhijian@fujitsu.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?OSc6uWlNVKhBdAmGdozs7e8xNbQgDGJ3iJXqvkfWebgKC46zmnoZDETjRyKM?=
 =?us-ascii?Q?u2NaQeEwAkrlABp5x9N2ytEi4p7cUYP5A/aPjEVlyzVgWFtI9bmex6E1tISa?=
 =?us-ascii?Q?em/CBZxs4mWd6PTJLBC+9903jmyEY8/+2RGeemE46Twq0RTYDqTHWSD5tydz?=
 =?us-ascii?Q?4XTDmJvnIbSr8tPuu60FSCivFm5m2d+sSUJ1spkODw/5beVfwW1yJZd/Nghm?=
 =?us-ascii?Q?kbuy6e0GBIKWYeoDNCG+SYf56MhWcRSiUSDFbpeGwbQGP/+w2ouFam4XzveQ?=
 =?us-ascii?Q?N1hWzQeQRDzARUFTzSbNUme1tYGwETQhaHdtdLge2l07ObHmuwEjQDMWgGa5?=
 =?us-ascii?Q?MNR6R94XiZlCiW/EWBuNhYlhKCyfdidGK6k2/qE4DFO+fLGkFoaqsgZm1tK0?=
 =?us-ascii?Q?Kv1zt1NcEhZQAJ52zI89g5AFrellWfrVNLx1Pb3HkSkmdFqgjlwxNLuDYVAL?=
 =?us-ascii?Q?oIKQQO0x0OXH3dU5ekyaoJmu00jv/RIQ7R+gPmS84TididEmWjKkNc3EDrtq?=
 =?us-ascii?Q?jIprDJF6+CcLL9G/BvGxpFT1PZQ6+xEay0YuvfpqJ1Yx6iFf23s0ATNb/AE7?=
 =?us-ascii?Q?JlCKWoLQMaB5cSt5PB3EpGtmLIELbBAvDVxvefGpGetc6gilpJoDYp2cKNq4?=
 =?us-ascii?Q?o0y+1CQqnJmB6EEzeYMqxuxvHLLPtf7vAfW3o7mGrszGnjn3MtOgvjGQp+My?=
 =?us-ascii?Q?b8DKLsJUSSZ7Ic8SHk7HDVxF0jmiMYeVc/MPFR62DwZsM3e4gg+rI9WtCxXF?=
 =?us-ascii?Q?S+tLr1Icj3mdEB4vWYsSso8OsDN1tqJyzZxqVFE0u02DHO+F3ALJjSp34d93?=
 =?us-ascii?Q?ZwLHIr0/FfXqQFG9cHqDtiIwvaSE/+j4l1isEfAE5ve6FDFNLG97WXRtY97e?=
 =?us-ascii?Q?mMr+5diO2WjMfIw0NApNNYaKuEal3d3u2eqE82Dr+z8ezmzWMrpX0PRL+Ipp?=
 =?us-ascii?Q?dxRBdvUOmocGiZOZsNawOdctSX6I5Nu5ZJcejfuk+Dbd9BOPJcFB75vJGoKq?=
 =?us-ascii?Q?emABMcmR/OLgMg2BrCLwASuLeiitXKuFhsyeRxbVBGdjZhvoEjSV2YRgmye+?=
 =?us-ascii?Q?ME0+/f9yiVYEBeHoKxEsq0hiFXPAVKe7Yeyvb6hMc9bMJ5ck9WffRad7Esx9?=
 =?us-ascii?Q?EEFL4QJ68Eyvb4VjqZrG864SmHdwLpKMmn8SRZeCYHjeRIwxiq0lCVVSFi6y?=
 =?us-ascii?Q?Sgs0zZcjM1QbA2wxzoLjTsjdUvkJHYLDEf/R+P5L4N34JBpmOLzFTE4EaQ4D?=
 =?us-ascii?Q?NSiC7rEMPJQ59QoPVY++IkCMWgSv4gqlFS39MUfuB+lXc5TmiDmpwIRpf/pn?=
 =?us-ascii?Q?FEC+g5x6OqV7yG7UmsZbED3HU5+WZBnGQXz+UNOZ6BtqQ6Nu4+sglsTZQ7+i?=
 =?us-ascii?Q?ugOV8B7ntod4fGcjeqw7bzo/MlEJHSbiculy1ewP79dEVJgcIgQtOC04gtlj?=
 =?us-ascii?Q?Sc8aILKKgOOXeNLcHve8sI+w1uGLfnzzu+2bDPddV0vG+qx44fPuZbVmPQY8?=
 =?us-ascii?Q?tjL4RJd3UPKlEUO+L2o66SOrpMr8zbhtvGzTIMOlJX3PX9y8qET7qXUK3vFv?=
 =?us-ascii?Q?Lu8Lb6HJ6HiYq9XHFoUX6f5op9O2TsF0E7tGAzsM?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4c9923df-b6bd-417a-a57a-08db62c4d571
X-MS-Exchange-CrossTenant-AuthSource: LV2PR12MB5869.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Jun 2023 17:22:54.0623
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: hm2t02EnoJC68bxOfiCc0pn6s9cir+O0pNnVx9LE2J5xkGFFF7ENjP11B3f4vaz2
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ2PR12MB9163
X-Spam-Status: No, score=-1.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Apr 25, 2023 at 01:02:40AM +0000, Li Zhijian wrote:
> V3:
>  - minor comments fixes and add tags
> 
> V2:
> - Add new patch2 to fix a memory leak
> - rewrite original patch2 to patch3 by refactoring the cleanup path instead of
>   introducing a new flag
> - Drop original patch3: RDMA/rtrs: Fix use-after-free in rtrs_clt_rdma_cm_handler
>   The problem it tried to addressing doesn't appear after the new patch3
>   where it adjust the cleanup order
> 
> It's trying to fix 1 issue triggered by the following script which
> connect/disconnect rnbd frequently.
> 
> # cat rnbd-self.sh 
> #!/bin/bash
> 
> /root/rpma/tools/config_softroce.sh eth0
> modprobe rnbd_server
> modprobe rnbd_client
> 
> while true;
> do
>         echo "sessname=xyz path=ip:<server-ip> device_path=/dev/nvme0n1" > /sys/devices/virtual/rnbd-client/ctl/map_device
>         for i in /sys/block/rnbd*/rnbd/unmap_device
>         do
>                 echo "normal" > $i
>         done
> done
> 
> Li Zhijian (3):
>   RDMA/rtrs: remove duplicate cq_num assignment

I took this to for-next

>   RDMA/rtrs: Fix the last iu->buf leak in err path
>   RDMA/rtrs: Fix rxe_dealloc_pd warning

And these to for-rc

Thanks,
Jason