Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 1 Jun 2023 13:59:10 -0400
From:   "Liam R. Howlett" <Liam.Howlett@Oracle.com>
To:     Anjali Kulkarni <anjali.k.kulkarni@oracle.com>
Cc:     davem@davemloft.net, david@fries.net, edumazet@google.com,
        kuba@kernel.org, pabeni@redhat.com, zbr@ioremap.net,
        brauner@kernel.org, johannes@sipsolutions.net,
        ecree.xilinx@gmail.com, leon@kernel.org, keescook@chromium.org,
        socketcan@hartkopp.net, petrm@nvidia.com,
        linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH v5 2/6] netlink: Add new netlink_release function
Message-ID: <20230601175910.k2qdgidki7saqp7v@revolver>
References: <20230420202709.3207243-1-anjali.k.kulkarni@oracle.com>
 <20230420202709.3207243-3-anjali.k.kulkarni@oracle.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230420202709.3207243-3-anjali.k.kulkarni@oracle.com>
User-Agent: NeoMutt/20220429
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?grxGTObONEShzcwS/sOW7nVwgN7MjyMmrlVTJWdilWRzB4mlU8NLv3zlWnSK?=
 =?us-ascii?Q?cCuaddLT/yA4i+ivnUm9iXBTcm2O/LK3UZYBgICYDpqxOhNAAsFKMDeioL1U?=
 =?us-ascii?Q?Ibqg2S11pZ8q3l0ODSK41oBvCNbesTU8f0A06LUXA8kB+2NpU0Ne+DCN3bJS?=
 =?us-ascii?Q?/o8+fhtWYR3+xDcztluBlo0ZvMW8shfQTMkMh93tA/bmcPwlw6rnphaNRh3v?=
 =?us-ascii?Q?hWiBjzuMSh7X74eb5iTlP7o2y0QtqyEV3MBI07Rh89x5FNUi8I7S30kIaVzW?=
 =?us-ascii?Q?AosgqxF+OVRexXCDYU4v1gklXhDG7NUupf7XI7jCnRZn0SBPSO3u4V+0pWvj?=
 =?us-ascii?Q?E+fiKb9Obmrk9WGYR2io+dnb4LcHPg0oIKSFWWuq0brQKh/1Ss15xutBrE2o?=
 =?us-ascii?Q?CXGG5WACJHl9VmoNfeuJ/cg9oUFjs6k7K8BjucIaJmTmiyAJxLExrmdaSmR2?=
 =?us-ascii?Q?CmwcvLysvYI8HxIkC2eSDmRliXbpPXYnppW3/lI9zE1j6rl5YAp2/5pz++PD?=
 =?us-ascii?Q?RFZOusdHz1jB/tjLrzilQI+NSFRFvGag1lguCdd1fGQ6HdmqYvChu+gBl+Fi?=
 =?us-ascii?Q?cpsQA79wsHWjyROq3PwC8IwPPKOgbE4meDMEsD76rDGCHmC1BQ6/a9aurlXb?=
 =?us-ascii?Q?yMQvcu8JOnQgKnCgoXG7qarmpfWoDJ5dD0AjcsCsVnrUiGpxaGnoYD7stZZb?=
 =?us-ascii?Q?qE4p7ExYOA0goyLLVLNFKu2aro6VI1RQ4pT4b5PKqts3KidMYhTeoXucLfxC?=
 =?us-ascii?Q?BUmrV7n3uV2Sj7/WfRzbLUB9SvSCsj9SOLFiRBH7vYnRcu3Mqsv1IBde91AJ?=
 =?us-ascii?Q?s6T0lZX3JY3ua6P9ORqiN90S45Vt8ZmzwpuT6nCa4kX/03bZc7S+CHUJpCYM?=
 =?us-ascii?Q?R77qRTKm88oiVCf6NLiqGs8JK/2lQTmr1yLY19z1OhhvubyP54TCPtUIDtgM?=
 =?us-ascii?Q?o8eZ08VCy+jMl0UP+1PSzqktiAbHTS1BvELDX102tKf43fepqThEZwYfM5Xs?=
 =?us-ascii?Q?bPhEa4D09IGnISRC5k6hx2BBsqbYgZxcOS0/hnkvyFiqOWX1g0jJmGJAn6Tm?=
 =?us-ascii?Q?sebltjigj4t9NHOUt6Nk4O+meSzBE7gYjqgTtsQb0ICCHrnGUIRgiJmJMEf7?=
 =?us-ascii?Q?JWoNfVmOTWPkkyG4wPbT/IzBiBlEMx3U0eV4Do/oFGqpBajQd6Ldg8YQA/bB?=
 =?us-ascii?Q?omqziZYjnuUcXfY4HmCczpM8HF6CPe6bh202IbdA+ZMwqKloLrK/a61EL3Tf?=
 =?us-ascii?Q?STA47S7DpWxKdsteWaLNRz7sHRRf1XutYozGf8nybyfvDtwhZT/YD50w+vrU?=
 =?us-ascii?Q?Now+rg7fwPoxs5XHQiIH/9ivu24Xgdbwiky/oyo2zkVDbEYffaSFoAvDnnsf?=
 =?us-ascii?Q?WsBOcamdK1mFFKuNuwtDul4L3+tqNQb87hDp5Jtzaq367l9TCnHkqzb3zz+m?=
 =?us-ascii?Q?B2OHs936cbbEx9wRxgTcFoq/79NvFEWiCL6akFBBBjx8uJ44iO2t+u9n+GqO?=
 =?us-ascii?Q?S1NzHlJ1KB2qRF/dHkJ2OltOWp3PX9RnOwyHPRvl7tQgRaJ20MSQSd8XL1HV?=
 =?us-ascii?Q?t5Whu7I2YR2Cajbd/dx2TB1REYlYd2jHBWqOg4Ti1C+x4cH3oHE9QzU1LQX2?=
 =?us-ascii?Q?Cg=3D=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?us-ascii?Q?tjc7sBGNGO6hsVFJ8qJszCajF9oUEBDB77V5mVMeQb5ABk98GCk/aRKn5vnD?=
 =?us-ascii?Q?G6VuICNb9xgk3nR+sILhhihCEg2YIvUeeAmWWwKS4OdpULxd/KVWGQJ+HOZj?=
 =?us-ascii?Q?TeFQjlY+XlDUQMkS91yadUK0HZmmbCmbPvuBjmaz8AvBqvXiFWgfH8F1FeiQ?=
 =?us-ascii?Q?8ivQRFO+Q/Z/bJ93GyeAVVI6htYos0AFrCKHrPF86RL5qwsg80A5MI5zQeWj?=
 =?us-ascii?Q?S48BZfUxntVQMaP4NW2aE+advXqIjpiYUr3ryzlw8t2loyXjkziDlXUUAMgj?=
 =?us-ascii?Q?rZBg7QgPMp9kYklaIXBS3liL04mD/monmbZB7cr/qNqiuB5GoRubUSB23+xx?=
 =?us-ascii?Q?gUuS56Tl6AVzte4ZEvd1ZWcnNyPMRxxwCzuXzCg8m2iW6fv0V20HGQEQ6Zo1?=
 =?us-ascii?Q?zr37Mky/mtVLR1nIEzs1dgbLnjS19WvIjnNL2+KgzFuBLR9XMYqf5srzjRHD?=
 =?us-ascii?Q?7AFbhrnQEPwRE1P9RsMjvpFpcy6Z/K2UIZ6GakTmddEWFsjYCRtf9PhlMscN?=
 =?us-ascii?Q?DEYoDWlTGGc3fvTWf0MXbgG2BQ2S3S1pP5oYntS3Iu14tEGJ7N3aJGa0RsyC?=
 =?us-ascii?Q?GUWLbPDCB4DH2S6LxFsrO0ob6HfKGlF6x70KsYtvkbPXgWrKXqgRjEm+qjj3?=
 =?us-ascii?Q?tLd0L6fGVKo6SPWssE4w7pZRfCdL0CpfHFRNo0joV7hlxA1wXzAOP/lTCfqf?=
 =?us-ascii?Q?jFtBh0MXZN3lMlmISQJt2lAHjP0gLoALFjxi4Sl8FbqoroNdo9X0PDHXtATh?=
 =?us-ascii?Q?sB/JVSD34hznTxAIDjhX8wl88N9FeXMOcdeQsr+g+Kj/xQnTRomMNy44w6fg?=
 =?us-ascii?Q?OETHaeaTbmLxojt8NQZtNSkdNHQ/2emlW0wsrQaIEPYh0bHb4mWwa6fB5JZv?=
 =?us-ascii?Q?r4/D6H+8OFcxR7eLNBCGelOuZ4IRn2V3OFH27jur5bozlJOyLhtrPcfPo4T5?=
 =?us-ascii?Q?TIOYcy8NgTyaKT+LXlNskvGmWMy+z36ASBtlpy1z9pqpk6UQn6lDvrKlbpwA?=
 =?us-ascii?Q?x/z8ftG9qcwFRJDUByoAAb2R2/65PJiNph7sMtZqWw+vbNk/bjnbVuc3Zpaz?=
 =?us-ascii?Q?0Yg60FWBsvjRt+T+ykPPIt3CST42THj5CQww+kOQJSnv+6F01JI=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8caa66a9-90f6-4f51-0c6a-08db62c9e899
X-MS-Exchange-CrossTenant-AuthSource: SN6PR10MB3022.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Jun 2023 17:59:13.4819
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: KDn5GuEYoWM9/EaGimC/Yhx8PskoX+MPfOJimPi4fkBRYD5CJP0e3lAOn2AqxNNB1pzLIl5pxjQle59SyZQQ2g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR10MB6831
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.573,FMLib:17.11.176.26
 definitions=2023-06-01_08,2023-05-31_03,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 malwarescore=0 phishscore=0
 bulkscore=0 adultscore=0 mlxscore=0 suspectscore=0 mlxlogscore=999
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2304280000
 definitions=main-2306010155
X-Proofpoint-ORIG-GUID: uNNUPv63FWh994ZkCjB5NNDXb4Y2JRWr
X-Proofpoint-GUID: uNNUPv63FWh994ZkCjB5NNDXb4Y2JRWr
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

* Anjali Kulkarni <anjali.k.kulkarni@oracle.com> [691231 23:00]:
> A new function netlink_release is added in netlink_sock to store the
> protocol's release function. This is called when the socket is deleted.
> This can be supplied by the protocol via the release function in
> netlink_kernel_cfg. This is being added for the NETLINK_CONNECTOR
> protocol, so it can free it's data when socket is deleted.
> 
> Signed-off-by: Anjali Kulkarni <anjali.k.kulkarni@oracle.com>

Reviewed-by: Liam R. Howlett <Liam.Howlett@oracle.com>

> ---
>  include/linux/netlink.h  | 1 +
>  net/netlink/af_netlink.c | 6 ++++++
>  net/netlink/af_netlink.h | 4 ++++
>  3 files changed, 11 insertions(+)
> 
> diff --git a/include/linux/netlink.h b/include/linux/netlink.h
> index 866bbc5a4c8d..05a316aa93b4 100644
> --- a/include/linux/netlink.h
> +++ b/include/linux/netlink.h
> @@ -51,6 +51,7 @@ struct netlink_kernel_cfg {
>  	int		(*bind)(struct net *net, int group);
>  	void		(*unbind)(struct net *net, int group);
>  	bool		(*compare)(struct net *net, struct sock *sk);
> +	void		(*release) (struct sock *sk, unsigned long *groups);
>  };
>  
>  struct sock *__netlink_kernel_create(struct net *net, int unit,
> diff --git a/net/netlink/af_netlink.c b/net/netlink/af_netlink.c
> index 003c7e6ec9be..dc7880055705 100644
> --- a/net/netlink/af_netlink.c
> +++ b/net/netlink/af_netlink.c
> @@ -677,6 +677,7 @@ static int netlink_create(struct net *net, struct socket *sock, int protocol,
>  	struct netlink_sock *nlk;
>  	int (*bind)(struct net *net, int group);
>  	void (*unbind)(struct net *net, int group);
> +	void (*release)(struct sock *sock, unsigned long *groups);
>  	int err = 0;
>  
>  	sock->state = SS_UNCONNECTED;
> @@ -704,6 +705,7 @@ static int netlink_create(struct net *net, struct socket *sock, int protocol,
>  	cb_mutex = nl_table[protocol].cb_mutex;
>  	bind = nl_table[protocol].bind;
>  	unbind = nl_table[protocol].unbind;
> +	release = nl_table[protocol].release;
>  	netlink_unlock_table();
>  
>  	if (err < 0)
> @@ -719,6 +721,7 @@ static int netlink_create(struct net *net, struct socket *sock, int protocol,
>  	nlk->module = module;
>  	nlk->netlink_bind = bind;
>  	nlk->netlink_unbind = unbind;
> +	nlk->netlink_release = release;
>  out:
>  	return err;
>  
> @@ -763,6 +766,8 @@ static int netlink_release(struct socket *sock)
>  	 * OK. Socket is unlinked, any packets that arrive now
>  	 * will be purged.
>  	 */
> +	if (nlk->netlink_release)
> +		nlk->netlink_release(sk, nlk->groups);
>  
>  	/* must not acquire netlink_table_lock in any way again before unbind
>  	 * and notifying genetlink is done as otherwise it might deadlock
> @@ -2117,6 +2122,7 @@ __netlink_kernel_create(struct net *net, int unit, struct module *module,
>  		if (cfg) {
>  			nl_table[unit].bind = cfg->bind;
>  			nl_table[unit].unbind = cfg->unbind;
> +			nl_table[unit].release = cfg->release;
>  			nl_table[unit].flags = cfg->flags;
>  			if (cfg->compare)
>  				nl_table[unit].compare = cfg->compare;
> diff --git a/net/netlink/af_netlink.h b/net/netlink/af_netlink.h
> index 5f454c8de6a4..054335a34804 100644
> --- a/net/netlink/af_netlink.h
> +++ b/net/netlink/af_netlink.h
> @@ -42,6 +42,8 @@ struct netlink_sock {
>  	void			(*netlink_rcv)(struct sk_buff *skb);
>  	int			(*netlink_bind)(struct net *net, int group);
>  	void			(*netlink_unbind)(struct net *net, int group);
> +	void			(*netlink_release)(struct sock *sk,
> +						   unsigned long *groups);
>  	struct module		*module;
>  
>  	struct rhash_head	node;
> @@ -65,6 +67,8 @@ struct netlink_table {
>  	int			(*bind)(struct net *net, int group);
>  	void			(*unbind)(struct net *net, int group);
>  	bool			(*compare)(struct net *net, struct sock *sock);
> +	void			(*release)(struct sock *sk,
> +					   unsigned long *groups);
>  	int			registered;
>  };
>  
> -- 
> 2.40.0
>