Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <aef25380-790e-6776-aaf2-6a74971054e4@quicinc.com>
Date:   Thu, 1 Jun 2023 11:12:57 -0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.6.1
Subject: Re: [PATCH v1] ufs: core: Remove the nolock version of
 ufshcd_mcq_poll_cqe()
Content-Language: en-US
To:     Stanley Chu <stanley.chu@mediatek.com>,
        <linux-scsi@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <martin.petersen@oracle.com>, <avri.altman@wdc.com>,
        <alim.akhtar@samsung.com>, <jejb@linux.ibm.com>,
        <bvanassche@acm.org>
References: <20230601090202.27035-1-stanley.chu@mediatek.com>
From:   "Bao D. Nguyen" <quic_nguyenb@quicinc.com>
In-Reply-To: <20230601090202.27035-1-stanley.chu@mediatek.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 6/1/2023 2:02 AM, Stanley Chu wrote:
> Since ufshcd_mcq_poll_cqe_nolock() is no longer used by any users,
> it should be removed.
> 
> Signed-off-by: Stanley Chu <stanley.chu@mediatek.com>
> ---
>   drivers/ufs/core/ufs-mcq.c | 17 ++++-------------
>   1 file changed, 4 insertions(+), 13 deletions(-)
> 
> diff --git a/drivers/ufs/core/ufs-mcq.c b/drivers/ufs/core/ufs-mcq.c
> index 920eb954f594..785fc9762cad 100644
> --- a/drivers/ufs/core/ufs-mcq.c
> +++ b/drivers/ufs/core/ufs-mcq.c
> @@ -307,11 +307,13 @@ void ufshcd_mcq_compl_all_cqes_lock(struct ufs_hba *hba,
>   	spin_unlock_irqrestore(&hwq->cq_lock, flags);
>   }
>   
> -static unsigned long ufshcd_mcq_poll_cqe_nolock(struct ufs_hba *hba,
> -						struct ufs_hw_queue *hwq)
> +unsigned long ufshcd_mcq_poll_cqe_lock(struct ufs_hba *hba,
> +				       struct ufs_hw_queue *hwq)
>   {
>   	unsigned long completed_reqs = 0;
> +	unsigned long flags;
>   
> +	spin_lock_irqsave(&hwq->cq_lock, flags);
>   	ufshcd_mcq_update_cq_tail_slot(hwq);
>   	while (!ufshcd_mcq_is_cq_empty(hwq)) {
>   		ufshcd_mcq_process_cqe(hba, hwq);
> @@ -321,17 +323,6 @@ static unsigned long ufshcd_mcq_poll_cqe_nolock(struct ufs_hba *hba,
>   
>   	if (completed_reqs)
>   		ufshcd_mcq_update_cq_head(hwq);
> -
> -	return completed_reqs;
> -}
> -
> -unsigned long ufshcd_mcq_poll_cqe_lock(struct ufs_hba *hba,
> -				       struct ufs_hw_queue *hwq)
> -{
> -	unsigned long completed_reqs, flags;
> -
> -	spin_lock_irqsave(&hwq->cq_lock, flags);
> -	completed_reqs = ufshcd_mcq_poll_cqe_nolock(hba, hwq);
>   	spin_unlock_irqrestore(&hwq->cq_lock, flags);
>   
>   	return completed_reqs;
Hi Stanley,

Other than the commit message that Bart mentioned, this patch looks good.

Reviewed-by: Bao D. Nguyen <quic_nguyenb@quicinc.com>