Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp1196640rwd; Thu, 1 Jun 2023 11:48:42 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7Y+Bsmh2Z0gZy7WB43yPr/gj2VgUQFt8Mor6SaYN/APBM6dksmgmPGh7I/gIw5hG7ZCG0G X-Received: by 2002:a05:6a20:7490:b0:10b:7243:c212 with SMTP id p16-20020a056a20749000b0010b7243c212mr8965387pzd.42.1685645321973; Thu, 01 Jun 2023 11:48:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1685645321; cv=none; d=google.com; s=arc-20160816; b=PbUyzUIHHkaM5qZmTjcxCGhurJHT008XMwaDf5QTvbz568umDFZ/zSX56rbzFuC2G6 Vb/4BOcml2II58fuSCF0UrVJSQYY+moaU3k8yIR4lJ/Y8IvSvong8Yp8rn2ARwz84Knm gET84HolklMvMI0MRBhnvTwpNt0B9ysqG0LeSfTsTm+IHJWM93tBrMFyNm++fYO3GgwC rOLg5q8JHwvEx/ZJ1NXoS/6ryGtKcS+MEXwwc9MtB0yY0iN38FyfacIwS33lbjdVpjTf e0pFpM/pAZ6qc4yYBAosw8zbZubLD0GBy5fHA4kp58E/CULY2fCg7IqqcPPBey8Sq9nU qmoA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=4cGZHwIt1iwTUwTIbfKQS2u9UpzO5hpUq+z3kuxb5bs=; b=vByfr53nCaXv08HXmQbC6ndRV5ON5rpMkH1oDVWQMfxLe/ko4ZuRK1ElcRp1A8a9lx AGUKXCriFCqmcOioUBkBknSAEPrkswCAjGHAZUDB8FkRkuVP8b37gyx/TTvbIXGQTwUh FnfuwFa4UaElvPzR5BHRJYFGMrNMfITgIiDhRCbVPc4e9WZtWmHI8txA290vqKLz4uqc l11d/FdIKRhK7n7I65YvD8eKUpFK84r2HA2gJdOz81JiOFe96JW/Q1vrheFnM+YhiOAi ocnLQSc9dq9i7PV1betGAmloNpg6jHJGbY5VGO3HP1UMVwb+WTeSFJDx2Jo6lo9sI2Ay bXEQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=3Cg2wXfC; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=lunn.ch Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id a6-20020a637f06000000b0053f29758cd1si3126042pgd.839.2023.06.01.11.48.27; Thu, 01 Jun 2023 11:48:41 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=3Cg2wXfC; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=lunn.ch Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233006AbjFAS1Q (ORCPT + 99 others); Thu, 1 Jun 2023 14:27:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59866 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232758AbjFAS0r (ORCPT ); Thu, 1 Jun 2023 14:26:47 -0400 Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 88959E63; Thu, 1 Jun 2023 11:26:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=4cGZHwIt1iwTUwTIbfKQS2u9UpzO5hpUq+z3kuxb5bs=; b=3Cg2wXfCbTZZ2RUQsM0oHZHr9V I6WZtxTpyozbxf8Yet71SywZNJ4v6i8uxoU0uMETzerkCOE+d+gJ38piau+N9WRiEhvz6+4EL8rq/ VtC4h1LBlM86/Q6cLAFIViua0zuqF4p1IjECKMESTlEXlaA8XwLTTYc64nM6qGCF2gFQ=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1q4n04-00Eb54-5l; Thu, 01 Jun 2023 20:26:16 +0200 Date: Thu, 1 Jun 2023 20:26:16 +0200 From: Andrew Lunn To: Detlev Casanova Cc: Krzysztof Kozlowski , linux-kernel@vger.kernel.org, Heiner Kallweit , Russell King , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Florian Fainelli , netdev@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH 1/2] dt-bindings: net: phy: Support external PHY xtal Message-ID: References: <20230531150340.522994-1-detlev.casanova@collabora.com> <6646604.lOV4Wx5bFT@arisu> <5f5f6412-f466-9a3f-3ec7-aa45ab0049c6@linaro.org> <2686795.mvXUDI8C0e@arisu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2686795.mvXUDI8C0e@arisu> X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_PASS,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > So I can just use devm_clk_get_optional_enabled(dev, NULL) and I'll get the > first clock defines in the device tree ? Yes: bcm7xxx.c: clk = devm_clk_get_optional_enabled(&phydev->mdio.dev, NULL); micrel.c: clk = devm_clk_get(&phydev->mdio.dev, "rmii-ref"); smsc.c: refclk = devm_clk_get_optional_enabled(dev, NULL); Andrew