Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 1 Jun 2023 14:27:24 -0400
From:   Hugo Villeneuve <hugo@hugovil.com>
To:     m.brock@vanmierlo.com
Cc:     gregkh@linuxfoundation.org, robh+dt@kernel.org,
        krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
        jirislaby@kernel.org, jringle@gridpoint.com,
        l.perczak@camlintechnologies.com, tomasz.mon@camlingroup.com,
        linux-serial@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org,
        Hugo Villeneuve <hvilleneuve@dimonoff.com>,
        stable@vger.kernel.org, Lech Perczak <lech.perczak@camlingroup.com>
Message-Id: <20230601142724.4fb197fd315e6d360c0d0457@hugovil.com>
In-Reply-To: <c5c2879e55102a6d517245e6d251290d@vanmierlo.com>
References: <20230601163113.2785657-1-hugo@hugovil.com>
        <20230601163113.2785657-4-hugo@hugovil.com>
        <c5c2879e55102a6d517245e6d251290d@vanmierlo.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [PATCH v5 3/9] serial: sc16is7xx: refactor GPIO controller
 registration
Precedence: bulk

On Thu, 01 Jun 2023 19:28:01 +0200
m.brock@vanmierlo.com wrote:

> Hugo Villeneuve schreef op 2023-06-01 18:31:
> > From: Hugo Villeneuve <hvilleneuve@dimonoff.com>
> > 
> > In preparation for upcoming patch "fix regression with GPIO
> > configuration". To facilitate review and make code more modular.
> > 
> > Cc: <stable@vger.kernel.org> # 6.1.x
> > Signed-off-by: Hugo Villeneuve <hvilleneuve@dimonoff.com>
> > Reviewed-by: Lech Perczak <lech.perczak@camlingroup.com>
> > Tested-by: Lech Perczak <lech.perczak@camlingroup.com>
> > ---
> >  drivers/tty/serial/sc16is7xx.c | 39 ++++++++++++++++++++--------------
> >  1 file changed, 23 insertions(+), 16 deletions(-)
> > 
> > diff --git a/drivers/tty/serial/sc16is7xx.c 
> > b/drivers/tty/serial/sc16is7xx.c
> > index 0c903d44429c..279d7dcb1447 100644
> > --- a/drivers/tty/serial/sc16is7xx.c
> > +++ b/drivers/tty/serial/sc16is7xx.c
> > @@ -1349,6 +1349,26 @@ static int
> > sc16is7xx_gpio_direction_output(struct gpio_chip *chip,
> > 
> >  	return 0;
> >  }
> > +
> > +static int sc16is7xx_setup_gpio_chip(struct device *dev)
> 
> Only one parameter, but...
> 
> > +	ret = sc16is7xx_setup_gpio_chip(dev, mctrl_mask);
> 
> called with two.

Hi Maarten,
sorry about that, I will fix this for V6.

Somehow my automated compile script tested each patch separately, including this one, but the defconfig didn't enable the module sc6is7xx, so the error went unnoticed. I wrongly assumed that "make alldefconfig" enabled all modules, I will instead use "make allyesconfig".

Hugo.