Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 1 Jun 2023 14:37:59 -0400
From:   Peter Xu <peterx@redhat.com>
To:     Sean Christopherson <seanjc@google.com>
Cc:     linux-kernel@vger.kernel.org, kvm@vger.kernel.org,
        Paolo Bonzini <pbonzini@redhat.com>,
        James Houghton <jthoughton@google.com>,
        Anish Moorthy <amoorthy@google.com>
Subject: Re: [PATCH] selftests/kvm: Allow specify physical cpu list in demand
 paging test
Message-ID: <ZHjlhwTbmYRoZuEa@x1n>
References: <20230503233812.2743269-1-peterx@redhat.com>
 <ZHfHGCfsz4dSQ62b@google.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <ZHfHGCfsz4dSQ62b@google.com>
Precedence: bulk

On Wed, May 31, 2023 at 03:15:52PM -0700, Sean Christopherson wrote:
> On Wed, May 03, 2023, Peter Xu wrote:
> > Mimic dirty log test to allow specify physical cpu pinning for vcpu threads.
> > 
> > Signed-off-by: Peter Xu <peterx@redhat.com>
> > ---
> >  tools/testing/selftests/kvm/demand_paging_test.c | 15 +++++++++++++--
> >  1 file changed, 13 insertions(+), 2 deletions(-)
> > 
> > diff --git a/tools/testing/selftests/kvm/demand_paging_test.c b/tools/testing/selftests/kvm/demand_paging_test.c
> > index bdb8e0748154..d709b65fda2f 100644
> > --- a/tools/testing/selftests/kvm/demand_paging_test.c
> > +++ b/tools/testing/selftests/kvm/demand_paging_test.c
> > @@ -220,12 +220,13 @@ static void run_test(enum vm_guest_mode mode, void *arg)
> >  static void help(char *name)
> >  {
> >  	puts("");
> > -	printf("usage: %s [-h] [-m vm_mode] [-u uffd_mode] [-a]\n"
> > +	printf("usage: %s [-h] [-m vm_mode] [-u uffd_mode] [-a] [-c cpu_list]\n"
> >  		   "          [-d uffd_delay_usec] [-r readers_per_uffd] [-b memory]\n"
> >  		   "          [-s type] [-v vcpus] [-o]\n", name);
> >  	guest_modes_help();
> >  	printf(" -u: use userfaultfd to handle vCPU page faults. Mode is a\n"
> >  	       "     UFFD registration mode: 'MISSING' or 'MINOR'.\n");
> > +	printf(" -c: physical cores to pin vcpu threads (e.g. 1,2,3,...)\n");
> 
> This help really should be provided by kvm_util.c, e.g. this doesn't capture the
> "must pin all vCPUs" behavior, nor does it capture the "pin the main thread"
> behavior.
> 
> Something like this?
> 
> void kvm_get_vcpu_pinning_help(char *buffer, size_t size,
> 			       const char *optchar, const char *testname)
> {
> 	snprintf(buffer, size,
> 		 " -%c: Pin tasks to physical CPUs.  Takes a list of comma separated\n"
> 		 "     values (target pCPU), one for each vCPU, plus an optional\n"
> 		 "     entry for the main application task (specified via entry\n"
> 		 "     <nr_vcpus + 1>).  If used, entries must be provided for all\n"
> 		 "     vCPUs, i.e. pinning vCPUs is all or nothing.\n\n"
> 		 "     E.g. to create 3 vCPUs, pin vCPU0=>pCPU22, vCPU1=>pCPU23,\n"
> 		 "     vCPU2=>pCPU24, and pin the application task to pCPU50:\n\n"
> 		 "         ./%s -v 3 -c 22,23,24,50\n\n"
> 		 "     To leave the application task unpinned, drop the final entry:\n\n"
> 		 "         ./%s -v 3 -c 22,23,24\n\n"
> 		 "     (default: no pinning)\n", optchar, testname);
> }

Sure, I'll respin.  For the long term maybe we'll want to switch to libnuma
to take things easily like "1,2,5-10", but I'll leave that for later.

-- 
Peter Xu