Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <d64b9718-0c85-6e5d-7c5b-6ea617e36a32@gmail.com>
Date:   Thu, 1 Jun 2023 20:55:52 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.9.1
Subject: Re: [PATCH V2 04/13] dt-bindings: clock: qcom: gcc-ipq5018: remove q6
 clocks macros
Content-Language: en-US
To:     Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
        Manikanta Mylavarapu <quic_mmanikan@quicinc.com>,
        agross@kernel.org, andersson@kernel.org, konrad.dybcio@linaro.org,
        robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
        conor+dt@kernel.org, jassisinghbrar@gmail.com,
        mathieu.poirier@linaro.org, mturquette@baylibre.com,
        sboyd@kernel.org, quic_eberman@quicinc.com, quic_mojha@quicinc.com,
        kvalo@kernel.org, loic.poulain@linaro.org,
        linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-remoteproc@vger.kernel.org,
        linux-clk@vger.kernel.org
Cc:     quic_srichara@quicinc.com, quic_sjaganat@quicinc.com,
        quic_kathirav@quicinc.com, quic_anusha@quicinc.com,
        quic_poovendh@quicinc.com, quic_varada@quicinc.com,
        quic_devipriy@quicinc.com
References: <20230521222852.5740-1-quic_mmanikan@quicinc.com>
 <20230521222852.5740-5-quic_mmanikan@quicinc.com>
 <514a9e26-aeb9-ce05-1055-337646098ec1@linaro.org>
From:   Robert Marko <robimarko@gmail.com>
In-Reply-To: <514a9e26-aeb9-ce05-1055-337646098ec1@linaro.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 30. 05. 2023. 13:01, Krzysztof Kozlowski wrote:

> On 22/05/2023 00:28, Manikanta Mylavarapu wrote:
>> Since Q6 firmware takes care of bring up clocks in multipd
>> model, remove bring up clock macros.
>>
>> Signed-off-by: Manikanta Mylavarapu <quic_mmanikan@quicinc.com>
>> ---
>>   include/dt-bindings/clock/qcom,gcc-ipq5018.h | 21 --------------------
>>   1 file changed, 21 deletions(-)
>>
> I am fine with this if it still compiles... I have doubts about it,
> unless of some depedencies (you mentioned three !)... but then it gets
> complicated.
>
> Keep patches doing same logical change in same patchset. This dependency
> dance in recent submissions is making things tricky and prolonging your
> upstreaming process significantly.

Considering that the basic IPQ5018 patchset that this series depends on
has not yet been merged, why not just drop these there instead?

Regards,
Robert

>
> Best regards,
> Krzysztof
>
>
>