Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp1262662rwd;
        Thu, 1 Jun 2023 12:51:24 -0700 (PDT)
X-Google-Smtp-Source: ACHHUZ63C65EIpd/3ETWgzpHntnNL3mjxktsAoLRxMHw7Y24jMwTiDtbLQJr10uQ4XMwalticdJQ
X-Received: by 2002:a05:6358:9328:b0:123:3ec6:f99e with SMTP id x40-20020a056358932800b001233ec6f99emr5254472rwa.1.1685649084126;
        Thu, 01 Jun 2023 12:51:24 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1685649084; cv=none;
        d=google.com; s=arc-20160816;
        b=OjxUB0FHzrgbWBds6E3nitjhVJYcPS0jpkmWdlehtS9pzVdqOtu3meAUQ/FEh7qYPL
         LAAl+aaK30ISMicsmb9UJXtkW4ypkbPiQ3rmw79JNivCrlYPPG1hbrN8dRsX5GTMSuxr
         9ffZvBvLXs8aeI/ltpmv25Wv8lpayd+YcfD8zWOq0O4QVdImN/YG7qpvabVWqnyvzCR/
         fjKzCnIRkUmjemji9ETJsoFO1TzsVoglMZQPx6pJeuE8SoquNBCRCpkVTNPoVqkU0YGS
         3CTeQU6jr71Fuo4RAb3l17fSRSEnzeHapdILbzN2K1kiYPlx7c/xbhqlM/sbrKLy6VJ/
         Nxrg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:in-reply-to:content-disposition:mime-version
         :references:message-id:subject:cc:to:from:date:dkim-signature;
        bh=u7bCjsVvBfHBSKBZixwNn+EH8tQNK9xBNDhiRR0ol6k=;
        b=K8ovUlaVuWzM0aQXR2GFwLDMuMwWxyVAm5B6wFHt8V323WgeVH8K2VZbAw6/kkvEF+
         l2KSthgJLiI7T7TR/6aCXdxm6naGpkJhcKXI4ozJTwYi1MN7pQvwmez6oR8+GF+qyZjE
         ZM2Mq6/P/tTmQcl7qsXbDIEgXNHbZL9UETABWHr+KK6V0nseuNpbn7nv9VuqdczYcFEc
         cazyDaohmArqo5ZtoRgMJ445vQCttH21vU5JTAOjEIK8fdyqZWOfQB2dB2/tfp2Cat/i
         rAj99LYqxvS+PBg98rNtMMwQIV6oXUvQf0nveCkzu5PfrpNnHD5gXZv9i2KrzWIp9SS6
         I/1w==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=pass header.i=@lunn.ch header.s=20171124 header.b=PzZJA9eA;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=lunn.ch
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20])
        by mx.google.com with ESMTP id z17-20020a637e11000000b005343e03b044si171749pgc.697.2023.06.01.12.51.09;
        Thu, 01 Jun 2023 12:51:24 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Authentication-Results: mx.google.com;
       dkim=pass header.i=@lunn.ch header.s=20171124 header.b=PzZJA9eA;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=lunn.ch
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S231599AbjFATh7 (ORCPT <rfc822;abcde12345.z@gmail.com>
        + 99 others); Thu, 1 Jun 2023 15:37:59 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35074 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S229651AbjFATh6 (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 1 Jun 2023 15:37:58 -0400
Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101])
        by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BA99C186;
        Thu,  1 Jun 2023 12:37:53 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch;
        s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version:
        References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject:
        Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding:
        Content-ID:Content-Description:Content-Disposition:In-Reply-To:References;
        bh=u7bCjsVvBfHBSKBZixwNn+EH8tQNK9xBNDhiRR0ol6k=; b=PzZJA9eA5HjrgMlzs4S+NaFK+R
        zJu0xtCCNmvh9hKUrWdWBO0l5VcByEHvORcH98acmxE6QxZKDPQI2NaW69MSn+dxGBq+cYp3CxvCQ
        IFiWXU3mjpkqr73pS2/Z4t/g+jDbaqtmJ/pk1LwWZTg5mj+Gi5SWAFUvCJYoa/+Mknag=;
Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2)
        (envelope-from <andrew@lunn.ch>)
        id 1q4o7B-00EbLe-If; Thu, 01 Jun 2023 21:37:41 +0200
Date:   Thu, 1 Jun 2023 21:37:41 +0200
From:   Andrew Lunn <andrew@lunn.ch>
To:     Detlev Casanova <detlev.casanova@collabora.com>
Cc:     linux-kernel@vger.kernel.org,
        Heiner Kallweit <hkallweit1@gmail.com>,
        Russell King <linux@armlinux.org.uk>,
        "David S . Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Conor Dooley <conor+dt@kernel.org>,
        Florian Fainelli <f.fainelli@gmail.com>,
        netdev@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH 2/2] net: phy: realtek: Add optional external PHY clock
Message-ID: <7bde15a1-08fe-4036-9256-b13280340b6b@lunn.ch>
References: <20230531150340.522994-1-detlev.casanova@collabora.com>
 <20230531150340.522994-2-detlev.casanova@collabora.com>
 <4a6c413c-8791-fd00-a73e-7a12413693e3@gmail.com>
 <5682492.DvuYhMxLoT@arisu>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <5682492.DvuYhMxLoT@arisu>
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_PASS,SPF_PASS,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> I'm not sure about this. Isn't the clock still necessary when suspended for 
> things like wake on lan ?

Yes, but the PHY should know if its a WoL source, and not disable its
own clock. There is some support for this in phylib, and Florian has
also reworked it recently for Broadcom PHYs.

     Andrew