Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230601023644.587584-1-irogers@google.com>
In-Reply-To: <20230601023644.587584-1-irogers@google.com>
From:   Namhyung Kim <namhyung@kernel.org>
Date:   Thu, 1 Jun 2023 13:04:30 -0700
Message-ID: <CAM9d7ciz744BuEkjKRpRov4VsfASJHxskwzzE_L8mmekE6HuZA@mail.gmail.com>
Subject: Re: [PATCH v1 1/2] perf pmu: Only warn about unsupported configs once
To:     Ian Rogers <irogers@google.com>
Cc:     Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@redhat.com>,
        Arnaldo Carvalho de Melo <acme@kernel.org>,
        Mark Rutland <mark.rutland@arm.com>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Jiri Olsa <jolsa@kernel.org>,
        Adrian Hunter <adrian.hunter@intel.com>,
        Kan Liang <kan.liang@linux.intel.com>,
        Rob Herring <robh@kernel.org>,
        Zhengjun Xing <zhengjun.xing@linux.intel.com>,
        James Clark <james.clark@arm.com>,
        Suzuki Poulouse <suzuki.poulose@arm.com>,
        linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8BIT
Precedence: bulk

On Wed, May 31, 2023 at 7:36 PM Ian Rogers <irogers@google.com> wrote:
>
> Avoid scanning format list for each event parsed.

Maybe it's better to change the subject that it's about format..
Other than that,

Acked-by: Namhyung Kim <namhyung@kernel.org>

Thanks,
Namhyung


>
> Signed-off-by: Ian Rogers <irogers@google.com>
> ---
>  tools/perf/util/pmu.c | 5 +++++
>  tools/perf/util/pmu.h | 5 +++++
>  2 files changed, 10 insertions(+)
>
> diff --git a/tools/perf/util/pmu.c b/tools/perf/util/pmu.c
> index 0520aa9fe991..204ce3f02e63 100644
> --- a/tools/perf/util/pmu.c
> +++ b/tools/perf/util/pmu.c
> @@ -934,6 +934,11 @@ void perf_pmu__warn_invalid_formats(struct perf_pmu *pmu)
>  {
>         struct perf_pmu_format *format;
>
> +       if (pmu->formats_checked)
> +               return;
> +
> +       pmu->formats_checked = true;
> +
>         /* fake pmu doesn't have format list */
>         if (pmu == &perf_pmu__fake)
>                 return;
> diff --git a/tools/perf/util/pmu.h b/tools/perf/util/pmu.h
> index 287f593b15c7..7a1535dc1f12 100644
> --- a/tools/perf/util/pmu.h
> +++ b/tools/perf/util/pmu.h
> @@ -76,6 +76,11 @@ struct perf_pmu {
>          * specific code.
>          */
>         bool auxtrace;
> +       /**
> +        * @formats_checked: Only check PMU's formats are valid for
> +        * perf_event_attr once.
> +        */
> +       bool formats_checked;
>         /**
>          * @max_precise: Number of levels of :ppp precision supported by the
>          * PMU, read from
> --
> 2.41.0.rc0.172.g3f132b7071-goog
>