Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <16959c51-5877-07b3-7451-f620fa32724a@amd.com>
Date:   Thu, 1 Jun 2023 16:01:49 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.11.0
Subject: Re: [PATCH -next] drm/amdkfd: clean up one inconsistent indenting
To:     Yang Li <yang.lee@linux.alibaba.com>, airlied@gmail.com
Cc:     daniel@ffwll.ch, alexander.deucher@amd.com,
        christian.koenig@amd.com, amd-gfx@lists.freedesktop.org,
        dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
References: <20230531020811.110744-1-yang.lee@linux.alibaba.com>
Content-Language: en-US
From:   Felix Kuehling <felix.kuehling@amd.com>
Organization: AMD Inc.
In-Reply-To: <20230531020811.110744-1-yang.lee@linux.alibaba.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?elJTTVlYYllQT0N5cE5GSk91Y3VZbEhFRHNxRlJ5b2JOT3hFOUhoUDhTWGlV?=
 =?utf-8?B?V2k4SFo5b2xRbWhnbWZub3JJWkIvMFhGalRXWDFORUh0OGFzRGZ4U1daaDRS?=
 =?utf-8?B?YVB3Z2IzWEZ0eGlIaGcydHNTUXZqTHE3c2dVTUpTT3luTGU4bUJwdTgzMU15?=
 =?utf-8?B?Z29veFVHK01veUR5YnJQVWRzNnA0U01OYjBoVmV5M1A2dU1XVjhKejR1YW1C?=
 =?utf-8?B?ZG5KamoxOGZDM1A0RHJCa2JIV1BTcmFPQjYrUFR5ZGt3SVlENVdTVmx5VTdL?=
 =?utf-8?B?bHp1Y0doeUx5UzdqQjgvNlZCR0krenhTNmlPaitjVFIwa2RVem1HWHlOTC82?=
 =?utf-8?B?MHl6dUxNcExoQm1iLzVXQjd5TEZHNE1lRVBVSmtUTTI3VnVwZWlXS0ZycWxq?=
 =?utf-8?B?bWlVdmJGejBmeGtyTmZpdDVCZUN0MDdQMi9PZ3ZoZ1k4Z2VCcUltOFZGbW5i?=
 =?utf-8?B?T3lNTUhYcHFmSzY1VEJkaCsyWDR5dUZTbVFaaGRFaThrbmZVNVZxd1E0dTd1?=
 =?utf-8?B?Z2V4UWxPM2tWa2ttTDlVUWx3Y2dwenN0OGdOa2UvSHN1TCtWRmZOa1YvWnNU?=
 =?utf-8?B?ZzB3RWs4WE1XYVEwMndDOTdTL1BEd01CZ2tCOGNJUEFicFEyYmVUdk4rUms2?=
 =?utf-8?B?bk00S0lWdGVEbDNvckhJT0FKaHEzK2NmdEZudzNFZk1lMHhTcTZNTjljWEV3?=
 =?utf-8?B?S2JaaGMzRkdEWDNkWHdNZnJhWFJpODgyV2hkd0NkSDdxS3RoeEhjSVA5R3po?=
 =?utf-8?B?ODNsRXpnTFRQVEZhV3BHNnF2ZWNnaWxKVWVaTE53OXpYK0pVN2VVclBzNFVO?=
 =?utf-8?B?MG1zeUtrR0Qzazh2d29qVnBVWGZTOUNhRll2RElDVzFBa3VYQXlzK2xMSjhk?=
 =?utf-8?B?V2hRWldEOGdkMDF1cVBrL2lUUFBFcGtXZVBhaFZmWWdOVlUySjZYNDR2M2dC?=
 =?utf-8?B?WHpmWno3RE5TV25Wb2w4UFdDdGhDNmxDSzRrbmlQVWtibWNZdHJXS1UycS9k?=
 =?utf-8?B?SUQzZW5xVjREbUtTeW9yQjZ6cjFUbmhLem53ZU5zaG1sbUNIc1pCRzc2c0JL?=
 =?utf-8?B?TEJTdTNGVzdOMkZQOGFHRjdWRmxPd0NqbWtiZHluY2JmL2hPVFN3RWNwVWxM?=
 =?utf-8?B?SjJJRW5Pdks4NTJ1enJYNG5hdHZLSllHci9CTkFqc2ZjT3BXM1d6NTY5ekFV?=
 =?utf-8?B?VGpRQXZXNGNicEI5TW5GNHpVQmtHOFNPSWo2OVpzM2d5bFZWUVdlcW9aNDZR?=
 =?utf-8?B?d21Hd3MwWnA2RkRWN1BBV2VsZEpmUllMWTFPYzVHOE0wbkhsc3VwRmFMR2VI?=
 =?utf-8?B?VVl6ZFYyOGZSbStGbVNZMmdoS0p2MlVyOGVEeWdSV3hDTFRWMTJIWDIrc1ds?=
 =?utf-8?B?VmJBZE12bFlJOWN2RGdaNnZIbHJyMzFqbEgxTmdPWllOcHdWUjVKVXJWMXk1?=
 =?utf-8?B?MDVLTUhKY1RBcWF1MFBsT3ZrWDB6VlNZUmgwLzByQ2xMWXhnTk5rUG5zd0VU?=
 =?utf-8?B?Zng2Q2RmLzdJZWRFN2JtcEhkM0tXb1Z0NnEweHl2c2Z2WlNnU3NGSk1ZK3BM?=
 =?utf-8?B?TmlYMUdIdzJPYVpoUHR6VStkejNlSjJBR0ZNS01hblZDOGNBdUxBRFJYQmJm?=
 =?utf-8?B?aFVSK043Q0pjMmZ4cm5tMk5MR0VFTHoyWUJIV1UzZUpQdU96MmU3L2Q2dEZr?=
 =?utf-8?B?d2xFSkMxSzJHWXovOVEwSVlCK0FTbWMrQ29hRU5WY1lQcGppUlUxUmRYZWw4?=
 =?utf-8?B?dlRNM1pYeE5DZ3NZWjBvWXV0ZVNsSGJZYm9oSFNpSEdoYUUvL3VGYWFJTVBH?=
 =?utf-8?B?U3R3OEtNTDUvVW1DMnBvOWZhK2RCQWE2bFRSYjdYMEVhM3hVWktYbno5d0cx?=
 =?utf-8?B?aUNuVmpjWWh3NnRUdVpOUlRDZG5WaWJRZXlwVmxkeXEvV2pIbmY2eitEUWVN?=
 =?utf-8?B?VFNoMWNZZ095NnY2UWpYdmZ2aE02VndkNjhpV2d5aDcyMkF5cFphRVNsQktG?=
 =?utf-8?B?Z3owM0xVeXVKNVM5bU9haTUycU92ZUtUalRxTWZ4bjlvOTRSQ3YyQ3ZHT2Z5?=
 =?utf-8?B?dzBZUE1lWm1ORHN1R2UxM3FocmxqL3MxL1ZjdEFxSkk0a2ZTaEFXVWthM3c0?=
 =?utf-8?Q?q2dOwkGDd+LIsNViHLo+EHBgo?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 58401c2c-d472-443d-c5c4-08db62db0aaa
X-MS-Exchange-CrossTenant-AuthSource: BL1PR12MB5112.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Jun 2023 20:01:52.3408
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: hCXYOG0bp/zw4hPAna2D/kevkfFEXmStpKvSGDxF9sAeI+5uN9BGvh3iLRWyUjX8/6x9BIjs07hZoOhPdpID+Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB7187
X-Spam-Status: No, score=-1.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,NICE_REPLY_A,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 2023-05-30 22:08, Yang Li wrote:
> drivers/gpu/drm/amd/amdgpu/../amdkfd/kfd_device.c:1036 kgd2kfd_interrupt() warn: inconsistent indenting
>
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>

Reviewed-by: Felix Kuehling <Felix.Kuehling@amd.com>

I'm applying the patch to amd-staging-drm-next. Thanks!


> ---
>   drivers/gpu/drm/amd/amdkfd/kfd_device.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_device.c b/drivers/gpu/drm/amd/amdkfd/kfd_device.c
> index 862a50f7b490..0398a8c52a44 100644
> --- a/drivers/gpu/drm/amd/amdkfd/kfd_device.c
> +++ b/drivers/gpu/drm/amd/amdkfd/kfd_device.c
> @@ -1033,7 +1033,7 @@ void kgd2kfd_interrupt(struct kfd_dev *kfd, const void *ih_ring_entry)
>   			    	is_patched ? patched_ihre : ih_ring_entry)) {
>   			kfd_queue_work(node->ih_wq, &node->interrupt_work);
>   			spin_unlock_irqrestore(&node->interrupt_lock, flags);
> -				return;
> +			return;
>   		}
>   		spin_unlock_irqrestore(&node->interrupt_lock, flags);
>   	}