Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <269262acfcce8eb1b85ee1fe3424a5ef2991f481.camel@gmail.com>
Subject: Re: [PATCH] e1000e: Use PME poll to circumvent unreliable ACPI wake
From:   Alexander H Duyck <alexander.duyck@gmail.com>
To:     Kai-Heng Feng <kai.heng.feng@canonical.com>,
        jesse.brandeburg@intel.com, anthony.l.nguyen@intel.com
Cc:     linux-pm@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Date:   Thu, 01 Jun 2023 13:24:24 -0700
In-Reply-To: <20230601162537.1163270-1-kai.heng.feng@canonical.com>
References: <20230601162537.1163270-1-kai.heng.feng@canonical.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.44.4 (3.44.4-3.fc36) 
MIME-Version: 1.0
Precedence: bulk

On Fri, 2023-06-02 at 00:25 +0800, Kai-Heng Feng wrote:
> On some I219 devices, ethernet cable plugging detection only works once
> from PCI D3 state. Subsequent cable plugging does set PME bit correctly,
> but device still doesn't get woken up.

Do we have a root cause on why things don't get woken up? This seems
like an issue where something isn't getting reset after the first
wakeup and so future ones are blocked.

> Since I219 connects to the root complex directly, it relies on platform
> firmware (ACPI) to wake it up. In this case, the GPE from _PRW only
> works for first cable plugging but fails to notify the driver for
> subsequent plugging events.
>=20
> The issue was originally found on CNP, but the same issue can be found
> on ADL too. So workaround the issue by continuing use PME poll after
> first ACPI wake. As PME poll is always used, the runtime suspend
> restriction for CNP can also be removed.
>=20
> Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com>
> ---
>  drivers/net/ethernet/intel/e1000e/netdev.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>=20
> diff --git a/drivers/net/ethernet/intel/e1000e/netdev.c b/drivers/net/eth=
ernet/intel/e1000e/netdev.c
> index bd7ef59b1f2e..f0e48f2bc3a2 100644
> --- a/drivers/net/ethernet/intel/e1000e/netdev.c
> +++ b/drivers/net/ethernet/intel/e1000e/netdev.c
> @@ -7021,6 +7021,8 @@ static __maybe_unused int e1000e_pm_runtime_resume(=
struct device *dev)
>  	struct e1000_adapter *adapter =3D netdev_priv(netdev);
>  	int rc;
> =20
> +	pdev->pme_poll =3D true;
> +
>  	rc =3D __e1000_resume(pdev);
>  	if (rc)
>  		return rc;

Doesn't this enable this too broadly. I know there are a number of
devices that run under the e1000e and I would imagine that we don't
want them all running with "pme_poll =3D true" do we?

It seems like at a minimum we should only be setting this for specific
platofrms or devices instead of on all of them.

Also this seems like something we should be setting on the suspend side
since it seems to be clared in the wakeup calls.

Lastly I am not sure the first one is necessarily succeding. You might
want to check the status of pme_poll before you run your first test.
From what I can tell it looks like the initial state is true in
pci_pm_init. If so it might be getting cleared after the first wakeup
which is what causes your issues.

> @@ -7682,7 +7684,7 @@ static int e1000_probe(struct pci_dev *pdev, const =
struct pci_device_id *ent)
> =20
>  	dev_pm_set_driver_flags(&pdev->dev, DPM_FLAG_SMART_PREPARE);
> =20
> -	if (pci_dev_run_wake(pdev) && hw->mac.type !=3D e1000_pch_cnp)
> +	if (pci_dev_run_wake(pdev))
>  		pm_runtime_put_noidle(&pdev->dev);
> =20
>  	return 0;

I assume this is the original workaround that was put in to address
this issue. Perhaps you should add a Fixes tag to this to identify
which workaround this patch is meant to be replacing.