Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 1 Jun 2023 20:00:46 -0300
From:   Jason Gunthorpe <jgg@nvidia.com>
To:     Junxian Huang <huangjunxian6@hisilicon.com>
Cc:     leon@kernel.org, linux-rdma@vger.kernel.org, linuxarm@huawei.com,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH for-rc 0/3] RDMA/hns: Bugfix and improvements
Message-ID: <ZHkjHl1H02sr8pnq@nvidia.com>
References: <20230523121641.3132102-1-huangjunxian6@hisilicon.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230523121641.3132102-1-huangjunxian6@hisilicon.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?ILif5hhl46JF4yTRpxtE7X9v9M64ZVMc0YUwoPGKkj/VdSQnYhyASI5CVmmN?=
 =?us-ascii?Q?j3qoX3K3q59j9X/te3o6HPKeWd3tgqdpHmZhb9LH9+b1Gb9/E8MyKgcc2R67?=
 =?us-ascii?Q?M/lJnY8oXBYzf/GOjzO4Zkcuuz/S9/VWyLUcQqSBNQbYg7Ci6nw8TB1Oj6Yg?=
 =?us-ascii?Q?Us2P+ltGseOBON3znrr/MidlDg2OBo1Lcs65+alsJ58Hh/++/ogGVtsbctQG?=
 =?us-ascii?Q?PnlA+yqbZLovGJ0wclNcrTF5oiS+ZYa4+MKWpckAIPM+u2RHSsdduhxpUoHi?=
 =?us-ascii?Q?rCGMVgh7Q3MZr/ZetU6ef/vg0u7uee9dWvJuv6tz8Ty8ChTiTX2JIoI5vA/U?=
 =?us-ascii?Q?0VY2t2Jfzd0bBjDbzF+tf/HlM0P4V0Vt6DJwyBw7RzzhOHgGyD8BvbsV1YEZ?=
 =?us-ascii?Q?FS1NS6TE+TOWj4Xy7LdzkQUOmmse5HhXDcCNoTnJnaM/20pBxV9Sb9jxdFu/?=
 =?us-ascii?Q?fSrUhIbJaL+ovO7sYwYO8NlwKrHiKUmiZ6lwC7zCpc0doRbOVICPKM/0RZhV?=
 =?us-ascii?Q?H8T7LxQIy9loeHivoySlaB6VQH3N2+xVYmgDYX5/GUTuF/EQGZJXScViD9oF?=
 =?us-ascii?Q?rjrX2GFYUIWrAq8Nbglu1tUkmgeDXLHrvs0XtIHMmTroIENCUzh0qVpZKPir?=
 =?us-ascii?Q?LB+hTsxVuGfy+DrYl+5ksj1o1cZTsPrRAreWBJmTH7F13KO684HkEl65UDp6?=
 =?us-ascii?Q?23sZXSHfOmBQ1iavrBdNijgnHAPUta79yPDnjex5DnlAm+l0U/V9dzA8lJli?=
 =?us-ascii?Q?2L0Q11pnZPQUgVRWW/1w0gjVVf62yhFxWC8sGHAsWVzpBJhn9sluUSqdOZOC?=
 =?us-ascii?Q?AHYeonoVxkHaOwxmWKMUzomQdRt9W4saA6+XC5nm9Yeq4JDZigEWOyiTWetp?=
 =?us-ascii?Q?Ru50ZwufIfGkS3OL8QDUEdT9Zw9gnLKqehysvEI6EheeKAlFL4JdriFnr/sB?=
 =?us-ascii?Q?/4FFNMHrIHsG+K0fE7GCWNAGtovVC5sYfmxdGqigblXHO3g9jkORHVXteqCk?=
 =?us-ascii?Q?8z1iYxZjB+VMo05DEdbNzSeC1xHBvIxZXtS6tTldw5V7oydJZDM09kBzILlD?=
 =?us-ascii?Q?GWMalzXl8/4c/tfqMuWeFlCuKaPyyC23tEtS4Se+7HROt/BHBrEZvQRc1GyF?=
 =?us-ascii?Q?9M1M7FaZX91cOX5OSGCFSmzIobB2tx41d1U5zMwCZ+dRZgha797qFBjnFazT?=
 =?us-ascii?Q?kIzj7xGQKd35pm+P5FgqkzLjAevLyrZvox8E09uuizHgk/edSnAfElMb7ob/?=
 =?us-ascii?Q?zXv4A3m85zGGE24U6U8y/DO0a6h0t+ucjiKZf86tc8Gt5S6LaMGQwpvvWNmP?=
 =?us-ascii?Q?mZz2EG+9U9UmBA3sF7fgG1ylazhKBsHRv/fG3vqtq6U9P5n085szjMRmXQyj?=
 =?us-ascii?Q?t42xJJ1Oachz6De8M0M/r89tJd4QrU1S6jE37nfACq4qbYpnGXKjSJek3+uG?=
 =?us-ascii?Q?SA5clnafwma43xUDNDfv2oux8+7Q9arp9gzmRaY5gcrAGnXEjBEMhFvgjgSm?=
 =?us-ascii?Q?1FNiBZHvB/taEhpvzwoyvdIiGwJ25f4bp5ANA4vAKqQf73o4tO5J1Kn7HMSd?=
 =?us-ascii?Q?7UXBJQ/MmM9Wm/gnmF7wvLo1MJBBfWLp6ouOqCcq?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2ee93b9d-35f7-45a0-42a5-08db62f40a04
X-MS-Exchange-CrossTenant-AuthSource: LV2PR12MB5869.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Jun 2023 23:00:48.3871
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: TfLhvN4Ixeqn0zz20j0rgUS4PqCpCtWfD5jl6gU98KX7NXtKHgBZ3b+brH5x5hT5
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN0PR12MB6053
X-Spam-Status: No, score=-1.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, May 23, 2023 at 08:16:38PM +0800, Junxian Huang wrote:
> 1. #1-#2: The first two patches improves diagnostic information to
>    the driver.
> 
> 2. #3: The third patch removes unnecessary QP type checks.
> 
> 
> Chengchang Tang (2):
>   RDMA/hns: Fix hns_roce_table_get return value
>   RDMA/hns: Add clear_hem return value to log
> 
> Junxian Huang (1):
>   RDMA/hns: Remove unnecessary QP type checks

These are not -rc patches, they don't fix user facing things, so I put
them in for-next

Also there was a compile warning I fixed

../drivers/infiniband/hw/hns/hns_roce_hw_v2.c:767:20: warning: unused variable 'ibdev' [-Wunused-variable]
        struct ib_device *ibdev = &hr_dev->ib_dev;

Although it could probably use more fixing.

Jason