Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp1458311rwd; Thu, 1 Jun 2023 16:20:42 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6+V9hwN7tCzPVGLnrVD5O6V9yiYJzErOZAQ9XTEK8WafqrWojsUR9gSlUf66BsAUuGbJOG X-Received: by 2002:ac8:5bc2:0:b0:3f6:b918:2351 with SMTP id b2-20020ac85bc2000000b003f6b9182351mr14189653qtb.0.1685661641783; Thu, 01 Jun 2023 16:20:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1685661641; cv=none; d=google.com; s=arc-20160816; b=B3c6Un7xhlJ7mOeOgp+1L94T5vH05t+p5LFqd9WIVYWFeSvoE02e8P+wzGmAnTcqB1 jjTPc8S6bBVkT9H0zR7ADK+NR16bbmS8EMRVKyIIR5pW0tRnbdXlIe/gwCYJ64xVPNTn +6psFnIeiMkzb//cgc9wLL575fRq/8WxbCduRjssQYpP3hAjlr+E52wphYKXYONhEvsC roaFykrW3coZLmjDj+SDc5hBn/u3NPfrdFbEWbtiqo7wtE/udCivLAg6q8Yi9SkLXcon ndtf2aRN08W0NAIonr0KK+HPe4fMQlBU1WEVGnMV/8gaoAYZRS3+HSvPdUohm3Zr3Vk+ fnBw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to :organization:from:content-language:references:cc:to:subject :user-agent:mime-version:date:message-id:dkim-signature; bh=uJUYPHhaBQ7lbXVIyqwGpcFl7jm4oe1qmAFWDxKMlQE=; b=MifELhyXFRQS+/EXgIqOcxmOWe9nVmt51vAJaCBrq7TO5ofViVSU1BrtwumWftU2b2 Bvd0QrgX2KU26wBatiUzHhcCNVQAGrXF3fey/Jo52V/umAlaJBWfogGo025rfxWhdN28 AXDqBb87b4KykRFadE4FvdBv65q4QpYA/Xahq7KD2tZaH1cA3t6Rdf0KeciI6kY0Base yFmGxEA9t/IAMCpy6ODpMEpNZMvNeGNzAbx5y6J+K1rGAOJcH3Jo6q8rBhvgitbgosQV CF6AIVepe3JmoB3jCgZ2sdADR1we5oxizHKrEY1ejTAkpTIcWol+mMhSRjGqUTP+DDMA 3Q2g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=LdBOkWe+; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id v22-20020a636116000000b0053071414c3asi1260653pgb.562.2023.06.01.16.20.29; Thu, 01 Jun 2023 16:20:41 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=LdBOkWe+; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232343AbjFAXMO (ORCPT + 99 others); Thu, 1 Jun 2023 19:12:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59106 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229868AbjFAXMM (ORCPT ); Thu, 1 Jun 2023 19:12:12 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E961113E; Thu, 1 Jun 2023 16:12:07 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 07F0764A9D; Thu, 1 Jun 2023 23:12:07 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 84799C433EF; Thu, 1 Jun 2023 23:12:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1685661126; bh=4I2XX3D8El+lt+ER26Q2EW58g+AOstzpVwI+h3F2lvc=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=LdBOkWe+XlW73pkWpU/zC0DwkN7/Ic05Hs0eW5ua1d1xuCbrKhBJxm9QR1SgQRnSN m+WYHl37ZIrfKDwqOy5iJI+FzdVEE6sL/C+PWu+aDk5fwqILE8SRbS8K9Hd1VFxFEd WlBo6ITgaCX4LY3OWex1du8ew0voWgS/RaWap1L27EI3ZMaQrc3/DbtRXrdAoHEgk3 KUgjeligawpCwekWD1ejhl9JRdsu9fngAEY5j1/S/41XBapOG8aKaC/s6hqT8gOgzi zS6Evps17E6qi0PM2LTFKnV8Dfi8kbTtgdGKCva3IXbkTZOYV2Gj2gb5xCx48o/4Jv t6ZhDH0mSKyuw== Message-ID: <027026e0-9388-c5c6-1076-3c683e7b782c@kernel.org> Date: Fri, 2 Jun 2023 08:12:04 +0900 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH v5 2/9] PCI: endpoint: Add missing documentation about the MSI/MSI-X range To: Manivannan Sadhasivam , lpieralisi@kernel.org, kw@linux.com Cc: kishon@kernel.org, bhelgaas@google.com, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org References: <20230601145718.12204-1-manivannan.sadhasivam@linaro.org> <20230601145718.12204-3-manivannan.sadhasivam@linaro.org> Content-Language: en-US From: Damien Le Moal Organization: Western Digital Research In-Reply-To: <20230601145718.12204-3-manivannan.sadhasivam@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A, RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 6/1/23 23:57, Manivannan Sadhasivam wrote: > Both pci_epc_raise_irq() and pci_epc_map_msi_irq() APIs expects the > MSI/MSI-X vectors to start from 1 but it is not documented. Add the > range info to the kdoc of the APIs to make it clear. > > Fixes: 5e8cb4033807 ("PCI: endpoint: Add EP core layer to enable EP controller and EP functions") > Fixes: 87d5972e476f ("PCI: endpoint: Add pci_epc_ops to map MSI IRQ") > Signed-off-by: Manivannan Sadhasivam Looks good. Reviewed-by: Damien Le Moal -- Damien Le Moal Western Digital Research