Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230601230456.2234972-1-royluo@google.com> <4f049d62-d103-4491-9c7e-16c7cf94eac1@rowland.harvard.edu>
In-Reply-To: <4f049d62-d103-4491-9c7e-16c7cf94eac1@rowland.harvard.edu>
From:   Roy Luo <royluo@google.com>
Date:   Thu, 1 Jun 2023 16:42:16 -0700
Message-ID: <CA+zupgxPfAwbLq=CUy_frj9CMqYKmQKj2enC1_VvkMFAiA5FCg@mail.gmail.com>
Subject: Re: [PATCH v1] usb: core: add sysfs entry for usb device state
To:     Alan Stern <stern@rowland.harvard.edu>
Cc:     raychi@google.com, badhri@google.com,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Benjamin Tissoires <benjamin.tissoires@redhat.com>,
        Michael Grzeschik <m.grzeschik@pengutronix.de>,
        Bastien Nocera <hadess@hadess.net>,
        Mathias Nyman <mathias.nyman@linux.intel.com>,
        Matthias Kaehlcke <mka@chromium.org>,
        Flavio Suligoi <f.suligoi@asem.it>,
        Douglas Anderson <dianders@chromium.org>,
        Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
        linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Thu, Jun 1, 2023 at 4:21=E2=80=AFPM Alan Stern <stern@rowland.harvard.ed=
u> wrote:
>
> On Thu, Jun 01, 2023 at 11:04:56PM +0000, Roy Luo wrote:
> > Expose usb device state to userland as the information is useful in
> > detecting non-compliant setups and diagnosing enumeration failures.
> > For example:
> > - End-to-end signal integrity issues: the device would fail port reset
> >   repeatedly and thus be stuck in POWERED state.
> > - Charge-only cables (missing D+/D- lines): the device would never ente=
r
> >   POWERED state as the HC would not see any pullup.
> >
> > What's the status quo?
> > We do have error logs such as "Cannot enable. Maybe the USB cable is ba=
d?"
> > to flag potential setup issues, but there's no good way to expose them =
to
> > userspace.
> >
> > Why add a sysfs entry in struct usb_port instead of struct usb_device?
> > The struct usb_device is not device_add() to the system until it's in
> > ADDRESS state hence we would miss the first two states. The struct
> > usb_port is a better place to keep the information because its life
> > cycle is longer than the struct usb_device that is attached to the port=
.
> >
> > Reviewed-by: Alan Stern <stern@rowland.harvard.edu>
> > Signed-off-by: Roy Luo <royluo@google.com>
> > ---
>
> > diff --git a/drivers/usb/core/hub.c b/drivers/usb/core/hub.c
> > index 97a0f8faea6e..35d94288726b 100644
> > --- a/drivers/usb/core/hub.c
> > +++ b/drivers/usb/core/hub.c
> > @@ -2018,6 +2018,23 @@ bool usb_device_is_owned(struct usb_device *udev=
)
> >       return !!hub->ports[udev->portnum - 1]->port_owner;
> >  }
> >
> > +static void update_port_device_state(struct usb_device *udev)
> > +{
> > +     struct usb_port *port_dev =3D NULL;
> > +     struct usb_hub *hub =3D NULL;
> > +     struct kernfs_node *state_node =3D NULL;
> > +
> > +     if (udev->parent) {
> > +             hub =3D usb_hub_to_struct_hub(udev->parent);
> > +             port_dev =3D hub->ports[udev->portnum - 1];
> > +             WRITE_ONCE(port_dev->state, udev->state);
> > +             state_node =3D sysfs_get_dirent(port_dev->dev.kobj.sd, "s=
tate");
> > +             if (state_node) {
> > +                     sysfs_notify_dirent(state_node);
> > +             }
> > +     }
> > +}
>
> I didn't notice the "=3D NULL" initializers before.  You might want to
> remove them, since they are completely unnecessary.
>
> Alan Stern

Ack, sending out v2.

Thanks,
Roy