Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <0822f75a-267c-faa5-bdc5-55eca5dbbc62@gmail.com>
Date:   Fri, 2 Jun 2023 01:54:25 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.11.0
Subject: Re: [PATCH] tmpfs.5: extend with new noswap documentation
Content-Language: en-US
To:     Luis Chamberlain <mcgrof@kernel.org>, alx@kernel.org,
        linux-man@vger.kernel.org, linux-api@vger.kernel.org
Cc:     hughd@google.com, p.raghav@samsung.com, da.gomez@samsung.com,
        rohan.puri@samsung.com, rpuri.linux@gmail.com,
        a.manzanares@samsung.com, dave@stgolabs.net, yosryahmed@google.com,
        keescook@chromium.org, patches@lists.linux.dev,
        linux-fsdevel@vger.kernel.org, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org
References: <20230526210703.934922-1-mcgrof@kernel.org>
From:   Alejandro Colomar <alx.manpages@gmail.com>
In-Reply-To: <20230526210703.934922-1-mcgrof@kernel.org>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="------------fhGnL7Zf9xrdwVrHSelHTA4N"
Precedence: bulk

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--------------fhGnL7Zf9xrdwVrHSelHTA4N
Content-Type: multipart/mixed; boundary="------------3L7GuI8sJyU0F1PyzmHCFWDb";
 protected-headers="v1"
From: Alejandro Colomar <alx.manpages@gmail.com>
To: Luis Chamberlain <mcgrof@kernel.org>, alx@kernel.org,
 linux-man@vger.kernel.org, linux-api@vger.kernel.org
Cc: hughd@google.com, p.raghav@samsung.com, da.gomez@samsung.com,
 rohan.puri@samsung.com, rpuri.linux@gmail.com, a.manzanares@samsung.com,
 dave@stgolabs.net, yosryahmed@google.com, keescook@chromium.org,
 patches@lists.linux.dev, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org,
 linux-kernel@vger.kernel.org
Message-ID: <0822f75a-267c-faa5-bdc5-55eca5dbbc62@gmail.com>
Subject: Re: [PATCH] tmpfs.5: extend with new noswap documentation
References: <20230526210703.934922-1-mcgrof@kernel.org>
In-Reply-To: <20230526210703.934922-1-mcgrof@kernel.org>

--------------3L7GuI8sJyU0F1PyzmHCFWDb
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

Hi Luis,

On 5/26/23 23:07, Luis Chamberlain wrote:
> Linux commit 2c6efe9cf2d7 ("shmem: add support to ignore swap")
> merged as of v6.4 added support to disable swap for tmpfs mounts.
>=20
> This extends the man page to document that.
>=20
> Signed-off-by: Luis Chamberlain <mcgrof@kernel.org>
> ---
>  man5/tmpfs.5 | 5 +++++
>  1 file changed, 5 insertions(+)
>=20
> diff --git a/man5/tmpfs.5 b/man5/tmpfs.5
> index 09d9558985e9..f7f90f112103 100644
> --- a/man5/tmpfs.5
> +++ b/man5/tmpfs.5
> @@ -99,6 +99,11 @@ suffixes like
>  .BR size ,
>  but not a % suffix.
>  .TP
> +.BR noswap "(since Linux 6.4)"
> +.\" commit 2c6efe9cf2d7841b75fe38ed1adbd41a90f51ba0
> +Disables swap. Remounts must respect the original settings.

Please use semantic newlines.  See man-pages(7):
   Use semantic newlines
       In the source of a manual page, new sentences should be started
       on  new  lines,  long  sentences  should be split into lines at
       clause breaks (commas, semicolons, colons, and so on), and long
       clauses should be split at phrase boundaries.  This convention,
       sometimes known as "semantic newlines", makes it easier to  see
       the  effect of patches, which often operate at the level of in=E2=80=
=90
       dividual sentences, clauses, or phrases.

Thanks,
Alex

> +By default swap is enabled.
> +.TP
>  .BR mode "=3D\fImode\fP"
>  Set initial permissions of the root directory.
>  .TP

--=20
<http://www.alejandro-colomar.es/>
GPG key fingerprint: A9348594CE31283A826FBDD8D57633D441E25BB5

--------------3L7GuI8sJyU0F1PyzmHCFWDb--

--------------fhGnL7Zf9xrdwVrHSelHTA4N
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEE6jqH8KTroDDkXfJAnowa+77/2zIFAmR5L7EACgkQnowa+77/
2zKzPQ//eaMf/JhjExdKSJjWCIGk056qab5So1LYbuHQWrEJYFGnC1v9obCoGeoQ
lUj0/jsuKh0bNIZG7L01jDCLA+/lxrzq7UrqusAZpZu81DHKeh/ITysVkORfa5yZ
/Rl6RKe9eCo01jBPkhHF84bBJX6jQdD5jzo0ZkCci5PMx5GMna01daevr60Cd7Fg
1o+GYAJvZw/3aB98Pf40zT1DT3CsBKze284OAPwQqUFMO1gDKy9nJC6+j76Wgu5a
xnlxwxothoNslsS9oPZF/y9TCanxiGQTPXTkSd2oNgkn1pXN4al4AukoLyvh/B0G
GNvAnW57pAYr/2XCHXFU92yqrYaM1H9RF2dk6SbCjxjG6Uuz9G+icM6iRMLPscrI
CG9smE/ZKCXGE5sM0ddQ6JsIR+iT7y6wokeKapztN19jYCPlwr/SWT/EOElYlD8G
q683oVhzFcTSzCuIXBBBHm7lUOh3d0boOwHa7WZhVvcdPr4IV1BNWO7hb8hCg8uD
PyzC1lnWr2835RaaD9DNki9pj/9pSYwnUvANFPNyJCtAY4Hnh93UrPz82YHCIf/w
XJ7Snt+jzJApKGrdI0VvWwS9/8MTvj5bQczy5Z+KKocoV+W1yU2mnWkTiBvqItmU
ksvdZ0IsQjD5HLY3BkkgObykUwNyOI+4lhYkkXM0eg+gTcuvTjc=
=1akv
-----END PGP SIGNATURE-----

--------------fhGnL7Zf9xrdwVrHSelHTA4N--