Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp1563776rwd; Thu, 1 Jun 2023 18:25:35 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ50ZlXXSoYN826zcCMEk5U1ylbpZNJuPVWZBK8faJxJPi+NYkOMiF2f+HrSj8sSug0R6CNm X-Received: by 2002:a05:6a20:8e2a:b0:10a:cb95:5aa3 with SMTP id y42-20020a056a208e2a00b0010acb955aa3mr13425982pzj.7.1685669134725; Thu, 01 Jun 2023 18:25:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1685669134; cv=none; d=google.com; s=arc-20160816; b=J0bglQkXzRzwG8KoxTNEGWfuLhBwhI/dqlwQvgdCPYIXcqLtmwCGeaMtfHK2rW65vj 5IJ0SX4IRKUfcqYA12LYdz50Rk1vbMKrARLdMBP6xnKep1wx3JpjbUJyYTGD1wNcX5MH 0IigRYY6/dzbsqBUTwJdMuaoDL0VDIpEX+5I2J7Z5LAMw3t6Lr37HTcKP1ZRtYHDzRZk /IPTa/u6I0hp+gODIqPJZAjzQlenM5p7kFj5X0q8Baz/7UpnhUW1YwZ/Yr5i6DKfFD22 jqaKi1QOV7ikiXyLVWA6k+rseLZg69nq5LgNOekqMK1M3e5cYDTt9ybbj+8EKuMLOKGR hTwQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:dkim-signature; bh=Z89lfLkyR3wUxURBnMByyXkAk3prI/BY4d5M95naVOE=; b=NFXp8mvX9YjZB5MVy2LmV6JMwb5ExPXE/wzWnh/lJOrfbO6Rl4PZg3vgDIWXx+ZdV2 blFaAeUtjaqpN6FzHqw1lle4mNjh5YWBdEECG4mephKrdpaQ7369ysmlAg28VI/ZhN/j r7sJORFyPrPEeqTUiDLzdagKGcB9lbB9zGCD5/6EDnyaa8VRFstzyw/9TzbP6YpgzHEK 3r0Zu0aQqRHK/420a4JQqcFXPoyMwYfBRex7Wqy4ET6hK8nL3ou8u5fBwMwxEfY43Ssg EoOZq25N768Hi6VWfOGiaKJGVAYUatKvrhjHCEh+nPXsdCeR4s1UDLONU2diwjlzCkUn A3NA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=iwx0XcTs; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id c5-20020a637245000000b0053f89d7b39esi128939pgn.346.2023.06.01.18.25.20; Thu, 01 Jun 2023 18:25:34 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=iwx0XcTs; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232084AbjFBBSH (ORCPT + 99 others); Thu, 1 Jun 2023 21:18:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43220 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231213AbjFBBSG (ORCPT ); Thu, 1 Jun 2023 21:18:06 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 87827E4E for ; Thu, 1 Jun 2023 18:17:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1685668621; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Z89lfLkyR3wUxURBnMByyXkAk3prI/BY4d5M95naVOE=; b=iwx0XcTsvCNX3i/UTMua8z9pgqo+lZK3/kGR4WvUpuqo3MFyAmNVBNougZzjfK7sb4dn8j Yz2Y0Jdhs9nBqcSCl5C+576aODJ6TtiuVX2Qewl+6c0JhMECheB+rMYlCzJk1QJEgluxDw goc3oro8XEHHUx0rKbXmiRcWhV1RNAY= Received: from mail-pj1-f71.google.com (mail-pj1-f71.google.com [209.85.216.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-34-Xjj9rwVnM32-EUUpDMPvoQ-1; Thu, 01 Jun 2023 21:17:00 -0400 X-MC-Unique: Xjj9rwVnM32-EUUpDMPvoQ-1 Received: by mail-pj1-f71.google.com with SMTP id 98e67ed59e1d1-256b2c2baf1so1251000a91.3 for ; Thu, 01 Jun 2023 18:17:00 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685668619; x=1688260619; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Z89lfLkyR3wUxURBnMByyXkAk3prI/BY4d5M95naVOE=; b=hAyVxNdM+7RbcEPVQ/WXUNB6tnsvZ78AAwVSfwIz8GpGBXbKbRSJ4bhreHtjliiXub 9u/q6Kwx8guY+RRSvm74N4jdg+/p6Ob59t5feFM/EOHOAmY6kgVRHx0sap6Xxm/gPVTZ nf6aNr0oJbDxqUKqj8GJ7a7OV/4p8xHTUc+1/2R1CD3VWvgTMVI3Q+m+h18I0zJuK85/ aq0L4tZyiUPiw8CwAx1fjCUFUt/qQgroJ7cKmLY2ceZc/F4lQnfZFX65ZvmLR0o9SwEt ALH/YrAuYbA3dyqXTjmNfPcYlj7KVOV4kzdwoxdF7AvFAtVF4G2vy/EM5in/QD6bPc/L S7xA== X-Gm-Message-State: AC+VfDxwR0p51OLpQPLK1qVJ7hXuRNZDf2OxD4AFwM3zzKHsWuG/0N3D JTDJthY6edbxjkg9AxX9/keJQ/vJhMOdWDY1nP+pD/KRz/6gDJQ9/05Yn1KeHvWoi7hml8Q3uzI 7kPBkZM/DvgtWx40EY3XMeItl X-Received: by 2002:a17:90a:5d8d:b0:256:5a91:5b8 with SMTP id t13-20020a17090a5d8d00b002565a9105b8mr1047624pji.5.1685668619468; Thu, 01 Jun 2023 18:16:59 -0700 (PDT) X-Received: by 2002:a17:90a:5d8d:b0:256:5a91:5b8 with SMTP id t13-20020a17090a5d8d00b002565a9105b8mr1047611pji.5.1685668619201; Thu, 01 Jun 2023 18:16:59 -0700 (PDT) Received: from [10.72.12.188] ([209.132.188.80]) by smtp.gmail.com with ESMTPSA id e5-20020a170902784500b001ac896ff65fsm22571pln.129.2023.06.01.18.16.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 01 Jun 2023 18:16:58 -0700 (PDT) Message-ID: <64672c51-498a-2a0c-4d4e-caca145fa744@redhat.com> Date: Fri, 2 Jun 2023 09:16:51 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH v2 01/13] fs: export mnt_idmap_get/mnt_idmap_put Content-Language: en-US To: Alexander Mikhalitsyn Cc: brauner@kernel.org, stgraber@ubuntu.com, linux-fsdevel@vger.kernel.org, Ilya Dryomov , Jeff Layton , Alexander Viro , Seth Forshee , ceph-devel@vger.kernel.org, linux-kernel@vger.kernel.org References: <20230524153316.476973-1-aleksandr.mikhalitsyn@canonical.com> <20230524153316.476973-2-aleksandr.mikhalitsyn@canonical.com> From: Xiubo Li In-Reply-To: <20230524153316.476973-2-aleksandr.mikhalitsyn@canonical.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 5/24/23 23:33, Alexander Mikhalitsyn wrote: > These helpers are required to support idmapped mounts in the Cephfs. > > Signed-off-by: Alexander Mikhalitsyn > --- > fs/mnt_idmapping.c | 2 ++ > include/linux/mnt_idmapping.h | 3 +++ > 2 files changed, 5 insertions(+) > > diff --git a/fs/mnt_idmapping.c b/fs/mnt_idmapping.c > index 4905665c47d0..5a579e809bcf 100644 > --- a/fs/mnt_idmapping.c > +++ b/fs/mnt_idmapping.c > @@ -256,6 +256,7 @@ struct mnt_idmap *mnt_idmap_get(struct mnt_idmap *idmap) > > return idmap; > } > +EXPORT_SYMBOL(mnt_idmap_get); > > /** > * mnt_idmap_put - put a reference to an idmapping > @@ -271,3 +272,4 @@ void mnt_idmap_put(struct mnt_idmap *idmap) > kfree(idmap); > } > } > +EXPORT_SYMBOL(mnt_idmap_put); > diff --git a/include/linux/mnt_idmapping.h b/include/linux/mnt_idmapping.h > index 057c89867aa2..b8da2db4ecd2 100644 > --- a/include/linux/mnt_idmapping.h > +++ b/include/linux/mnt_idmapping.h > @@ -115,6 +115,9 @@ static inline bool vfsgid_eq_kgid(vfsgid_t vfsgid, kgid_t kgid) > > int vfsgid_in_group_p(vfsgid_t vfsgid); > > +struct mnt_idmap *mnt_idmap_get(struct mnt_idmap *idmap); > +void mnt_idmap_put(struct mnt_idmap *idmap); > + > vfsuid_t make_vfsuid(struct mnt_idmap *idmap, > struct user_namespace *fs_userns, kuid_t kuid); > Hi Alexander, This needs the "fs/mnt_idmapping.c" maintainer's ack. Thanks - Xiubo