Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp1563899rwd; Thu, 1 Jun 2023 18:25:42 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7pbWUO7HXxyOIpyfNt77mf7i+3DnAfUSPFpSbJv61Fz21MppdDt0XEO5cDTwJnP9g874iE X-Received: by 2002:ac8:5fd3:0:b0:3e6:4d56:448c with SMTP id k19-20020ac85fd3000000b003e64d56448cmr13322753qta.30.1685669141930; Thu, 01 Jun 2023 18:25:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1685669141; cv=none; d=google.com; s=arc-20160816; b=XcVQRy0+MmWRANtfdXJ041wG/fQC9nQD8fj99NJS+ccZkzR65nzzjgi+1cmWq+yaiT mZRv6iy03ygm67r0F0pWCBoT0iJgq0mKZ8EuQ5XLy5jg5S+R2ezvzJoVrePumTucWApO up7wh1215RKgJT1aHYs9MUOe//4cnW1Sd2U3VF4mTe8aG3o8KpXTFPSkdWLk/ig4kkNu z7znupwjK9xUL6IzVbnF/b/YrSwMqWnEJYWGoFz9GVqKU1M0vHyWO0fk2w/qqJBDKmNT auF1JrEPfEgQ0aL6+5CxzuqIlwEbgNEtzFOZygyroJbSdrXfStGr9cEnJx59FEsSzjrL tWwQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:dkim-signature; bh=YXNA4frNVbyK/VK5UJk0y5hVGmAfJ3/L7mZMsF+Debs=; b=hGie3CNJFuL+OGIZxrZni0ckqtQ05Haf0l/XoAGuIRV9S+n8mo8mVYyirvGkihinrb ZwxoF/zivOOzj+RSMfgUSjix2S+WDS3Js+fCP7WJi9RAGDP+mWFHP8cvhj3U/w7ihjYP hllZqgq9QbXFGWjKPHSHW6EVU/PPCjReyhLpxZtrQRztmjn3//j6eXxZj3fZGnLHJIoV YafvMGgX3Di3AER5QBJ19FA4tZKDSLhSFoK5VzTjQVR1AHWZwdQ+4LiHzAUy1TTEaEFv wUDkwRVbOMEQWWE7lUqz29Gh35l/mZP1faVxG5OdaU7SGqHgKyKbRdb1WJyM1imqY5KI pnnQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20221208 header.b=ffHjqiBj; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id z17-20020a63b911000000b0052c4e3dafa4si118860pge.395.2023.06.01.18.25.28; Thu, 01 Jun 2023 18:25:41 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20221208 header.b=ffHjqiBj; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233397AbjFBBXK (ORCPT + 99 others); Thu, 1 Jun 2023 21:23:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48350 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233428AbjFBBXJ (ORCPT ); Thu, 1 Jun 2023 21:23:09 -0400 Received: from mail-pl1-x649.google.com (mail-pl1-x649.google.com [IPv6:2607:f8b0:4864:20::649]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7605F1B5 for ; Thu, 1 Jun 2023 18:22:54 -0700 (PDT) Received: by mail-pl1-x649.google.com with SMTP id d9443c01a7336-1b03ae23cf7so6942325ad.3 for ; Thu, 01 Jun 2023 18:22:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1685668974; x=1688260974; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=YXNA4frNVbyK/VK5UJk0y5hVGmAfJ3/L7mZMsF+Debs=; b=ffHjqiBjCvce6CRxC8S8V/5PV32SBNbNg5npnOcKnrbM7KDaCusjJvavHMNLekX7m3 hpqylvq993mnGqaD6yNASSM0if2Mk7u1MQaseW+ZQFOapPY+CnxJK9TeSglfq1cGQDJJ JjQswBdBugf42sqOa3TmhOXSyNgLLOI3Zhi4U5IutBj00Os32FI1ec3393X4cE5w/wJ+ L/MKchT59UEUxZjUtT1hxHVMzoZCB27maz/dxz92BkZHy8hCBw+dZRFeDM84caKxj3Ed Q57jSZQ0mYWrMMGJ47J6A/kugKSeRI772HmK501YBxbZ5HuNUxC1GOEDz6NBXdGx7WGU dZ7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685668974; x=1688260974; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=YXNA4frNVbyK/VK5UJk0y5hVGmAfJ3/L7mZMsF+Debs=; b=eEbxLDvJrzomLdSRUS31w0sGY4qjS4pZYoOVuLVIWuDP4/4ZANS98Th+qP0QxBCYy+ gID6cCeFAAtzXGKfSpFKsoOqmOUCiw3PEAQluLnTuGjbDXhjrcoZBOmpYvRIof7XLuMv uPMnxedNPbZLiJsgXVXrhmkyi9LCYPgax26fc4pxSoBVS2URtUD30kZptcEfdPonZv0z Gj5V4LSyIOO8PhOq2shoGN0RQ3FdkypCal074+xmobbA/Fp53cWgKVpbZHI2QfDTaeUN jalA1qTwiwXzKU/oqFuzB4U0tb36cjoUHj3m0h5c3vtYHwu/KjosEjQQNkZN6Z6rm+5M ucPQ== X-Gm-Message-State: AC+VfDw95nM0weYDYNq3aMaX16Y2/JCptwYefkctUbPq0OE7O83LNzxG ZBKa08Qh8bebj6nJd8JQ3MHIq0NhZjs= X-Received: from zagreus.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5c37]) (user=seanjc job=sendgmr) by 2002:a17:902:d4c6:b0:1ae:485e:d192 with SMTP id o6-20020a170902d4c600b001ae485ed192mr271922plg.8.1685668973984; Thu, 01 Jun 2023 18:22:53 -0700 (PDT) Date: Thu, 1 Jun 2023 18:22:44 -0700 In-Reply-To: <20230523032947.60041-1-likexu@tencent.com> Mime-Version: 1.0 References: <20230523032947.60041-1-likexu@tencent.com> X-Mailer: git-send-email 2.41.0.rc2.161.g9c6817b8e7-goog Message-ID: <168512505582.2748967.2085008237309190510.b4-ty@google.com> Subject: Re: [PATCH v2] KVM: x86/mmu: Assert on @mmu in the __kvm_mmu_invalidate_addr() From: Sean Christopherson To: Sean Christopherson , Like Xu Cc: Paolo Bonzini , kvm@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" X-Spam-Status: No, score=-9.6 required=5.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 23 May 2023 11:29:47 +0800, Like Xu wrote: > Add assertion to track that "mmu == vcpu->arch.mmu" is always true in the > context of __kvm_mmu_invalidate_addr(). for_each_shadow_entry_using_root() > and kvm_sync_spte() operate on vcpu->arch.mmu, but the only reason that > doesn't cause explosions is because handle_invept() frees roots instead of > doing a manual invalidation. As of now, there are no major roadblocks > to switching INVEPT emulation over to use kvm_mmu_invalidate_addr(). > > [...] Applied to kvm-x86 mmu, thanks! [1/1] KVM: x86/mmu: Assert on @mmu in the __kvm_mmu_invalidate_addr() https://github.com/kvm-x86/linux/commit/762b33eb90c9 -- https://github.com/kvm-x86/linux/tree/next https://github.com/kvm-x86/linux/tree/fixes